From: Michael Tokarev <mjt@tls.msk.ru>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: gtk-vnc-list@gnome.org
Subject: Re: [Qemu-devel] [PATCH v2 2/2] kbd: add brazil kbd keys to x11 evdev map
Date: Thu, 28 May 2015 13:45:08 +0300 [thread overview]
Message-ID: <5566F1B4.6030300@msgid.tls.msk.ru> (raw)
In-Reply-To: <1432798845-10118-2-git-send-email-kraxel@redhat.com>
28.05.2015 10:40, Gerd Hoffmann wrote:
> This patch adds the two extra brazilian keys to the evdev keymap for
> X11. This patch gets the two keys going with the vnc, gtk and sdl1
> UIs.
>
> The SDL2 library complains it doesn't know these keys, so the SDL2
> library must be fixed before we can update ui/sdl2-keymap.h
Just a small nitpick: maybe you can actually add the necessary
line to sdl2-keymap.h too, but comment it out, so the knowlege
we gained in this episode remains in there?
In either case, for both patches:
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Thank you for your work!
/mjt
next prev parent reply other threads:[~2015-05-28 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 7:40 [Qemu-devel] [PATCH v2 1/2] kbd: add brazil kbd keys to qemu Gerd Hoffmann
2015-05-28 7:40 ` [Qemu-devel] [PATCH v2 2/2] kbd: add brazil kbd keys to x11 evdev map Gerd Hoffmann
2015-05-28 8:49 ` Markus Armbruster
2015-05-28 8:54 ` Daniel P. Berrange
2015-05-28 10:45 ` Michael Tokarev [this message]
2015-05-28 8:53 ` [Qemu-devel] [PATCH v2 1/2] kbd: add brazil kbd keys to qemu Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5566F1B4.6030300@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=gtk-vnc-list@gnome.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.