From: "Ouyang Zhaowei (Charles)" <ouyangzhaowei@huawei.com>
To: David Vrabel <david.vrabel@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: <linux-kernel@vger.kernel.org>,
Dingweiping <weiping.ding@huawei.com>,
Yanqiangjun <yanqiangjun@huawei.com>, <jinjian@huawei.com>
Subject: Re: [RESEND PATCH] xen: vcpu_info would be reset to wrong place on canceled suspend on PVOPS VM which has multi-cpu
Date: Thu, 28 May 2015 19:38:26 +0800 [thread overview]
Message-ID: <5566FE32.6000300@huawei.com> (raw)
In-Reply-To: <5566F6FE.30607@citrix.com>
On 2015.5.28 19:07, David Vrabel wrote:
> On 06/05/15 02:47, Ouyang Zhaowei (Charles) wrote:
>> vcpu_info would be reset to wrong place on canceled suspend on PVOPS VM which has multi-cpu
>>
>> The hypervisor continues assuming that vcpu_info is stored in per-cpu data which was set up by xen_vcpu_setup(),
>> while on canceled suspend, the call to xen_hvm_init_shared_info() will make the guest think that vcpu_info
>> is in the shared page. This will cause non-boot cpus keep checking a wrong vcpu_info address and can not handle
>> irqs any more after suspend canceled, for example after we do "xl save -c/restore", PVOPS VM can not be resumed
>> as the cpus can not finish their irqs.
>>
>>
>> Signed-off-by: Charles Ouyang <ouyangzhaowei@huawei.com>
>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> Reviewed-by: David Vrabel <david.vrabel@citrix.com>
>
> 1. I don't think I offered a reviewed-by tag for this patch
> 2. You did not Cc the xen-devel mailing list on this patch.
> 3. The patch is white-space damaged.
> 4. The commit message has lines longer than ~72 chars.
Sorry about that, this is my first time to send patch, and I didn't notice that it was white-space damaged.
I'll modify the patch and commit message as you applied and Cc Xen-devel mailing list.
Thanks
Ouyang Zhaowei
>
> But I've applied this to for-linus-4.1b anyway, thanks.
>
> David
>
>
> .
>
next prev parent reply other threads:[~2015-05-28 11:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 1:47 [RESEND PATCH] xen: vcpu_info would be reset to wrong place on canceled suspend on PVOPS VM which has multi-cpu Ouyang Zhaowei (Charles)
2015-05-28 8:34 ` Ouyang Zhaowei (Charles)
2015-05-28 11:07 ` David Vrabel
2015-05-28 11:38 ` Ouyang Zhaowei (Charles) [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-05-04 2:56 Ouyang Zhaowei (Charles)
2015-05-05 9:09 ` David Vrabel
2015-05-05 13:19 ` Ouyang Zhaowei (Charles)
2015-05-05 17:21 ` David Vrabel
2015-05-06 1:41 ` Ouyang Zhaowei (Charles)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5566FE32.6000300@huawei.com \
--to=ouyangzhaowei@huawei.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jinjian@huawei.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=weiping.ding@huawei.com \
--cc=yanqiangjun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.