From: "André Hentschel" <nerv@dawncrow.de>
To: Will Deacon <will.deacon@arm.com>
Cc: "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Nathan Lynch <nathan_lynch@mentor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] arm64: Preserve the user r/w register tpidr_el0 on context switch and fork in compat mode
Date: Thu, 28 May 2015 20:43:30 +0200 [thread overview]
Message-ID: <556761D2.9040908@dawncrow.de> (raw)
In-Reply-To: <20150527143648.GA4232@arm.com>
Am 27.05.2015 um 16:36 schrieb Will Deacon:
> Hi André,
>
> On Wed, May 20, 2015 at 05:18:29PM +0100, André Hentschel wrote:
>> From: André Hentschel <nerv@dawncrow.de>
>>
>> Since commit a4780adeefd042482f624f5e0d577bf9cdcbb760 the user writeable TLS
>> register on ARM is preserved per thread.
>>
>> This patch does it analogous to the ARM patch, but for compat mode on ARM64.
>>
>> Signed-off-by: André Hentschel <nerv@dawncrow.de>
>> Cc: Will Deacon <will.deacon@arm.com>
>> Cc: Catalin Marinas <catalin.marinas@arm.com>
>>
>> ---
>> This patch is against Linux 4.1-rc1 (b787f68c36d49bb1d9236f403813641efa74a031)
>>
>> v2: Trying to address suggestions by Will Deacon
>>
>> @Will Deacon: The macro you suggested is not helpful it seems, instead i introduced
>> static functions. They also could be macros i guess, but it seems
>> much cleaner to me to use functions as it only affects one file.
>
> I wanted to understand in more detail why the macro didn't work out for
> you, so I trued hacking together my own version of the patch (see below).
> It seems to hold up to light testing, so it would be good to know where
> you ran into problems.
>
>> Should the final version be send to rmk's patchtracker or will someone
>> else pick it up?
>
> This is an arm64 patch, so either Catalin or me will pick it up directly
> when it's ready to be merged.
>
> Will
Your patch works, you can add me as Tested-by. :)
My bad was that i didn't know that macro style (returning a variable conditionally with c code)
Sadly no new commit by me :(
WARNING: multiple messages have this Message-ID (diff)
From: "André Hentschel" <nerv@dawncrow.de>
To: Will Deacon <will.deacon@arm.com>
Cc: "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Nathan Lynch <nathan_lynch@mentor.com>
Subject: Re: [PATCH v2] arm64: Preserve the user r/w register tpidr_el0 on context switch and fork in compat mode
Date: Thu, 28 May 2015 20:43:30 +0200 [thread overview]
Message-ID: <556761D2.9040908@dawncrow.de> (raw)
Message-ID: <20150528184330.pldXYIrJhoaq9fJwamA_X0zpY_WCmslieoqvXI7QsQI@z> (raw)
In-Reply-To: <20150527143648.GA4232@arm.com>
Am 27.05.2015 um 16:36 schrieb Will Deacon:
> Hi André,
>
> On Wed, May 20, 2015 at 05:18:29PM +0100, André Hentschel wrote:
>> From: André Hentschel <nerv@dawncrow.de>
>>
>> Since commit a4780adeefd042482f624f5e0d577bf9cdcbb760 the user writeable TLS
>> register on ARM is preserved per thread.
>>
>> This patch does it analogous to the ARM patch, but for compat mode on ARM64.
>>
>> Signed-off-by: André Hentschel <nerv@dawncrow.de>
>> Cc: Will Deacon <will.deacon@arm.com>
>> Cc: Catalin Marinas <catalin.marinas@arm.com>
>>
>> ---
>> This patch is against Linux 4.1-rc1 (b787f68c36d49bb1d9236f403813641efa74a031)
>>
>> v2: Trying to address suggestions by Will Deacon
>>
>> @Will Deacon: The macro you suggested is not helpful it seems, instead i introduced
>> static functions. They also could be macros i guess, but it seems
>> much cleaner to me to use functions as it only affects one file.
>
> I wanted to understand in more detail why the macro didn't work out for
> you, so I trued hacking together my own version of the patch (see below).
> It seems to hold up to light testing, so it would be good to know where
> you ran into problems.
>
>> Should the final version be send to rmk's patchtracker or will someone
>> else pick it up?
>
> This is an arm64 patch, so either Catalin or me will pick it up directly
> when it's ready to be merged.
>
> Will
Your patch works, you can add me as Tested-by. :)
My bad was that i didn't know that macro style (returning a variable conditionally with c code)
Sadly no new commit by me :(
WARNING: multiple messages have this Message-ID (diff)
From: nerv@dawncrow.de (André Hentschel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: Preserve the user r/w register tpidr_el0 on context switch and fork in compat mode
Date: Thu, 28 May 2015 20:43:30 +0200 [thread overview]
Message-ID: <556761D2.9040908@dawncrow.de> (raw)
In-Reply-To: <20150527143648.GA4232@arm.com>
Am 27.05.2015 um 16:36 schrieb Will Deacon:
> Hi Andr?,
>
> On Wed, May 20, 2015 at 05:18:29PM +0100, Andr? Hentschel wrote:
>> From: Andr? Hentschel <nerv@dawncrow.de>
>>
>> Since commit a4780adeefd042482f624f5e0d577bf9cdcbb760 the user writeable TLS
>> register on ARM is preserved per thread.
>>
>> This patch does it analogous to the ARM patch, but for compat mode on ARM64.
>>
>> Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
>> Cc: Will Deacon <will.deacon@arm.com>
>> Cc: Catalin Marinas <catalin.marinas@arm.com>
>>
>> ---
>> This patch is against Linux 4.1-rc1 (b787f68c36d49bb1d9236f403813641efa74a031)
>>
>> v2: Trying to address suggestions by Will Deacon
>>
>> @Will Deacon: The macro you suggested is not helpful it seems, instead i introduced
>> static functions. They also could be macros i guess, but it seems
>> much cleaner to me to use functions as it only affects one file.
>
> I wanted to understand in more detail why the macro didn't work out for
> you, so I trued hacking together my own version of the patch (see below).
> It seems to hold up to light testing, so it would be good to know where
> you ran into problems.
>
>> Should the final version be send to rmk's patchtracker or will someone
>> else pick it up?
>
> This is an arm64 patch, so either Catalin or me will pick it up directly
> when it's ready to be merged.
>
> Will
Your patch works, you can add me as Tested-by. :)
My bad was that i didn't know that macro style (returning a variable conditionally with c code)
Sadly no new commit by me :(
next prev parent reply other threads:[~2015-05-28 18:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 16:18 [PATCH v2] arm64: Preserve the user r/w register tpidr_el0 on context switch and fork in compat mode André Hentschel
2015-05-20 16:18 ` André Hentschel
2015-05-27 14:36 ` Will Deacon
2015-05-27 14:36 ` Will Deacon
2015-05-28 18:43 ` André Hentschel [this message]
2015-05-28 18:43 ` André Hentschel
2015-05-28 18:43 ` André Hentschel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556761D2.9040908@dawncrow.de \
--to=nerv@dawncrow.de \
--cc=Catalin.Marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nathan_lynch@mentor.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.