From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
kernel@pengutronix.de
Subject: Re: [PATCH] fbdev: omap2: improve usage of gpiod API
Date: Fri, 29 May 2015 06:07:27 +0000 [thread overview]
Message-ID: <5568021F.8000706@ti.com> (raw)
In-Reply-To: <1432800315-25972-1-git-send-email-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]
On 28/05/15 11:05, Uwe Kleine-König wrote:
> Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
> which appeared in v3.17-rc1, the gpiod_get* functions take an additional
> parameter that allows to specify direction and initial value for output.
>
> Also make use of gpiod_get*_optional where applicable.
>
> Apart from simplification of the affected drivers this is another step
> towards making the flags argument to gpiod_get*() mandatory.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/video/fbdev/omap2/displays-new/encoder-opa362.c | 12 +++---------
> drivers/video/fbdev/omap2/displays-new/panel-dpi.c | 13 +++----------
> .../fbdev/omap2/displays-new/panel-lgphilips-lb035q02.c | 7 +++----
> .../fbdev/omap2/displays-new/panel-sharp-ls037v7dw01.c | 9 ++-------
> 4 files changed, 11 insertions(+), 30 deletions(-)
Thanks, this cleans up nicely those optional cases. Queued for 4.2.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
kernel@pengutronix.de
Subject: Re: [PATCH] fbdev: omap2: improve usage of gpiod API
Date: Fri, 29 May 2015 09:07:27 +0300 [thread overview]
Message-ID: <5568021F.8000706@ti.com> (raw)
In-Reply-To: <1432800315-25972-1-git-send-email-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]
On 28/05/15 11:05, Uwe Kleine-König wrote:
> Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
> which appeared in v3.17-rc1, the gpiod_get* functions take an additional
> parameter that allows to specify direction and initial value for output.
>
> Also make use of gpiod_get*_optional where applicable.
>
> Apart from simplification of the affected drivers this is another step
> towards making the flags argument to gpiod_get*() mandatory.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/video/fbdev/omap2/displays-new/encoder-opa362.c | 12 +++---------
> drivers/video/fbdev/omap2/displays-new/panel-dpi.c | 13 +++----------
> .../fbdev/omap2/displays-new/panel-lgphilips-lb035q02.c | 7 +++----
> .../fbdev/omap2/displays-new/panel-sharp-ls037v7dw01.c | 9 ++-------
> 4 files changed, 11 insertions(+), 30 deletions(-)
Thanks, this cleans up nicely those optional cases. Queued for 4.2.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-05-29 6:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 8:05 [PATCH] fbdev: omap2: improve usage of gpiod API Uwe Kleine-König
2015-05-28 8:05 ` Uwe Kleine-König
2015-05-29 6:07 ` Tomi Valkeinen [this message]
2015-05-29 6:07 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5568021F.8000706@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.