From: hauke@hauke-m.de (Hauke Mehrtens)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: l2c: add options to overwrite prefetching behavior
Date: Fri, 29 May 2015 19:33:33 +0200 [thread overview]
Message-ID: <5568A2ED.4000502@hauke-m.de> (raw)
In-Reply-To: <1431726751-9169-1-git-send-email-hauke@hauke-m.de>
Will this make it into kernel 4.2 or do I have to do something so that
this will make it into 4.2?
Hauke
On 05/15/2015 11:52 PM, Hauke Mehrtens wrote:
> These options make it possible to overwrites the data and instruction
> prefetching behavior of the arm pl310 cache controller.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> v2: only set prefetch
> v1: set prefetch and aux
>
> Documentation/devicetree/bindings/arm/l2cc.txt | 4 ++++
> arch/arm/mm/cache-l2x0.c | 20 ++++++++++++++++++++
> 2 files changed, 24 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/l2cc.txt b/Documentation/devicetree/bindings/arm/l2cc.txt
> index 0dbabe9..528821a 100644
> --- a/Documentation/devicetree/bindings/arm/l2cc.txt
> +++ b/Documentation/devicetree/bindings/arm/l2cc.txt
> @@ -67,6 +67,10 @@ Optional properties:
> disable if zero.
> - arm,prefetch-offset : Override prefetch offset value. Valid values are
> 0-7, 15, 23, and 31.
> +- arm,prefetch-data : Enable data prefetch. Enabling prefetching
> + can improve performance.
> +- arm,prefetch-instr : Enable instruction prefetch. Enabling prefetching
> + can improve performance.
>
> Example:
>
> diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
> index e309c8f..1aa970a 100644
> --- a/arch/arm/mm/cache-l2x0.c
> +++ b/arch/arm/mm/cache-l2x0.c
> @@ -1199,6 +1199,26 @@ static void __init l2c310_of_parse(const struct device_node *np,
> pr_err("L2C-310 OF arm,prefetch-offset property value is missing\n");
> }
>
> + ret = of_property_read_u32(np, "arm,prefetch-data", &val);
> + if (ret == 0) {
> + if (val)
> + prefetch |= L310_PREFETCH_CTRL_DATA_PREFETCH;
> + else
> + prefetch &= ~L310_PREFETCH_CTRL_DATA_PREFETCH;
> + } else if (ret != -EINVAL) {
> + pr_err("L2C-310 OF arm,prefetch-data property value is missing\n");
> + }
> +
> + ret = of_property_read_u32(np, "arm,prefetch-instr", &val);
> + if (ret == 0) {
> + if (val)
> + prefetch |= L310_PREFETCH_CTRL_INSTR_PREFETCH;
> + else
> + prefetch &= ~L310_PREFETCH_CTRL_INSTR_PREFETCH;
> + } else if (ret != -EINVAL) {
> + pr_err("L2C-310 OF arm,prefetch-instr property value is missing\n");
> + }
> +
> l2x0_saved_regs.prefetch_ctrl = prefetch;
> }
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Hauke Mehrtens <hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org>
To: linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org,
catalin.marinas-5wv7dgnIgG8@public.gmane.org,
"Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v3] ARM: l2c: add options to overwrite prefetching behavior
Date: Fri, 29 May 2015 19:33:33 +0200 [thread overview]
Message-ID: <5568A2ED.4000502@hauke-m.de> (raw)
In-Reply-To: <1431726751-9169-1-git-send-email-hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org>
Will this make it into kernel 4.2 or do I have to do something so that
this will make it into 4.2?
Hauke
On 05/15/2015 11:52 PM, Hauke Mehrtens wrote:
> These options make it possible to overwrites the data and instruction
> prefetching behavior of the arm pl310 cache controller.
>
> Signed-off-by: Hauke Mehrtens <hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org>
> ---
> v2: only set prefetch
> v1: set prefetch and aux
>
> Documentation/devicetree/bindings/arm/l2cc.txt | 4 ++++
> arch/arm/mm/cache-l2x0.c | 20 ++++++++++++++++++++
> 2 files changed, 24 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/l2cc.txt b/Documentation/devicetree/bindings/arm/l2cc.txt
> index 0dbabe9..528821a 100644
> --- a/Documentation/devicetree/bindings/arm/l2cc.txt
> +++ b/Documentation/devicetree/bindings/arm/l2cc.txt
> @@ -67,6 +67,10 @@ Optional properties:
> disable if zero.
> - arm,prefetch-offset : Override prefetch offset value. Valid values are
> 0-7, 15, 23, and 31.
> +- arm,prefetch-data : Enable data prefetch. Enabling prefetching
> + can improve performance.
> +- arm,prefetch-instr : Enable instruction prefetch. Enabling prefetching
> + can improve performance.
>
> Example:
>
> diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
> index e309c8f..1aa970a 100644
> --- a/arch/arm/mm/cache-l2x0.c
> +++ b/arch/arm/mm/cache-l2x0.c
> @@ -1199,6 +1199,26 @@ static void __init l2c310_of_parse(const struct device_node *np,
> pr_err("L2C-310 OF arm,prefetch-offset property value is missing\n");
> }
>
> + ret = of_property_read_u32(np, "arm,prefetch-data", &val);
> + if (ret == 0) {
> + if (val)
> + prefetch |= L310_PREFETCH_CTRL_DATA_PREFETCH;
> + else
> + prefetch &= ~L310_PREFETCH_CTRL_DATA_PREFETCH;
> + } else if (ret != -EINVAL) {
> + pr_err("L2C-310 OF arm,prefetch-data property value is missing\n");
> + }
> +
> + ret = of_property_read_u32(np, "arm,prefetch-instr", &val);
> + if (ret == 0) {
> + if (val)
> + prefetch |= L310_PREFETCH_CTRL_INSTR_PREFETCH;
> + else
> + prefetch &= ~L310_PREFETCH_CTRL_INSTR_PREFETCH;
> + } else if (ret != -EINVAL) {
> + pr_err("L2C-310 OF arm,prefetch-instr property value is missing\n");
> + }
> +
> l2x0_saved_regs.prefetch_ctrl = prefetch;
> }
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-29 17:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 21:52 [PATCH v3] ARM: l2c: add options to overwrite prefetching behavior Hauke Mehrtens
2015-05-15 21:52 ` Hauke Mehrtens
2015-05-29 17:33 ` Hauke Mehrtens [this message]
2015-05-29 17:33 ` Hauke Mehrtens
2015-05-29 17:49 ` Russell King - ARM Linux
2015-05-29 17:49 ` Russell King - ARM Linux
2015-05-29 17:52 ` Florian Fainelli
2015-05-29 17:52 ` Florian Fainelli
2015-05-29 18:11 ` Hauke Mehrtens
2015-05-29 18:11 ` Hauke Mehrtens
2015-05-29 18:30 ` Florian Fainelli
2015-05-29 18:30 ` Florian Fainelli
2015-05-29 18:35 ` Florian Fainelli
2015-05-29 18:35 ` Florian Fainelli
2015-05-29 18:46 ` Hauke Mehrtens
2015-05-29 18:46 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5568A2ED.4000502@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.