All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: Joachim Eastwood <manabian@gmail.com>,
	Richard Weinberger <richard@nod.at>
Cc: devicetree@vger.kernel.org,
	Ariel D'Alessandro <ariel.dalessandro@gmail.com>,
	linux-mtd@lists.infradead.org, shijie.huang@intel.com,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] mtd: spi-nor: add driver for NXP SPI Flash Interface (SPIFI)
Date: Sat, 30 May 2015 16:37:06 -0300	[thread overview]
Message-ID: <556A1162.7060400@vanguardiasur.com.ar> (raw)
In-Reply-To: <CAGhQ9VzDDK6dh6pGUzp_-h42NPROQJG=2D96WMWjZJEAoVqAFQ@mail.gmail.com>



On 05/30/2015 04:37 PM, Joachim Eastwood wrote:
> On 30 May 2015 at 21:33, Richard Weinberger <richard@nod.at> wrote:
>> Am 30.05.2015 um 20:08 schrieb Ezequiel Garcia:
>>> +Richard
>>>
>>> On 05/30/2015 01:51 PM, Joachim Eastwood wrote:
>>>> Hi Ezequiel,
>>>>
>>>> On 30 May 2015 at 17:43, Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote:
>>>>> Hi Joachim,
>>>>>
>>>>> Looks pretty neat. I've just a couple comments.
>>>>>
>>>>> On 05/29/2015 02:50 PM, Joachim Eastwood wrote:
>>>>>> Add SPI-NOR driver for the SPI Flash Interface (SPIFI)
>>>>>> controller that is found newer NXP MCU devices.
>>>>>>
>>>>>> The controller supports serial SPI Flash devices with 1-, 2-
>>>>>> and 4-bit width in either SPI mode 0 or 3. The controller
>>>>>> can operate in either command or memory mode. In memory mode
>>>>>> the Flash is exposed as normal memory and can be directly
>>>>>> accessed by the CPU.
>>>>>>
>>>>>> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
>>>>>> ---
>>>>>>  drivers/mtd/spi-nor/Kconfig     |  10 +
>>>>>>  drivers/mtd/spi-nor/Makefile    |   1 +
>>>>>>  drivers/mtd/spi-nor/nxp-spifi.c | 508 ++++++++++++++++++++++++++++++++++++++++
>>>>>>  3 files changed, 519 insertions(+)
>>>>>>  create mode 100644 drivers/mtd/spi-nor/nxp-spifi.c
>>>>>>
>>>>>> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
>>>>>> index 64a4f0edabc7..f10a37f1a4ef 100644
>>>>>> --- a/drivers/mtd/spi-nor/Kconfig
>>>>>> +++ b/drivers/mtd/spi-nor/Kconfig
>>>>>> @@ -28,4 +28,14 @@ config SPI_FSL_QUADSPI
>>>>>>         This enables support for the Quad SPI controller in master mode.
>>>>>>         We only connect the NOR to this controller now.
>>>>>>
>>>>>> +config SPI_NXP_SPIFI
>>>>>> +     tristate "NXP SPI Flash Interface (SPIFI)"
>>>>>> +     depends on OF && (ARCH_LPC18XX || COMPILE_TEST)
>>>>>
>>>>> Since you are adding COMPILE_TEST, maybe you want
>>>>> 'depends on HAS_IOMEM' as well?
>>>>
>>>> Since MTD depends on GENERIC_IO is that needed?
>>>> Or am I confusing the config options here(?)
>>>>
>>>
>>> I think you need HAS_IOMEM for ioremap stuff.
>>> Maybe Brian or Richard will know better.
>>
>> Yes, if you need ioremap() your driver has to depend on HAS_IOMEM.
>>
>> We have GENERIC_IO to allow non-physical MTD stuff
>> on architectures without io memory, namely s390 and UML.
>> Some time ago I've implemented GENERIC_IO to make nandsim
>> and UBI work on UML.
> 
> Got it.
> Thanks Richard.
> 
> I'll send a new version of the patch within a couple of days.
> 

You can add my reviewed on that.

Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>

-- 
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar

WARNING: multiple messages have this Message-ID (diff)
From: ezequiel@vanguardiasur.com.ar (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] mtd: spi-nor: add driver for NXP SPI Flash Interface (SPIFI)
Date: Sat, 30 May 2015 16:37:06 -0300	[thread overview]
Message-ID: <556A1162.7060400@vanguardiasur.com.ar> (raw)
In-Reply-To: <CAGhQ9VzDDK6dh6pGUzp_-h42NPROQJG=2D96WMWjZJEAoVqAFQ@mail.gmail.com>



On 05/30/2015 04:37 PM, Joachim Eastwood wrote:
> On 30 May 2015 at 21:33, Richard Weinberger <richard@nod.at> wrote:
>> Am 30.05.2015 um 20:08 schrieb Ezequiel Garcia:
>>> +Richard
>>>
>>> On 05/30/2015 01:51 PM, Joachim Eastwood wrote:
>>>> Hi Ezequiel,
>>>>
>>>> On 30 May 2015 at 17:43, Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote:
>>>>> Hi Joachim,
>>>>>
>>>>> Looks pretty neat. I've just a couple comments.
>>>>>
>>>>> On 05/29/2015 02:50 PM, Joachim Eastwood wrote:
>>>>>> Add SPI-NOR driver for the SPI Flash Interface (SPIFI)
>>>>>> controller that is found newer NXP MCU devices.
>>>>>>
>>>>>> The controller supports serial SPI Flash devices with 1-, 2-
>>>>>> and 4-bit width in either SPI mode 0 or 3. The controller
>>>>>> can operate in either command or memory mode. In memory mode
>>>>>> the Flash is exposed as normal memory and can be directly
>>>>>> accessed by the CPU.
>>>>>>
>>>>>> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
>>>>>> ---
>>>>>>  drivers/mtd/spi-nor/Kconfig     |  10 +
>>>>>>  drivers/mtd/spi-nor/Makefile    |   1 +
>>>>>>  drivers/mtd/spi-nor/nxp-spifi.c | 508 ++++++++++++++++++++++++++++++++++++++++
>>>>>>  3 files changed, 519 insertions(+)
>>>>>>  create mode 100644 drivers/mtd/spi-nor/nxp-spifi.c
>>>>>>
>>>>>> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
>>>>>> index 64a4f0edabc7..f10a37f1a4ef 100644
>>>>>> --- a/drivers/mtd/spi-nor/Kconfig
>>>>>> +++ b/drivers/mtd/spi-nor/Kconfig
>>>>>> @@ -28,4 +28,14 @@ config SPI_FSL_QUADSPI
>>>>>>         This enables support for the Quad SPI controller in master mode.
>>>>>>         We only connect the NOR to this controller now.
>>>>>>
>>>>>> +config SPI_NXP_SPIFI
>>>>>> +     tristate "NXP SPI Flash Interface (SPIFI)"
>>>>>> +     depends on OF && (ARCH_LPC18XX || COMPILE_TEST)
>>>>>
>>>>> Since you are adding COMPILE_TEST, maybe you want
>>>>> 'depends on HAS_IOMEM' as well?
>>>>
>>>> Since MTD depends on GENERIC_IO is that needed?
>>>> Or am I confusing the config options here(?)
>>>>
>>>
>>> I think you need HAS_IOMEM for ioremap stuff.
>>> Maybe Brian or Richard will know better.
>>
>> Yes, if you need ioremap() your driver has to depend on HAS_IOMEM.
>>
>> We have GENERIC_IO to allow non-physical MTD stuff
>> on architectures without io memory, namely s390 and UML.
>> Some time ago I've implemented GENERIC_IO to make nandsim
>> and UBI work on UML.
> 
> Got it.
> Thanks Richard.
> 
> I'll send a new version of the patch within a couple of days.
> 

You can add my reviewed on that.

Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>

-- 
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar

WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>
To: Joachim Eastwood
	<manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>
Cc: Brian Norris
	<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	shijie.huang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Ariel D'Alessandro
	<ariel.dalessandro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 1/2] mtd: spi-nor: add driver for NXP SPI Flash Interface (SPIFI)
Date: Sat, 30 May 2015 16:37:06 -0300	[thread overview]
Message-ID: <556A1162.7060400@vanguardiasur.com.ar> (raw)
In-Reply-To: <CAGhQ9VzDDK6dh6pGUzp_-h42NPROQJG=2D96WMWjZJEAoVqAFQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>



On 05/30/2015 04:37 PM, Joachim Eastwood wrote:
> On 30 May 2015 at 21:33, Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org> wrote:
>> Am 30.05.2015 um 20:08 schrieb Ezequiel Garcia:
>>> +Richard
>>>
>>> On 05/30/2015 01:51 PM, Joachim Eastwood wrote:
>>>> Hi Ezequiel,
>>>>
>>>> On 30 May 2015 at 17:43, Ezequiel Garcia <ezequiel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org> wrote:
>>>>> Hi Joachim,
>>>>>
>>>>> Looks pretty neat. I've just a couple comments.
>>>>>
>>>>> On 05/29/2015 02:50 PM, Joachim Eastwood wrote:
>>>>>> Add SPI-NOR driver for the SPI Flash Interface (SPIFI)
>>>>>> controller that is found newer NXP MCU devices.
>>>>>>
>>>>>> The controller supports serial SPI Flash devices with 1-, 2-
>>>>>> and 4-bit width in either SPI mode 0 or 3. The controller
>>>>>> can operate in either command or memory mode. In memory mode
>>>>>> the Flash is exposed as normal memory and can be directly
>>>>>> accessed by the CPU.
>>>>>>
>>>>>> Signed-off-by: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>>>>> ---
>>>>>>  drivers/mtd/spi-nor/Kconfig     |  10 +
>>>>>>  drivers/mtd/spi-nor/Makefile    |   1 +
>>>>>>  drivers/mtd/spi-nor/nxp-spifi.c | 508 ++++++++++++++++++++++++++++++++++++++++
>>>>>>  3 files changed, 519 insertions(+)
>>>>>>  create mode 100644 drivers/mtd/spi-nor/nxp-spifi.c
>>>>>>
>>>>>> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
>>>>>> index 64a4f0edabc7..f10a37f1a4ef 100644
>>>>>> --- a/drivers/mtd/spi-nor/Kconfig
>>>>>> +++ b/drivers/mtd/spi-nor/Kconfig
>>>>>> @@ -28,4 +28,14 @@ config SPI_FSL_QUADSPI
>>>>>>         This enables support for the Quad SPI controller in master mode.
>>>>>>         We only connect the NOR to this controller now.
>>>>>>
>>>>>> +config SPI_NXP_SPIFI
>>>>>> +     tristate "NXP SPI Flash Interface (SPIFI)"
>>>>>> +     depends on OF && (ARCH_LPC18XX || COMPILE_TEST)
>>>>>
>>>>> Since you are adding COMPILE_TEST, maybe you want
>>>>> 'depends on HAS_IOMEM' as well?
>>>>
>>>> Since MTD depends on GENERIC_IO is that needed?
>>>> Or am I confusing the config options here(?)
>>>>
>>>
>>> I think you need HAS_IOMEM for ioremap stuff.
>>> Maybe Brian or Richard will know better.
>>
>> Yes, if you need ioremap() your driver has to depend on HAS_IOMEM.
>>
>> We have GENERIC_IO to allow non-physical MTD stuff
>> on architectures without io memory, namely s390 and UML.
>> Some time ago I've implemented GENERIC_IO to make nandsim
>> and UBI work on UML.
> 
> Got it.
> Thanks Richard.
> 
> I'll send a new version of the patch within a couple of days.
> 

You can add my reviewed on that.

Reviewed-by: Ezequiel Garcia <ezequiel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>

-- 
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-05-30 19:40 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29 17:50 [PATCH 0/2] NXP SPIFI driver for LPC18xx/43xx familiy Joachim Eastwood
2015-05-29 17:50 ` Joachim Eastwood
2015-05-29 17:50 ` Joachim Eastwood
2015-05-29 17:50 ` [PATCH 1/2] mtd: spi-nor: add driver for NXP SPI Flash Interface (SPIFI) Joachim Eastwood
2015-05-29 17:50   ` Joachim Eastwood
2015-05-29 17:50   ` Joachim Eastwood
2015-05-30 15:43   ` Ezequiel Garcia
2015-05-30 15:43     ` Ezequiel Garcia
2015-05-30 15:43     ` Ezequiel Garcia
2015-05-30 16:51     ` Joachim Eastwood
2015-05-30 16:51       ` Joachim Eastwood
2015-05-30 16:51       ` Joachim Eastwood
2015-05-30 18:08       ` Ezequiel Garcia
2015-05-30 18:08         ` Ezequiel Garcia
2015-05-30 18:08         ` Ezequiel Garcia
2015-05-30 19:33         ` Richard Weinberger
2015-05-30 19:33           ` Richard Weinberger
2015-05-30 19:33           ` Richard Weinberger
2015-05-30 19:37           ` Joachim Eastwood
2015-05-30 19:37             ` Joachim Eastwood
2015-05-30 19:37             ` Joachim Eastwood
2015-05-30 19:37             ` Ezequiel Garcia [this message]
2015-05-30 19:37               ` Ezequiel Garcia
2015-05-30 19:37               ` Ezequiel Garcia
2015-05-29 17:50 ` [PATCH 2/2] doc: dt: add documentation for nxp,lpc1773-spifi Joachim Eastwood
2015-05-29 17:50   ` Joachim Eastwood
2015-05-29 17:50   ` Joachim Eastwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556A1162.7060400@vanguardiasur.com.ar \
    --to=ezequiel@vanguardiasur.com.ar \
    --cc=ariel.dalessandro@gmail.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=manabian@gmail.com \
    --cc=richard@nod.at \
    --cc=shijie.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.