* [lm-sensors] [PATCH 1/2] hwmon: (nct6775) Add missing sysfs attibute initialization
@ 2015-05-28 16:15 Guenter Roeck
2015-05-29 8:49 ` Jean Delvare
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Guenter Roeck @ 2015-05-28 16:15 UTC (permalink / raw)
To: lm-sensors
The following error message is seen when loading the nct6775 driver
with DEBUG_LOCK_ALLOC enabled.
BUG: key ffff88040b2f0030 not in .data!
------------[ cut here ]------------
WARNING: CPU: 0 PID: 186 at kernel/locking/lockdep.c:2988
lockdep_init_map+0x469/0x630()
DEBUG_LOCKS_WARN_ON(1)
Caused by a missing call to sysfs_attr_init() when initializing
sysfs attributes.
Reported-by: Alexey Orishko <alexey.orishko@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/hwmon/nct6775.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c
index 4fcb48103299..bd1c99deac71 100644
--- a/drivers/hwmon/nct6775.c
+++ b/drivers/hwmon/nct6775.c
@@ -995,6 +995,7 @@ nct6775_create_attr_group(struct device *dev, struct sensor_template_group *tg,
(*t)->dev_attr.attr.name, tg->base + i);
if ((*t)->s2) {
a2 = &su->u.a2;
+ sysfs_attr_init(&a2->dev_attr.attr);
a2->dev_attr.attr.name = su->name;
a2->nr = (*t)->u.s.nr + i;
a2->index = (*t)->u.s.index;
@@ -1005,6 +1006,7 @@ nct6775_create_attr_group(struct device *dev, struct sensor_template_group *tg,
*attrs = &a2->dev_attr.attr;
} else {
a = &su->u.a1;
+ sysfs_attr_init(&a->dev_attr.attr);
a->dev_attr.attr.name = su->name;
a->index = (*t)->u.index + i;
a->dev_attr.attr.mode --
2.1.0
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH 1/2] hwmon: (nct6775) Add missing sysfs attibute initialization
2015-05-28 16:15 [lm-sensors] [PATCH 1/2] hwmon: (nct6775) Add missing sysfs attibute initialization Guenter Roeck
@ 2015-05-29 8:49 ` Jean Delvare
2015-05-31 22:25 ` Alexey Orishko
2015-05-31 22:40 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2015-05-29 8:49 UTC (permalink / raw)
To: lm-sensors
On Thu, 28 May 2015 09:15:55 -0700, Guenter Roeck wrote:
> The following error message is seen when loading the nct6775 driver
> with DEBUG_LOCK_ALLOC enabled.
>
> BUG: key ffff88040b2f0030 not in .data!
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 186 at kernel/locking/lockdep.c:2988
> lockdep_init_map+0x469/0x630()
> DEBUG_LOCKS_WARN_ON(1)
>
> Caused by a missing call to sysfs_attr_init() when initializing
> sysfs attributes.
>
> Reported-by: Alexey Orishko <alexey.orishko@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/hwmon/nct6775.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c
> index 4fcb48103299..bd1c99deac71 100644
> --- a/drivers/hwmon/nct6775.c
> +++ b/drivers/hwmon/nct6775.c
> @@ -995,6 +995,7 @@ nct6775_create_attr_group(struct device *dev, struct sensor_template_group *tg,
> (*t)->dev_attr.attr.name, tg->base + i);
> if ((*t)->s2) {
> a2 = &su->u.a2;
> + sysfs_attr_init(&a2->dev_attr.attr);
> a2->dev_attr.attr.name = su->name;
> a2->nr = (*t)->u.s.nr + i;
> a2->index = (*t)->u.s.index;
> @@ -1005,6 +1006,7 @@ nct6775_create_attr_group(struct device *dev, struct sensor_template_group *tg,
> *attrs = &a2->dev_attr.attr;
> } else {
> a = &su->u.a1;
> + sysfs_attr_init(&a->dev_attr.attr);
> a->dev_attr.attr.name = su->name;
> a->index = (*t)->u.index + i;
> a->dev_attr.attr.mode
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH 1/2] hwmon: (nct6775) Add missing sysfs attibute initialization
2015-05-28 16:15 [lm-sensors] [PATCH 1/2] hwmon: (nct6775) Add missing sysfs attibute initialization Guenter Roeck
2015-05-29 8:49 ` Jean Delvare
@ 2015-05-31 22:25 ` Alexey Orishko
2015-05-31 22:40 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Alexey Orishko @ 2015-05-31 22:25 UTC (permalink / raw)
To: lm-sensors
On Fri, May 29, 2015 at 10:49 AM, Jean Delvare <jdelvare@suse.de> wrote:
> On Thu, 28 May 2015 09:15:55 -0700, Guenter Roeck wrote:
>> The following error message is seen when loading the nct6775 driver
>> with DEBUG_LOCK_ALLOC enabled.
>>
>> BUG: key ffff88040b2f0030 not in .data!
>> ------------[ cut here ]------------
>> WARNING: CPU: 0 PID: 186 at kernel/locking/lockdep.c:2988
>> lockdep_init_map+0x469/0x630()
>> DEBUG_LOCKS_WARN_ON(1)
>>
>> Caused by a missing call to sysfs_attr_init() when initializing
>> sysfs attributes.
>>
>> Reported-by: Alexey Orishko <alexey.orishko@gmail.com>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> drivers/hwmon/nct6775.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c
>> index 4fcb48103299..bd1c99deac71 100644
>> --- a/drivers/hwmon/nct6775.c
>> +++ b/drivers/hwmon/nct6775.c
>> @@ -995,6 +995,7 @@ nct6775_create_attr_group(struct device *dev, struct sensor_template_group *tg,
>> (*t)->dev_attr.attr.name, tg->base + i);
>> if ((*t)->s2) {
>> a2 = &su->u.a2;
>> + sysfs_attr_init(&a2->dev_attr.attr);
>> a2->dev_attr.attr.name = su->name;
>> a2->nr = (*t)->u.s.nr + i;
>> a2->index = (*t)->u.s.index;
>> @@ -1005,6 +1006,7 @@ nct6775_create_attr_group(struct device *dev, struct sensor_template_group *tg,
>> *attrs = &a2->dev_attr.attr;
>> } else {
>> a = &su->u.a1;
>> + sysfs_attr_init(&a->dev_attr.attr);
>> a->dev_attr.attr.name = su->name;
>> a->index = (*t)->u.index + i;
>> a->dev_attr.attr.mode >
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
Tested on ASRock E3C222D4U motherboard with kernel 4.0.3; reported
problem is fixed.
Tested-by: Alexey Orishko <alexey.orishko@gmail.com>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH 1/2] hwmon: (nct6775) Add missing sysfs attibute initialization
2015-05-28 16:15 [lm-sensors] [PATCH 1/2] hwmon: (nct6775) Add missing sysfs attibute initialization Guenter Roeck
2015-05-29 8:49 ` Jean Delvare
2015-05-31 22:25 ` Alexey Orishko
@ 2015-05-31 22:40 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2015-05-31 22:40 UTC (permalink / raw)
To: lm-sensors
On 05/31/2015 03:25 PM, Alexey Orishko wrote:
> On Fri, May 29, 2015 at 10:49 AM, Jean Delvare <jdelvare@suse.de> wrote:
>> On Thu, 28 May 2015 09:15:55 -0700, Guenter Roeck wrote:
>>> The following error message is seen when loading the nct6775 driver
>>> with DEBUG_LOCK_ALLOC enabled.
>>>
>>> BUG: key ffff88040b2f0030 not in .data!
>>> ------------[ cut here ]------------
>>> WARNING: CPU: 0 PID: 186 at kernel/locking/lockdep.c:2988
>>> lockdep_init_map+0x469/0x630()
>>> DEBUG_LOCKS_WARN_ON(1)
>>>
>>> Caused by a missing call to sysfs_attr_init() when initializing
>>> sysfs attributes.
>>>
>>> Reported-by: Alexey Orishko <alexey.orishko@gmail.com>
>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
[ ... ]
>>
>> Reviewed-by: Jean Delvare <jdelvare@suse.de>
>
> Tested on ASRock E3C222D4U motherboard with kernel 4.0.3; reported
> problem is fixed.
> Tested-by: Alexey Orishko <alexey.orishko@gmail.com>
>
Hi Alexey,
Great, thanks a lot for testing!
The fix is already available in mainline, and should eventually find its way into 4.0.x.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-31 22:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-28 16:15 [lm-sensors] [PATCH 1/2] hwmon: (nct6775) Add missing sysfs attibute initialization Guenter Roeck
2015-05-29 8:49 ` Jean Delvare
2015-05-31 22:25 ` Alexey Orishko
2015-05-31 22:40 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.