All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, mst@redhat.com
Cc: jsnow@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH] hw/q35: fix floppy controller definition in ich9
Date: Mon, 01 Jun 2015 18:06:24 +0300	[thread overview]
Message-ID: <556C74F0.7040605@redhat.com> (raw)
In-Reply-To: <938219099.12500567.1433170675854.JavaMail.zimbra@redhat.com>

On 06/01/2015 05:57 PM, Paolo Bonzini wrote:
>> On 06/01/2015 05:45 PM, Paolo Bonzini wrote:
>>> The patch is okay, but the correct definition of the area is from 0x3F1
>>> to 0x3F7.
>> Can we do other fixes on top of this? This patch solves the actual Windows
>> problem and now we can use floppies for Q35.
>
> Well, IANAM. :)
>
>> Can I take this okay as a "Reviewed-by"? )
>
> Sure.
Thanks Paolo!

Michael, maybe you can take this patch under pci/Q35 branch?
Thanks,
Marcel

>
> Paolo
>

      reply	other threads:[~2015-06-01 15:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01 14:09 [Qemu-devel] [PATCH] hw/q35: fix floppy controller definition in ich9 Marcel Apfelbaum
2015-06-01 14:13 ` Marcel Apfelbaum
2015-06-01 14:45   ` Paolo Bonzini
2015-06-01 14:54     ` Marcel Apfelbaum
2015-06-01 14:57       ` Paolo Bonzini
2015-06-01 15:06         ` Marcel Apfelbaum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556C74F0.7040605@redhat.com \
    --to=marcel@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.