All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] translate-all: delete prototype for non-existent function
Date: Tue, 02 Jun 2015 08:38:10 +0300	[thread overview]
Message-ID: <556D4142.3000506@msgid.tls.msk.ru> (raw)
In-Reply-To: <1433145235-13941-1-git-send-email-pbonzini@redhat.com>

01.06.2015 10:53, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  translate-all.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/translate-all.h b/translate-all.h
> index ef9166c..0384640 100644
> --- a/translate-all.h
> +++ b/translate-all.h
> @@ -24,7 +24,6 @@ void tb_invalidate_phys_page_fast(tb_page_addr_t start, int len);
>  void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end,
>                                     int is_cpu_write_access);
>  void tb_invalidate_phys_range(tb_page_addr_t start, tb_page_addr_t end);
> -void cpu_unlink_tb(CPUState *cpu);
>  void tb_check_watchpoint(CPUState *cpu);
>  
>  #ifdef CONFIG_USER_ONLY

Hmm.  This does not apply due to context, my version of translate-all.h
is very short, without tb_invalidate_phys_page_range prototype and
without ifdef CONFIG_USER_ONLY, and after this prototype removal it
contains just 3 prototypes.

I reduced this to just the one-line removal and applied, and git pull
should do the right thing too.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] translate-all: delete prototype for non-existent function
Date: Tue, 02 Jun 2015 08:38:10 +0300	[thread overview]
Message-ID: <556D4142.3000506@msgid.tls.msk.ru> (raw)
In-Reply-To: <1433145235-13941-1-git-send-email-pbonzini@redhat.com>

01.06.2015 10:53, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  translate-all.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/translate-all.h b/translate-all.h
> index ef9166c..0384640 100644
> --- a/translate-all.h
> +++ b/translate-all.h
> @@ -24,7 +24,6 @@ void tb_invalidate_phys_page_fast(tb_page_addr_t start, int len);
>  void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end,
>                                     int is_cpu_write_access);
>  void tb_invalidate_phys_range(tb_page_addr_t start, tb_page_addr_t end);
> -void cpu_unlink_tb(CPUState *cpu);
>  void tb_check_watchpoint(CPUState *cpu);
>  
>  #ifdef CONFIG_USER_ONLY

Hmm.  This does not apply due to context, my version of translate-all.h
is very short, without tb_invalidate_phys_page_range prototype and
without ifdef CONFIG_USER_ONLY, and after this prototype removal it
contains just 3 prototypes.

I reduced this to just the one-line removal and applied, and git pull
should do the right thing too.

Thanks,

/mjt

  parent reply	other threads:[~2015-06-02  5:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01  7:53 [Qemu-trivial] [PATCH] translate-all: delete prototype for non-existent function Paolo Bonzini
2015-06-01  7:53 ` [Qemu-devel] " Paolo Bonzini
2015-06-01 17:01 ` [Qemu-trivial] " Eric Blake
2015-06-01 17:01   ` Eric Blake
2015-06-01 18:38 ` [Qemu-trivial] " Peter Crosthwaite
2015-06-01 18:38   ` Peter Crosthwaite
2015-06-02  5:38 ` Michael Tokarev [this message]
2015-06-02  5:38   ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556D4142.3000506@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.