All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-trivial@nongnu.org, Jeff Cody <jcody@redhat.com>,
	qemu-block@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] sheepdog: Fix error message if failed to load vmstate
Date: Tue, 02 Jun 2015 13:16:06 +0300	[thread overview]
Message-ID: <556D8266.8060004@msgid.tls.msk.ru> (raw)
In-Reply-To: <1433237561-10846-1-git-send-email-famz@redhat.com>

02.06.2015 12:32, Fam Zheng wrote:
>          if (ret < 0) {
> -            error_report("failed to save vmstate %s", strerror(errno));
> +            if (load) {
> +                error_report("failed to load vmstate %s", strerror(errno));
> +            } else {
> +                error_report("failed to save vmstate %s", strerror(errno));
> +            }

 +            error_report("failed to %s vmstate: %s", load ? "load" : "save", strerror(errno));

(note also the addition of ":")
(besides what Kevin said).

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-trivial@nongnu.org, Jeff Cody <jcody@redhat.com>,
	qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] sheepdog: Fix error message if failed to load vmstate
Date: Tue, 02 Jun 2015 13:16:06 +0300	[thread overview]
Message-ID: <556D8266.8060004@msgid.tls.msk.ru> (raw)
In-Reply-To: <1433237561-10846-1-git-send-email-famz@redhat.com>

02.06.2015 12:32, Fam Zheng wrote:
>          if (ret < 0) {
> -            error_report("failed to save vmstate %s", strerror(errno));
> +            if (load) {
> +                error_report("failed to load vmstate %s", strerror(errno));
> +            } else {
> +                error_report("failed to save vmstate %s", strerror(errno));
> +            }

 +            error_report("failed to %s vmstate: %s", load ? "load" : "save", strerror(errno));

(note also the addition of ":")
(besides what Kevin said).

Thanks,

/mjt

  parent reply	other threads:[~2015-06-02 10:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-02  9:32 [Qemu-trivial] [PATCH] sheepdog: Fix error message if failed to load vmstate Fam Zheng
2015-06-02  9:32 ` [Qemu-devel] " Fam Zheng
2015-06-02  9:45 ` [Qemu-trivial] " Kevin Wolf
2015-06-02  9:45   ` [Qemu-devel] " Kevin Wolf
2015-06-02 10:22   ` [Qemu-trivial] " Fam Zheng
2015-06-02 10:22     ` [Qemu-devel] " Fam Zheng
2015-06-02 10:16 ` Michael Tokarev [this message]
2015-06-02 10:16   ` Michael Tokarev
2015-06-02 10:26   ` [Qemu-trivial] " Fam Zheng
2015-06-02 10:26     ` [Qemu-devel] " Fam Zheng
2015-06-02 19:16     ` [Qemu-trivial] [Qemu-block] " John Snow
2015-06-02 19:16       ` [Qemu-devel] " John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556D8266.8060004@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.