From: John Snow <jsnow@redhat.com>
To: Eric Blake <eblake@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Add .dir-locals.el file to configure emacs coding style
Date: Tue, 02 Jun 2015 15:08:18 -0400 [thread overview]
Message-ID: <556DFF22.70600@redhat.com> (raw)
In-Reply-To: <556DD392.3040703@redhat.com>
On 06/02/2015 12:02 PM, Eric Blake wrote:
> On 06/02/2015 09:26 AM, Daniel P. Berrange wrote:
>> The default emacs setup indents by 2 spaces and uses tabs
>> which is counter to the QEMU coding style rules. Adding a
>> .dir-locals.el file in the top level of the GIT repo will
>> inform emacs about the QEMU coding style, and so assist
>> contributors in avoiding common style mistakes before
>> they submit patches.
>>
>> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
>> ---
>> .dir-locals.el | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>> create mode 100644 .dir-locals.el
>
> Since we already have .exrc to do the same for vim users, I'm all in
> favor of this.
>
+1
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
Reviewed-by: John Snow <jsnow@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: John Snow <jsnow@redhat.com>
To: Eric Blake <eblake@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add .dir-locals.el file to configure emacs coding style
Date: Tue, 02 Jun 2015 15:08:18 -0400 [thread overview]
Message-ID: <556DFF22.70600@redhat.com> (raw)
In-Reply-To: <556DD392.3040703@redhat.com>
On 06/02/2015 12:02 PM, Eric Blake wrote:
> On 06/02/2015 09:26 AM, Daniel P. Berrange wrote:
>> The default emacs setup indents by 2 spaces and uses tabs
>> which is counter to the QEMU coding style rules. Adding a
>> .dir-locals.el file in the top level of the GIT repo will
>> inform emacs about the QEMU coding style, and so assist
>> contributors in avoiding common style mistakes before
>> they submit patches.
>>
>> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
>> ---
>> .dir-locals.el | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>> create mode 100644 .dir-locals.el
>
> Since we already have .exrc to do the same for vim users, I'm all in
> favor of this.
>
+1
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2015-06-02 19:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 15:26 [Qemu-trivial] [PATCH] Add .dir-locals.el file to configure emacs coding style Daniel P. Berrange
2015-06-02 15:26 ` [Qemu-devel] " Daniel P. Berrange
2015-06-02 16:02 ` [Qemu-trivial] " Eric Blake
2015-06-02 16:02 ` Eric Blake
2015-06-02 19:08 ` John Snow [this message]
2015-06-02 19:08 ` John Snow
2015-06-03 7:47 ` [Qemu-trivial] " Markus Armbruster
2015-06-03 7:47 ` Markus Armbruster
2015-06-04 13:30 ` [Qemu-trivial] " Daniel P. Berrange
2015-06-04 13:30 ` Daniel P. Berrange
2015-06-04 17:45 ` [Qemu-trivial] " Don Slutz
2015-06-04 17:45 ` [Qemu-devel] [Qemu-trivial] " Don Slutz
2015-06-04 17:46 ` [Qemu-trivial] [Qemu-devel] " Don Slutz
2015-06-04 17:46 ` [Qemu-devel] [Qemu-trivial] " Don Slutz
2015-06-17 19:42 ` Michael Tokarev
2015-06-17 19:42 ` [Qemu-devel] " Michael Tokarev
2015-06-18 8:36 ` [Qemu-trivial] " Markus Armbruster
2015-06-18 8:36 ` Markus Armbruster
2015-06-18 9:05 ` [Qemu-trivial] " Michael Tokarev
2015-06-18 9:05 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556DFF22.70600@redhat.com \
--to=jsnow@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.