* [Qemu-trivial] [PATCH] configure: postfix --extra-cflags to QEMU_CFLAGS
@ 2015-06-03 8:56 ` Alex Bennée
0 siblings, 0 replies; 6+ messages in thread
From: Alex Bennée @ 2015-06-03 8:56 UTC (permalink / raw)
To: qemu-trivial; +Cc: Alex Bennée, qemu-devel
It makes sense that extra-cflags should be appended after the normal
CFLAGS so they don't get overridden by default behaviour. This way if
you specify something like:
./configure --extra-cflags="-O0"
You will see the requested behaviour.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index b707429..f13831a 100755
--- a/configure
+++ b/configure
@@ -353,7 +353,7 @@ for opt do
;;
--cpu=*) cpu="$optarg"
;;
- --extra-cflags=*) QEMU_CFLAGS="$optarg $QEMU_CFLAGS"
+ --extra-cflags=*) QEMU_CFLAGS="$QEMU_CFLAGS $optarg"
EXTRA_CFLAGS="$optarg"
;;
--extra-ldflags=*) LDFLAGS="$optarg $LDFLAGS"
--
2.4.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH] configure: postfix --extra-cflags to QEMU_CFLAGS
@ 2015-06-03 8:56 ` Alex Bennée
0 siblings, 0 replies; 6+ messages in thread
From: Alex Bennée @ 2015-06-03 8:56 UTC (permalink / raw)
To: qemu-trivial; +Cc: Alex Bennée, qemu-devel
It makes sense that extra-cflags should be appended after the normal
CFLAGS so they don't get overridden by default behaviour. This way if
you specify something like:
./configure --extra-cflags="-O0"
You will see the requested behaviour.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index b707429..f13831a 100755
--- a/configure
+++ b/configure
@@ -353,7 +353,7 @@ for opt do
;;
--cpu=*) cpu="$optarg"
;;
- --extra-cflags=*) QEMU_CFLAGS="$optarg $QEMU_CFLAGS"
+ --extra-cflags=*) QEMU_CFLAGS="$QEMU_CFLAGS $optarg"
EXTRA_CFLAGS="$optarg"
;;
--extra-ldflags=*) LDFLAGS="$optarg $LDFLAGS"
--
2.4.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [PATCH] configure: postfix --extra-cflags to QEMU_CFLAGS
2015-06-03 8:56 ` [Qemu-devel] " Alex Bennée
@ 2015-06-03 13:05 ` Michael Tokarev
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-06-03 13:05 UTC (permalink / raw)
To: Alex Bennée, qemu-trivial; +Cc: qemu-devel
Applied to -trivial, thanks!
The other nearby case, --extra-ldflags, also wants this reordering :)
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: postfix --extra-cflags to QEMU_CFLAGS
@ 2015-06-03 13:05 ` Michael Tokarev
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-06-03 13:05 UTC (permalink / raw)
To: Alex Bennée, qemu-trivial; +Cc: qemu-devel
Applied to -trivial, thanks!
The other nearby case, --extra-ldflags, also wants this reordering :)
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] configure: postfix --extra-cflags to QEMU_CFLAGS
2015-06-03 13:05 ` [Qemu-devel] " Michael Tokarev
@ 2015-06-03 13:23 ` Alex Bennée
-1 siblings, 0 replies; 6+ messages in thread
From: Alex Bennée @ 2015-06-03 13:23 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, qemu-devel
Michael Tokarev <mjt@tls.msk.ru> writes:
> Applied to -trivial, thanks!
>
> The other nearby case, --extra-ldflags, also wants this reordering :)
sent
One day I'll find a use for such a thing but fortunately my default build
environment has everything I need ;-)
>
> /mjt
--
Alex Bennée
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-06-03 13:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-03 8:56 [Qemu-trivial] [PATCH] configure: postfix --extra-cflags to QEMU_CFLAGS Alex Bennée
2015-06-03 8:56 ` [Qemu-devel] " Alex Bennée
2015-06-03 13:05 ` [Qemu-trivial] " Michael Tokarev
2015-06-03 13:05 ` [Qemu-devel] " Michael Tokarev
2015-06-03 13:23 ` [Qemu-trivial] " Alex Bennée
2015-06-03 13:23 ` [Qemu-devel] " Alex Bennée
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.