Re: [Qemu-devel] [PATCH v3 01/38] block: Remove host floppy support

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2276 bytes --]

On 06/03/2015 01:43 PM, Max Reitz wrote:
> It has been deprecated as of 2.3, so we can now remove it.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  block/raw-posix.c    | 228 ++-------------------------------------------------
>  qapi/block-core.json |   9 +-
>  2 files changed, 11 insertions(+), 226 deletions(-)

Dropping is not backwards-compatible, but that was the whole point of
deprecating it to make it obvious that we planned to do it.

Reviewed-by: Eric Blake <eblake@redhat.com>


> @@ -2283,14 +2221,13 @@ static int hdev_create(const char *filename, QemuOpts *opts,
>      int64_t total_size = 0;
>      bool has_prefix;
>  
> -    /* This function is used by all three protocol block drivers and therefore
> -     * any of these three prefixes may be given.
> +    /* This function is used by both protocol block drivers and therefore either
> +     * of these prefixes may be given.
>       * The return value has to be stored somewhere, otherwise this is an error
>       * due to -Werror=unused-value. */
>      has_prefix =
>          strstart(filename, "host_device:", &filename) ||
> -        strstart(filename, "host_cdrom:" , &filename) ||
> -        strstart(filename, "host_floppy:", &filename);
> +        strstart(filename, "host_cdrom:" , &filename);

Libvirt does not refer to 'host_floppy' anywhere, so that is also
reassuring about dropping this ancient and seldom-used feature.

> +++ b/qapi/block-core.json
> @@ -215,10 +215,11 @@
>  # @drv: the name of the block format used to open the backing device. As of
>  #       0.14.0 this can be: 'blkdebug', 'bochs', 'cloop', 'cow', 'dmg',
>  #       'file', 'file', 'ftp', 'ftps', 'host_cdrom', 'host_device',
> -#       'host_floppy', 'http', 'https', 'nbd', 'parallels', 'qcow',
> +#       'http', 'https', 'nbd', 'parallels', 'qcow',
>  #       'qcow2', 'raw', 'tftp', 'vdi', 'vmdk', 'vpc', 'vvfat'
>  #       2.2: 'archipelago' added, 'cow' dropped
>  #       2.3: 'host_floppy' deprecated
> +#       2.4: 'host_floppy' dropped

Also nice to know this is not the first time we've dropped something
that is now worthless.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]