Re: [Qemu-devel] [PATCH v3 26/38] blockdev: Add blockdev-open-tray

[Max Reitz <mreitz@redhat.com>]

On 03.06.2015 23:24, Eric Blake wrote:
> On 06/03/2015 01:44 PM, Max Reitz wrote:
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>> ---
>>   blockdev.c           | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
>>   qapi/block-core.json | 23 +++++++++++++++++++++++
>>   qmp-commands.hx      | 39 +++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 110 insertions(+)
>>
>> +++ b/qapi/block-core.json
>> @@ -1836,6 +1836,29 @@
>>   ##
>>   { 'command': 'blockdev-add', 'data': { 'options': 'BlockdevOptions' } }
>>   
>> +##
>> +# @blockdev-open-tray:
>> +#
>> +# Opens a block device's tray. If there is a block driver state tree inserted as
>> +# a medium, it will become inaccessible to the guest (but it will remain
>> +# associated to the block device, so closing the tray will make it accessible
>> +# again).
>> +#
>> +# If the tray was already open before, this will be a no-op.
>> +#
>> +# @device: block device name
>> +#
>> +# @force:  #optional if false (the default), an eject request will be sent to
>> +#          the guest if it has locked the tray (and the tray will not be opened
>> +#          immediately); if true, the tray will be opened regardless of whether
>> +#          it is locked
>> +#
>> +# Since: 2.3
> s/2.3/2.4/ - you'll probably have to make the change throughout the
> series (so I won't point it out further)

Oops, right. Thanks.

Max