From: Stephen Warren <swarren@wwwdotorg.org>
To: Eric Anholt <eric@anholt.net>, Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mmc: sdhci-bcm2835: Actually enable the clock
Date: Thu, 04 Jun 2015 20:59:51 -0600 [thread overview]
Message-ID: <557110A7.8070705@wwwdotorg.org> (raw)
In-Reply-To: <1432933572-8695-2-git-send-email-eric@anholt.net>
On 05/29/2015 03:06 PM, Eric Anholt wrote:
> We're currently using a fixed frequency clock specified in the DT, so
> enabling is a no-op. However, the RPi firmware-based clocks driver
> can actually disable unused clocks, so when switching to use it we
> ended up losing our MMC clock once all devices were probed.
> diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c
> + ret = clk_prepare_enable(pltfm_host->clk);
> + if (ret) {
> + dev_err(&pdev->dev, "failed to enable host clk\n");
> + goto err;
> + }
Given that pltfm_host is a "struct sdhci_pltfm_host" i.e. a type
defined/handled by sdhci-pltfm.c , I'm rather surprised that
sdhci-pltfm.c doesn't do this itself. Wouldn't it make sense for it to
do so?
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] mmc: sdhci-bcm2835: Actually enable the clock
Date: Thu, 04 Jun 2015 20:59:51 -0600 [thread overview]
Message-ID: <557110A7.8070705@wwwdotorg.org> (raw)
In-Reply-To: <1432933572-8695-2-git-send-email-eric@anholt.net>
On 05/29/2015 03:06 PM, Eric Anholt wrote:
> We're currently using a fixed frequency clock specified in the DT, so
> enabling is a no-op. However, the RPi firmware-based clocks driver
> can actually disable unused clocks, so when switching to use it we
> ended up losing our MMC clock once all devices were probed.
> diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c
> + ret = clk_prepare_enable(pltfm_host->clk);
> + if (ret) {
> + dev_err(&pdev->dev, "failed to enable host clk\n");
> + goto err;
> + }
Given that pltfm_host is a "struct sdhci_pltfm_host" i.e. a type
defined/handled by sdhci-pltfm.c , I'm rather surprised that
sdhci-pltfm.c doesn't do this itself. Wouldn't it make sense for it to
do so?
next prev parent reply other threads:[~2015-06-05 2:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 21:06 [PATCH v2 1/2] mmc: sdhci-bcm2835: Clean up platform allocations if sdhci init fails Eric Anholt
2015-05-29 21:06 ` Eric Anholt
2015-05-29 21:06 ` [PATCH v2 2/2] mmc: sdhci-bcm2835: Actually enable the clock Eric Anholt
2015-05-29 21:06 ` Eric Anholt
2015-06-01 8:05 ` Ulf Hansson
2015-06-01 8:05 ` Ulf Hansson
2015-06-05 2:59 ` Stephen Warren [this message]
2015-06-05 2:59 ` Stephen Warren
2015-06-05 8:48 ` Ulf Hansson
2015-06-05 8:48 ` Ulf Hansson
2015-06-01 8:05 ` [PATCH v2 1/2] mmc: sdhci-bcm2835: Clean up platform allocations if sdhci init fails Ulf Hansson
2015-06-01 8:05 ` Ulf Hansson
2015-06-01 8:05 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557110A7.8070705@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=eric@anholt.net \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.