All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH wpan-tools] treewide: replace wireless with wpan
@ 2015-06-05 11:43 Alexander Aring
  2015-06-05 11:56 ` Varka Bhadram
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Aring @ 2015-06-05 11:43 UTC (permalink / raw)
  To: linux-wpan; +Cc: Alexander Aring

This patch replaced several wireless string with wpan. This behaviour
was simpled copied from wireless iw tool and it hasn't been renamed to
wpan.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
 src/info.c      | 4 ++--
 src/interface.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/info.c b/src/info.c
index 2434bef..8afeeb7 100644
--- a/src/info.c
+++ b/src/info.c
@@ -459,7 +459,7 @@ static int handle_info(struct nl802154_state *state,
 }
 
 __COMMAND(NULL, info, "info", NULL, NL802154_CMD_GET_WPAN_PHY, 0, 0, CIB_PHY, handle_info,
-	  "Show capabilities for the specified wireless device.", NULL);
+	  "Show capabilities for the specified wpan device.", NULL);
 TOPLEVEL(list, NULL, NL802154_CMD_GET_WPAN_PHY, NLM_F_DUMP, CIB_NONE, handle_info,
-	 "List all wireless devices and their capabilities.");
+	 "List all wpan devices and their capabilities.");
 TOPLEVEL(phy, NULL, NL802154_CMD_GET_WPAN_PHY, NLM_F_DUMP, CIB_NONE, handle_info, NULL);
diff --git a/src/interface.c b/src/interface.c
index 647247b..c67077b 100644
--- a/src/interface.c
+++ b/src/interface.c
@@ -252,4 +252,4 @@ static int handle_dev_dump(struct nl802154_state *state,
 	return 0;
 }
 TOPLEVEL(dev, NULL, NL802154_CMD_GET_INTERFACE, NLM_F_DUMP, CIB_NONE, handle_dev_dump,
-	 "List all network interfaces for wireless hardware.");
+	 "List all network interfaces for wpan hardware.");
-- 
2.4.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH wpan-tools] treewide: replace wireless with wpan
  2015-06-05 11:43 [PATCH wpan-tools] treewide: replace wireless with wpan Alexander Aring
@ 2015-06-05 11:56 ` Varka Bhadram
  2015-06-05 12:19   ` Alexander Aring
  0 siblings, 1 reply; 3+ messages in thread
From: Varka Bhadram @ 2015-06-05 11:56 UTC (permalink / raw)
  To: Alexander Aring, linux-wpan

Hi,

On 06/05/2015 05:13 PM, Alexander Aring wrote:

> This patch replaced several wireless string with wpan. This behaviour
> was simpled copied from wireless iw tool and it hasn't been renamed to
> wpan.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
>   src/info.c      | 4 ++--
>   src/interface.c | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/info.c b/src/info.c
> index 2434bef..8afeeb7 100644
> --- a/src/info.c
> +++ b/src/info.c
> @@ -459,7 +459,7 @@ static int handle_info(struct nl802154_state *state,
>   }
>   
>   __COMMAND(NULL, info, "info", NULL, NL802154_CMD_GET_WPAN_PHY, 0, 0, CIB_PHY, handle_info,
> -	  "Show capabilities for the specified wireless device.", NULL);
> +	  "Show capabilities for the specified wpan device.", NULL);
>   TOPLEVEL(list, NULL, NL802154_CMD_GET_WPAN_PHY, NLM_F_DUMP, CIB_NONE, handle_info,
> -	 "List all wireless devices and their capabilities.");
> +	 "List all wpan devices and their capabilities.");
>   TOPLEVEL(phy, NULL, NL802154_CMD_GET_WPAN_PHY, NLM_F_DUMP, CIB_NONE, handle_info, NULL);
> diff --git a/src/interface.c b/src/interface.c
> index 647247b..c67077b 100644
> --- a/src/interface.c
> +++ b/src/interface.c
> @@ -252,4 +252,4 @@ static int handle_dev_dump(struct nl802154_state *state,
>   	return 0;
>   }
>   TOPLEVEL(dev, NULL, NL802154_CMD_GET_INTERFACE, NLM_F_DUMP, CIB_NONE, handle_dev_dump,
> -	 "List all network interfaces for wireless hardware.");
> +	 "List all network interfaces for wpan hardware.");

We also have some typo in usage:

root@beaglebone:~# iwpan help
Usage:	iwpan [options] command
Options:
	--debug		enable netlink debugging
	--version	show version (0.4)
Commands:
	phy <phyname> set channel <page> <channel>
	phy <phyname> set tx_power <dBm>
	phy <phyname> set cca_mode <mode|3 <1|0>>
	phy <phyname> set cca_ed_level <level>
	dev <devname> set pan_id <pan_id>
	dev <devname> set short_addr <short_addr>
	dev <devname> set max_frame_retries <retries>
	dev <devname> set backoff_exponents <min_be> <max_be>
	dev <devname> set max_csma_backoffs <backoffs>
	dev <devname> set lbt <1|0>
...
Commands that use the netdev ('dev') can also be given the
'wdev' instead to identify the device.
...

Here it should be *wpan_dev*. And *iwpan* is not supporting
this command.

I used some thing like this:

root@beaglebone:~# iwpan wdev wpan0 info
Usage:	iwpan [options] command
Options:
	--debug		enable netlink debugging
	--version	show version (0.4)
Commands:
	phy <phyname> set channel <page> <channel>
	phy <phyname> set tx_power <dBm>
	phy <phyname> set cca_mode <mode|3 <1|0>>
	phy <phyname> set cca_ed_level <level>
...

Thanks.

-- 
Varka Bhadram


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH wpan-tools] treewide: replace wireless with wpan
  2015-06-05 11:56 ` Varka Bhadram
@ 2015-06-05 12:19   ` Alexander Aring
  0 siblings, 0 replies; 3+ messages in thread
From: Alexander Aring @ 2015-06-05 12:19 UTC (permalink / raw)
  To: Varka Bhadram; +Cc: linux-wpan

On Fri, Jun 05, 2015 at 05:26:46PM +0530, Varka Bhadram wrote:
> Hi,
> 
> On 06/05/2015 05:13 PM, Alexander Aring wrote:
> 
> >This patch replaced several wireless string with wpan. This behaviour
> >was simpled copied from wireless iw tool and it hasn't been renamed to
> >wpan.
> >
> >Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> >---
> >  src/info.c      | 4 ++--
> >  src/interface.c | 2 +-
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> >
> >diff --git a/src/info.c b/src/info.c
> >index 2434bef..8afeeb7 100644
> >--- a/src/info.c
> >+++ b/src/info.c
> >@@ -459,7 +459,7 @@ static int handle_info(struct nl802154_state *state,
> >  }
> >  __COMMAND(NULL, info, "info", NULL, NL802154_CMD_GET_WPAN_PHY, 0, 0, CIB_PHY, handle_info,
> >-	  "Show capabilities for the specified wireless device.", NULL);
> >+	  "Show capabilities for the specified wpan device.", NULL);
> >  TOPLEVEL(list, NULL, NL802154_CMD_GET_WPAN_PHY, NLM_F_DUMP, CIB_NONE, handle_info,
> >-	 "List all wireless devices and their capabilities.");
> >+	 "List all wpan devices and their capabilities.");
> >  TOPLEVEL(phy, NULL, NL802154_CMD_GET_WPAN_PHY, NLM_F_DUMP, CIB_NONE, handle_info, NULL);
> >diff --git a/src/interface.c b/src/interface.c
> >index 647247b..c67077b 100644
> >--- a/src/interface.c
> >+++ b/src/interface.c
> >@@ -252,4 +252,4 @@ static int handle_dev_dump(struct nl802154_state *state,
> >  	return 0;
> >  }
> >  TOPLEVEL(dev, NULL, NL802154_CMD_GET_INTERFACE, NLM_F_DUMP, CIB_NONE, handle_dev_dump,
> >-	 "List all network interfaces for wireless hardware.");
> >+	 "List all network interfaces for wpan hardware.");
> 
> We also have some typo in usage:
> 

send patches. :-)

- Alex

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-06-05 12:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-05 11:43 [PATCH wpan-tools] treewide: replace wireless with wpan Alexander Aring
2015-06-05 11:56 ` Varka Bhadram
2015-06-05 12:19   ` Alexander Aring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.