From: "Andreas Färber" <afaerber@suse.de>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 3/4] cpus: Change tcg_cpu_exec arg to cpu, not env
Date: Fri, 05 Jun 2015 23:48:01 +0900 [thread overview]
Message-ID: <5571B6A1.2010809@suse.de> (raw)
In-Reply-To: <6c2b2815082aaab8580d79cc529150d46c417eaf.1432534114.git.crosthwaite.peter@gmail.com>
Am 25.05.2015 um 15:22 schrieb Peter Crosthwaite:
> The sole caller of this function navigates the cpu->env_ptr only for
> this function to take it back the cpu pointer straight away. Pass in
> cpu pointer instead and grab the env pointer locally in the function.
> Removes a core code usage of ENV_GET_CPU.
Please follow the convention of writing "foo()" for any function or
parameterized macro, here and elsewhere.
>
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> ---
> cpus.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Andreas Färber <afaerber@suse.de>
Thanks,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-06-05 14:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 6:22 [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals Peter Crosthwaite
2015-05-25 6:22 ` [Qemu-devel] [PATCH 1/4] translate-all: Change tb_flush env argument to cpu Peter Crosthwaite
2015-05-25 20:27 ` Eduardo Habkost
2015-06-05 14:43 ` Andreas Färber
2015-05-25 6:22 ` [Qemu-devel] [PATCH 2/4] gdbserver: _fork: Change fn to accept cpu instead of env Peter Crosthwaite
2015-06-05 14:44 ` Andreas Färber
2015-05-25 6:22 ` [Qemu-devel] [PATCH 3/4] cpus: Change tcg_cpu_exec arg to cpu, not env Peter Crosthwaite
2015-06-05 14:48 ` Andreas Färber [this message]
2015-05-25 6:22 ` [Qemu-devel] [PATCH 4/4] cpus: Change exec_init " Peter Crosthwaite
2015-05-25 20:54 ` Eduardo Habkost
2015-06-05 14:51 ` Andreas Färber
2015-06-05 15:05 ` Eduardo Habkost
2015-06-24 12:48 ` Andreas Färber
2015-06-24 12:49 ` Paolo Bonzini
2015-05-25 13:08 ` [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals Paolo Bonzini
2015-05-26 6:00 ` Peter Crosthwaite
2015-05-26 8:05 ` Paolo Bonzini
2015-05-29 5:28 ` Peter Crosthwaite
2015-05-26 6:10 ` Andreas Färber
2015-05-26 8:05 ` Paolo Bonzini
2015-05-26 8:20 ` Andreas Färber
2015-05-26 8:25 ` Paolo Bonzini
2015-05-26 8:31 ` Andreas Färber
2015-05-26 8:33 ` Alexander Graf
2015-05-26 11:49 ` Paolo Bonzini
2015-05-29 18:34 ` Eduardo Habkost
2015-06-04 1:10 ` Peter Crosthwaite
2015-06-04 7:58 ` Paolo Bonzini
2015-06-23 13:00 ` Andreas Färber
2015-06-24 4:22 ` Peter Crosthwaite
2015-06-24 9:50 ` Paolo Bonzini
2015-07-11 11:45 ` Peter Crosthwaite
2015-05-26 8:36 ` Paolo Bonzini
2015-05-26 8:56 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5571B6A1.2010809@suse.de \
--to=afaerber@suse.de \
--cc=crosthwaite.peter@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.