From: "Andreas Färber" <afaerber@suse.de>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Jia Liu <proljc@gmail.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Anthony Green <green@moxielogic.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
Blue Swirl <blauwirbel@gmail.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Peter Crosthwaite <crosthwaitepeter@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Michael Walle <michael@walle.cc>,
Bharata B Rao <bharata@linux.vnet.ibm.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Leon Alrae <leon.alrae@imgtec.com>,
Aurelien Jarno <aurelien@aurel32.net>,
rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 4/4] cpus: Change exec_init arg to cpu, not env
Date: Wed, 24 Jun 2015 14:48:20 +0200 [thread overview]
Message-ID: <558AA714.9060600@suse.de> (raw)
In-Reply-To: <20150605150535.GJ3410@thinpad.lan.raisama.net>
Am 05.06.2015 um 17:05 schrieb Eduardo Habkost:
> On Fri, Jun 05, 2015 at 11:51:41PM +0900, Andreas Färber wrote:
>> Am 25.05.2015 um 15:22 schrieb Peter Crosthwaite:
>>> The callers (most of them in target-foo/cpu.c) to this function all
>>> have the cpu pointer handy. Just pass it to avoid an ENV_GET_CPU from
>>> core code (in exec.c).
> [...]
>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>>
>> I assume this will conflict with another patch adding an Error**
>> argument - Eduardo, please help coordinating this.
>
> I asked Peter to rebase on top of Bharata's "Bitmap based CPU
> enumeration" series (that's already on v3 and got some Reviewed-by
> lines), but both Peter and Bharata need to know which tree those series
> are expected to be included.
I was expecting you to handle cpu_exec_init() through your x86 tree, but
seems that didn't happen. I am going through CPU patches today, so could
take open series but then would need to pick up the ENV_* stuff too,
which I thought would go through Paolo in my absence...
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-06-24 12:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 6:22 [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals Peter Crosthwaite
2015-05-25 6:22 ` [Qemu-devel] [PATCH 1/4] translate-all: Change tb_flush env argument to cpu Peter Crosthwaite
2015-05-25 20:27 ` Eduardo Habkost
2015-06-05 14:43 ` Andreas Färber
2015-05-25 6:22 ` [Qemu-devel] [PATCH 2/4] gdbserver: _fork: Change fn to accept cpu instead of env Peter Crosthwaite
2015-06-05 14:44 ` Andreas Färber
2015-05-25 6:22 ` [Qemu-devel] [PATCH 3/4] cpus: Change tcg_cpu_exec arg to cpu, not env Peter Crosthwaite
2015-06-05 14:48 ` Andreas Färber
2015-05-25 6:22 ` [Qemu-devel] [PATCH 4/4] cpus: Change exec_init " Peter Crosthwaite
2015-05-25 20:54 ` Eduardo Habkost
2015-06-05 14:51 ` Andreas Färber
2015-06-05 15:05 ` Eduardo Habkost
2015-06-24 12:48 ` Andreas Färber [this message]
2015-06-24 12:49 ` Paolo Bonzini
2015-05-25 13:08 ` [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals Paolo Bonzini
2015-05-26 6:00 ` Peter Crosthwaite
2015-05-26 8:05 ` Paolo Bonzini
2015-05-29 5:28 ` Peter Crosthwaite
2015-05-26 6:10 ` Andreas Färber
2015-05-26 8:05 ` Paolo Bonzini
2015-05-26 8:20 ` Andreas Färber
2015-05-26 8:25 ` Paolo Bonzini
2015-05-26 8:31 ` Andreas Färber
2015-05-26 8:33 ` Alexander Graf
2015-05-26 11:49 ` Paolo Bonzini
2015-05-29 18:34 ` Eduardo Habkost
2015-06-04 1:10 ` Peter Crosthwaite
2015-06-04 7:58 ` Paolo Bonzini
2015-06-23 13:00 ` Andreas Färber
2015-06-24 4:22 ` Peter Crosthwaite
2015-06-24 9:50 ` Paolo Bonzini
2015-07-11 11:45 ` Peter Crosthwaite
2015-05-26 8:36 ` Paolo Bonzini
2015-05-26 8:56 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558AA714.9060600@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=bharata@linux.vnet.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=green@moxielogic.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=jcmvbkbc@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=leon.alrae@imgtec.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.