* Re: [PATCH] sctp: Simplify and make the function sctp_assoc_lookup_laddr bool [not found] <1433526062-2364-1-git-send-email-xerofoify@gmail.com> @ 2015-06-05 19:16 ` Neil Horman 0 siblings, 0 replies; 6+ messages in thread From: Neil Horman @ 2015-06-05 19:16 UTC (permalink / raw) To: Nicholas Krause; +Cc: vyasevich, davem, linux-sctp, netdev, linux-kernel On Fri, Jun 05, 2015 at 01:41:02PM -0400, Nicholas Krause wrote: > This makes the function sctp_assoc_lookup_laddr bool due to it > only returning either one or zero as its return value. Further > more this function can we simplified to return the if statement > as part of this function directly and thus remove the no longer > required if statement due to this function now being declared > as bool. > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com> Acked-by: Neil Horman <nhorman@tuxdriver.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sctp: Simplify and make the function sctp_assoc_lookup_laddr bool @ 2015-06-05 19:16 ` Neil Horman 0 siblings, 0 replies; 6+ messages in thread From: Neil Horman @ 2015-06-05 19:16 UTC (permalink / raw) To: Nicholas Krause; +Cc: vyasevich, davem, linux-sctp, netdev, linux-kernel On Fri, Jun 05, 2015 at 01:41:02PM -0400, Nicholas Krause wrote: > This makes the function sctp_assoc_lookup_laddr bool due to it > only returning either one or zero as its return value. Further > more this function can we simplified to return the if statement > as part of this function directly and thus remove the no longer > required if statement due to this function now being declared > as bool. > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com> Acked-by: Neil Horman <nhorman@tuxdriver.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sctp: Simplify and make the function sctp_assoc_lookup_laddr bool 2015-06-05 19:16 ` Neil Horman @ 2015-06-05 21:56 ` Andrej Manduch -1 siblings, 0 replies; 6+ messages in thread From: Andrej Manduch @ 2015-06-05 21:56 UTC (permalink / raw) To: Neil Horman, Nicholas Krause Cc: vyasevich, davem, linux-sctp, netdev, linux-kernel Hi Neil, I would like to kindly ask you to always put full patch in reply when you are replying to Nicks patch. Because he's banned from vger and only people on cc are able to see his patches and this is only way for rest of us to see what is in his patch. Thanks. On 06/05/2015 03:16 PM, Neil Horman wrote: >> This makes the function sctp_assoc_lookup_laddr bool due to it >> only returning either one or zero as its return value. Further >> more this function can we simplified to return the if statement >> as part of this function directly and thus remove the no longer >> required if statement due to this function now being declared >> as bool. >> >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com> -- Kind regards, b. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sctp: Simplify and make the function sctp_assoc_lookup_laddr bool @ 2015-06-05 21:56 ` Andrej Manduch 0 siblings, 0 replies; 6+ messages in thread From: Andrej Manduch @ 2015-06-05 21:56 UTC (permalink / raw) To: Neil Horman, Nicholas Krause Cc: vyasevich, davem, linux-sctp, netdev, linux-kernel Hi Neil, I would like to kindly ask you to always put full patch in reply when you are replying to Nicks patch. Because he's banned from vger and only people on cc are able to see his patches and this is only way for rest of us to see what is in his patch. Thanks. On 06/05/2015 03:16 PM, Neil Horman wrote: >> This makes the function sctp_assoc_lookup_laddr bool due to it >> only returning either one or zero as its return value. Further >> more this function can we simplified to return the if statement >> as part of this function directly and thus remove the no longer >> required if statement due to this function now being declared >> as bool. >> >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com> -- Kind regards, b. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sctp: Simplify and make the function sctp_assoc_lookup_laddr bool 2015-06-05 21:56 ` Andrej Manduch @ 2015-06-06 12:55 ` Neil Horman -1 siblings, 0 replies; 6+ messages in thread From: Neil Horman @ 2015-06-06 12:55 UTC (permalink / raw) To: Andrej Manduch Cc: Nicholas Krause, vyasevich, davem, linux-sctp, netdev, linux-kernel On Fri, Jun 05, 2015 at 05:56:33PM -0400, Andrej Manduch wrote: > Hi Neil, > > I would like to kindly ask you to always put full patch in reply when > you are replying to Nicks patch. Because he's banned from vger and only > people on cc are able to see his patches and this is only way for rest > of us to see what is in his patch. > > Thanks. Sure, though that begs the question, why is he banned from vger? Is it his gmail address, or something more directed? Neil > > On 06/05/2015 03:16 PM, Neil Horman wrote: > >> This makes the function sctp_assoc_lookup_laddr bool due to it > >> only returning either one or zero as its return value. Further > >> more this function can we simplified to return the if statement > >> as part of this function directly and thus remove the no longer > >> required if statement due to this function now being declared > >> as bool. > >> > >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com> > > -- > Kind regards, > b. > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sctp: Simplify and make the function sctp_assoc_lookup_laddr bool @ 2015-06-06 12:55 ` Neil Horman 0 siblings, 0 replies; 6+ messages in thread From: Neil Horman @ 2015-06-06 12:55 UTC (permalink / raw) To: Andrej Manduch Cc: Nicholas Krause, vyasevich, davem, linux-sctp, netdev, linux-kernel On Fri, Jun 05, 2015 at 05:56:33PM -0400, Andrej Manduch wrote: > Hi Neil, > > I would like to kindly ask you to always put full patch in reply when > you are replying to Nicks patch. Because he's banned from vger and only > people on cc are able to see his patches and this is only way for rest > of us to see what is in his patch. > > Thanks. Sure, though that begs the question, why is he banned from vger? Is it his gmail address, or something more directed? Neil > > On 06/05/2015 03:16 PM, Neil Horman wrote: > >> This makes the function sctp_assoc_lookup_laddr bool due to it > >> only returning either one or zero as its return value. Further > >> more this function can we simplified to return the if statement > >> as part of this function directly and thus remove the no longer > >> required if statement due to this function now being declared > >> as bool. > >> > >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com> > > -- > Kind regards, > b. > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-06-06 12:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1433526062-2364-1-git-send-email-xerofoify@gmail.com>
2015-06-05 19:16 ` [PATCH] sctp: Simplify and make the function sctp_assoc_lookup_laddr bool Neil Horman
2015-06-05 19:16 ` Neil Horman
2015-06-05 21:56 ` Andrej Manduch
2015-06-05 21:56 ` Andrej Manduch
2015-06-06 12:55 ` Neil Horman
2015-06-06 12:55 ` Neil Horman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.