All of lore.kernel.org
 help / color / mirror / Atom feed
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] ARM: dts; pxa: add embedded pxa camera capture interface
Date: Sun, 07 Jun 2015 01:07:01 +0300	[thread overview]
Message-ID: <55736F05.8000904@cogentembedded.com> (raw)
In-Reply-To: <1433624953-28165-4-git-send-email-robert.jarzmik@free.fr>

Hello.

On 06/07/2015 12:09 AM, Robert Jarzmik wrote:

> The pxa27x SoCs have an embedded camera host controller. Add the
> description to the family description.

> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
>   arch/arm/boot/dts/pxa27x.dtsi | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)

> diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi
> index 506db86..9ebfd7f 100644
> --- a/arch/arm/boot/dts/pxa27x.dtsi
> +++ b/arch/arm/boot/dts/pxa27x.dtsi
> @@ -77,6 +77,23 @@
>   			clocks = <&clks CLK_KEYPAD>;
>   			status = "disabled";
>   		};
> +
> +		pxa_camera: pxa_camera at 50000000 {

    The ePAPR standard has something to say about the node naming:
"The name of a node should be somewhat generic, reflecting the function of the 
device and not its precise programming model." So I'd suggest "video at 50000000" 
instead...

[...]

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/6] ARM: dts; pxa: add embedded pxa camera capture interface
Date: Sun, 07 Jun 2015 01:07:01 +0300	[thread overview]
Message-ID: <55736F05.8000904@cogentembedded.com> (raw)
In-Reply-To: <1433624953-28165-4-git-send-email-robert.jarzmik@free.fr>

Hello.

On 06/07/2015 12:09 AM, Robert Jarzmik wrote:

> The pxa27x SoCs have an embedded camera host controller. Add the
> description to the family description.

> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
>   arch/arm/boot/dts/pxa27x.dtsi | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)

> diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi
> index 506db86..9ebfd7f 100644
> --- a/arch/arm/boot/dts/pxa27x.dtsi
> +++ b/arch/arm/boot/dts/pxa27x.dtsi
> @@ -77,6 +77,23 @@
>   			clocks = <&clks CLK_KEYPAD>;
>   			status = "disabled";
>   		};
> +
> +		pxa_camera: pxa_camera@50000000 {

    The ePAPR standard has something to say about the node naming:
"The name of a node should be somewhat generic, reflecting the function of the 
device and not its precise programming model." So I'd suggest "video@50000000" 
instead...

[...]

WBR, Sergei

  reply	other threads:[~2015-06-06 22:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-06 21:09 [PATCH 1/6] ARM: dts: pxa: add dma controller Robert Jarzmik
2015-06-06 21:09 ` Robert Jarzmik
2015-06-06 21:09 ` [PATCH 2/6] ARM: dts: pxa: add dma engine node to pxa3xx-nand Robert Jarzmik
2015-06-06 21:09   ` Robert Jarzmik
2015-06-06 21:09   ` Robert Jarzmik
2015-06-06 21:09 ` [PATCH 3/6] ARM: dts: pxa: add dma pxamci nodes to pxa3xx Robert Jarzmik
2015-06-06 21:09   ` Robert Jarzmik
2015-06-06 21:09   ` Robert Jarzmik
2015-06-06 21:09 ` [PATCH 4/6] ARM: dts; pxa: add embedded pxa camera capture interface Robert Jarzmik
2015-06-06 21:09   ` Robert Jarzmik
2015-06-06 21:09   ` Robert Jarzmik
2015-06-06 22:07   ` Sergei Shtylyov [this message]
2015-06-06 22:07     ` Sergei Shtylyov
2015-06-08 17:23     ` Robert Jarzmik
2015-06-08 17:23       ` Robert Jarzmik
2015-06-08 17:23       ` Robert Jarzmik
2015-06-06 21:09 ` [PATCH 5/6] ARM: dts: pxa: fix power i2c definition Robert Jarzmik
2015-06-06 21:09   ` Robert Jarzmik
2015-06-06 21:09 ` [PATCH 6/6] ARM: dts: pxa: add the usb host controller Robert Jarzmik
2015-06-06 21:09   ` Robert Jarzmik
2015-06-06 21:09   ` Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55736F05.8000904@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.