[PATCH 1/2] docker: cgroup-lite is not required with systemd

[PATCH 1/2] docker: cgroup-lite is not required with systemd

[Mark Asselstine]

Systemd takes care of setting up the various cgroup mounts at boot,
and likewise the tearing down of these at shutdown. It is therefor a
useless dependency when we are using systemd.

Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
---
 recipes-containers/docker/docker_git.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/recipes-containers/docker/docker_git.bb b/recipes-containers/docker/docker_git.bb
index f3c940d..4f85193 100644
--- a/recipes-containers/docker/docker_git.bb
+++ b/recipes-containers/docker/docker_git.bb
@@ -53,7 +53,9 @@ DEPENDS = "go-cross \
     "
 
 DEPENDS_append_class-target = "lvm2"
-RDEPENDS_${PN} = "curl aufs-util git cgroup-lite util-linux iptables"
+RDEPENDS_${PN} = "curl aufs-util git util-linux iptables \
+                  ${@bb.utils.contains('DISTRO_FEATURES','systemd','','cgroup-lite',d)} \
+                 "
 RDEPENDS_${PN} += "containerd runc"
 RRECOMMENDS_${PN} = "lxc docker-registry rt-tests"
 RRECOMMENDS_${PN} += " kernel-module-dm-thin-pool kernel-module-nf-nat"
-- 
2.1.4

[PATCH 2/2] docker: update license md5sum

[Mark Asselstine]

Seems upstream adjusted their LICENSE file. The license is still
Apache version 2 so no worries about having to update the LICENSE
string for the recipe.

Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
---
 recipes-containers/docker/docker_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-containers/docker/docker_git.bb b/recipes-containers/docker/docker_git.bb
index 4f85193..4be5e47 100644
--- a/recipes-containers/docker/docker_git.bb
+++ b/recipes-containers/docker/docker_git.bb
@@ -28,7 +28,7 @@ SRC_URI = "\
 
 # Apache-2.0 for docker
 LICENSE = "Apache-2.0"
-LIC_FILES_CHKSUM = "file://LICENSE;md5=cc2221abf0b96ea39dd68141b70f7937"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=aadc30f9c14d876ded7bedc0afd2d3d7"
 
 S = "${WORKDIR}/git"
 
-- 
2.1.4

Re: [PATCH 2/2] docker: update license md5sum

[Bruce Ashfield]

On 2016-08-31 2:19 PM, Mark Asselstine wrote:
> Seems upstream adjusted their LICENSE file. The license is still
> Apache version 2 so no worries about having to update the LICENSE
> string for the recipe.

docker is a git hash, so there's no way this could actually happen.
Not to mention, I just did a clean build (cleanall -> build) and the
existing license checksum is fine.

Something strange is happening in your setup and we need to sort out
what it is.

Bruce

>
> Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
> ---
>  recipes-containers/docker/docker_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-containers/docker/docker_git.bb b/recipes-containers/docker/docker_git.bb
> index 4f85193..4be5e47 100644
> --- a/recipes-containers/docker/docker_git.bb
> +++ b/recipes-containers/docker/docker_git.bb
> @@ -28,7 +28,7 @@ SRC_URI = "\
>
>  # Apache-2.0 for docker
>  LICENSE = "Apache-2.0"
> -LIC_FILES_CHKSUM = "file://LICENSE;md5=cc2221abf0b96ea39dd68141b70f7937"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=aadc30f9c14d876ded7bedc0afd2d3d7"
>
>  S = "${WORKDIR}/git"
>
>

Re: [PATCH 2/2] docker: update license md5sum

[Bruce Ashfield]

On 2016-08-31 2:19 PM, Mark Asselstine wrote:
> Seems upstream adjusted their LICENSE file. The license is still
> Apache version 2 so no worries about having to update the LICENSE
> string for the recipe.

Or is this using a common LIC file which changed ? My oe-core is
about two weeks out of date.

Bruce

>
> Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
> ---
>  recipes-containers/docker/docker_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-containers/docker/docker_git.bb b/recipes-containers/docker/docker_git.bb
> index 4f85193..4be5e47 100644
> --- a/recipes-containers/docker/docker_git.bb
> +++ b/recipes-containers/docker/docker_git.bb
> @@ -28,7 +28,7 @@ SRC_URI = "\
>
>  # Apache-2.0 for docker
>  LICENSE = "Apache-2.0"
> -LIC_FILES_CHKSUM = "file://LICENSE;md5=cc2221abf0b96ea39dd68141b70f7937"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=aadc30f9c14d876ded7bedc0afd2d3d7"
>
>  S = "${WORKDIR}/git"
>
>

Re: [PATCH 2/2] docker: update license md5sum

[Mark Asselstine]

On August 31, 2016 16:56:38 Bruce Ashfield wrote:
> On 2016-08-31 2:19 PM, Mark Asselstine wrote:
> > Seems upstream adjusted their LICENSE file. The license is still
> > Apache version 2 so no worries about having to update the LICENSE
> > string for the recipe.
> 
> Or is this using a common LIC file which changed ? My oe-core is
> about two weeks out of date.

Has nothing to do with the SRC_URI, it is a changed md5sum on the fetched 
content, in this case the file named LICENSE.

You are not seeing the issue because I am guessing you are building with meta-
overc, which we restrict the ERROR_QA and thus don't include 'license-
checksum'. Add 'license-checksum' to ERROR_QA in local.conf or meta-
overc/conf/distro/overc.conf and you will see this.

Mark

> 
> Bruce
> 
> > Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
> > ---
> > 
> >  recipes-containers/docker/docker_git.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/recipes-containers/docker/docker_git.bb
> > b/recipes-containers/docker/docker_git.bb index 4f85193..4be5e47 100644
> > --- a/recipes-containers/docker/docker_git.bb
> > +++ b/recipes-containers/docker/docker_git.bb
> > @@ -28,7 +28,7 @@ SRC_URI = "\
> > 
> >  # Apache-2.0 for docker
> >  LICENSE = "Apache-2.0"
> > 
> > -LIC_FILES_CHKSUM = "file://LICENSE;md5=cc2221abf0b96ea39dd68141b70f7937"
> > +LIC_FILES_CHKSUM = "file://LICENSE;md5=aadc30f9c14d876ded7bedc0afd2d3d7"
> > 
> >  S = "${WORKDIR}/git"

Re: [PATCH 2/2] docker: update license md5sum

[Mark Asselstine]

On August 31, 2016 17:09:45 Mark Asselstine wrote:
> On August 31, 2016 16:56:38 Bruce Ashfield wrote:
> > On 2016-08-31 2:19 PM, Mark Asselstine wrote:
> > > Seems upstream adjusted their LICENSE file. The license is still
> > > Apache version 2 so no worries about having to update the LICENSE
> > > string for the recipe.
> > 
> > Or is this using a common LIC file which changed ? My oe-core is
> > about two weeks out of date.
> 
> Has nothing to do with the SRC_URI, it is a changed md5sum on the fetched
> content, in this case the file named LICENSE.

OH, I see why you tied it back to the git hash. That just means that this 
mismatch has existed since that hash was changed. Again, just masked by the 
manipulation of ERROR_QA.

Mark

> 
> You are not seeing the issue because I am guessing you are building with
> meta- overc, which we restrict the ERROR_QA and thus don't include
> 'license- checksum'. Add 'license-checksum' to ERROR_QA in local.conf or
> meta- overc/conf/distro/overc.conf and you will see this.
> 
> Mark
> 
> > Bruce
> > 
> > > Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
> > > ---
> > > 
> > >  recipes-containers/docker/docker_git.bb | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/recipes-containers/docker/docker_git.bb
> > > b/recipes-containers/docker/docker_git.bb index 4f85193..4be5e47 100644
> > > --- a/recipes-containers/docker/docker_git.bb
> > > +++ b/recipes-containers/docker/docker_git.bb
> > > @@ -28,7 +28,7 @@ SRC_URI = "\
> > > 
> > >  # Apache-2.0 for docker
> > >  LICENSE = "Apache-2.0"
> > > 
> > > -LIC_FILES_CHKSUM =
> > > "file://LICENSE;md5=cc2221abf0b96ea39dd68141b70f7937"
> > > +LIC_FILES_CHKSUM =
> > > "file://LICENSE;md5=aadc30f9c14d876ded7bedc0afd2d3d7"
> > > 
> > >  S = "${WORKDIR}/git"

Re: [PATCH 2/2] docker: update license md5sum

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 2451 bytes --]

On Wed, Aug 31, 2016 at 5:11 PM, Mark Asselstine <
mark.asselstine@windriver.com> wrote:

> On August 31, 2016 17:09:45 Mark Asselstine wrote:
> > On August 31, 2016 16:56:38 Bruce Ashfield wrote:
> > > On 2016-08-31 2:19 PM, Mark Asselstine wrote:
> > > > Seems upstream adjusted their LICENSE file. The license is still
> > > > Apache version 2 so no worries about having to update the LICENSE
> > > > string for the recipe.
> > >
> > > Or is this using a common LIC file which changed ? My oe-core is
> > > about two weeks out of date.
> >
> > Has nothing to do with the SRC_URI, it is a changed md5sum on the fetched
> > content, in this case the file named LICENSE.
>
> OH, I see why you tied it back to the git hash. That just means that this
> mismatch has existed since that hash was changed. Again, just masked by the
> manipulation of ERROR_QA.
>

Nope. Shouldn't be that.

I just did a cleanall and re-build. The checksum matches.

Bruce


>
> Mark
>
> >
> > You are not seeing the issue because I am guessing you are building with
> > meta- overc, which we restrict the ERROR_QA and thus don't include
> > 'license- checksum'. Add 'license-checksum' to ERROR_QA in local.conf or
> > meta- overc/conf/distro/overc.conf and you will see this.
> >
> > Mark
> >
> > > Bruce
> > >
> > > > Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
> > > > ---
> > > >
> > > >  recipes-containers/docker/docker_git.bb | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/recipes-containers/docker/docker_git.bb
> > > > b/recipes-containers/docker/docker_git.bb index 4f85193..4be5e47
> 100644
> > > > --- a/recipes-containers/docker/docker_git.bb
> > > > +++ b/recipes-containers/docker/docker_git.bb
> > > > @@ -28,7 +28,7 @@ SRC_URI = "\
> > > >
> > > >  # Apache-2.0 for docker
> > > >  LICENSE = "Apache-2.0"
> > > >
> > > > -LIC_FILES_CHKSUM =
> > > > "file://LICENSE;md5=cc2221abf0b96ea39dd68141b70f7937"
> > > > +LIC_FILES_CHKSUM =
> > > > "file://LICENSE;md5=aadc30f9c14d876ded7bedc0afd2d3d7"
> > > >
> > > >  S = "${WORKDIR}/git"
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 4281 bytes --]

Re: [PATCH 2/2] docker: update license md5sum

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 2849 bytes --]

On Wed, Aug 31, 2016 at 5:13 PM, Bruce Ashfield <bruce.ashfield@gmail.com>
wrote:

>
>
> On Wed, Aug 31, 2016 at 5:11 PM, Mark Asselstine <
> mark.asselstine@windriver.com> wrote:
>
>> On August 31, 2016 17:09:45 Mark Asselstine wrote:
>> > On August 31, 2016 16:56:38 Bruce Ashfield wrote:
>> > > On 2016-08-31 2:19 PM, Mark Asselstine wrote:
>> > > > Seems upstream adjusted their LICENSE file. The license is still
>> > > > Apache version 2 so no worries about having to update the LICENSE
>> > > > string for the recipe.
>> > >
>> > > Or is this using a common LIC file which changed ? My oe-core is
>> > > about two weeks out of date.
>> >
>> > Has nothing to do with the SRC_URI, it is a changed md5sum on the
>> fetched
>> > content, in this case the file named LICENSE.
>>
>> OH, I see why you tied it back to the git hash. That just means that this
>> mismatch has existed since that hash was changed. Again, just masked by
>> the
>> manipulation of ERROR_QA.
>>
>
> Nope. Shouldn't be that.
>
> I just did a cleanall and re-build. The checksum matches.
>

... and I just realized that cleanall doesn't get sstate, so I'd better
remove that as well!

Bruce


>
> Bruce
>
>
>>
>> Mark
>>
>> >
>> > You are not seeing the issue because I am guessing you are building with
>> > meta- overc, which we restrict the ERROR_QA and thus don't include
>> > 'license- checksum'. Add 'license-checksum' to ERROR_QA in local.conf or
>> > meta- overc/conf/distro/overc.conf and you will see this.
>> >
>> > Mark
>> >
>> > > Bruce
>> > >
>> > > > Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
>> > > > ---
>> > > >
>> > > >  recipes-containers/docker/docker_git.bb | 2 +-
>> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
>> > > >
>> > > > diff --git a/recipes-containers/docker/docker_git.bb
>> > > > b/recipes-containers/docker/docker_git.bb index 4f85193..4be5e47
>> 100644
>> > > > --- a/recipes-containers/docker/docker_git.bb
>> > > > +++ b/recipes-containers/docker/docker_git.bb
>> > > > @@ -28,7 +28,7 @@ SRC_URI = "\
>> > > >
>> > > >  # Apache-2.0 for docker
>> > > >  LICENSE = "Apache-2.0"
>> > > >
>> > > > -LIC_FILES_CHKSUM =
>> > > > "file://LICENSE;md5=cc2221abf0b96ea39dd68141b70f7937"
>> > > > +LIC_FILES_CHKSUM =
>> > > > "file://LICENSE;md5=aadc30f9c14d876ded7bedc0afd2d3d7"
>> > > >
>> > > >  S = "${WORKDIR}/git"
>>
>> --
>> _______________________________________________
>> meta-virtualization mailing list
>> meta-virtualization@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-virtualization
>>
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end"
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 5300 bytes --]

Re: [PATCH 2/2] docker: update license md5sum

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 3374 bytes --]

On Wed, Aug 31, 2016 at 5:17 PM, Bruce Ashfield <bruce.ashfield@gmail.com>
wrote:

>
>
> On Wed, Aug 31, 2016 at 5:13 PM, Bruce Ashfield <bruce.ashfield@gmail.com>
> wrote:
>
>>
>>
>> On Wed, Aug 31, 2016 at 5:11 PM, Mark Asselstine <
>> mark.asselstine@windriver.com> wrote:
>>
>>> On August 31, 2016 17:09:45 Mark Asselstine wrote:
>>> > On August 31, 2016 16:56:38 Bruce Ashfield wrote:
>>> > > On 2016-08-31 2:19 PM, Mark Asselstine wrote:
>>> > > > Seems upstream adjusted their LICENSE file. The license is still
>>> > > > Apache version 2 so no worries about having to update the LICENSE
>>> > > > string for the recipe.
>>> > >
>>> > > Or is this using a common LIC file which changed ? My oe-core is
>>> > > about two weeks out of date.
>>> >
>>> > Has nothing to do with the SRC_URI, it is a changed md5sum on the
>>> fetched
>>> > content, in this case the file named LICENSE.
>>>
>>> OH, I see why you tied it back to the git hash. That just means that this
>>> mismatch has existed since that hash was changed. Again, just masked by
>>> the
>>> manipulation of ERROR_QA.
>>>
>>
>> Nope. Shouldn't be that.
>>
>> I just did a cleanall and re-build. The checksum matches.
>>
>
> ... and I just realized that cleanall doesn't get sstate, so I'd better
> remove that as well!
>

Sure enough, it was sstate that was the difference, skipped tasks on my
recent build.

I'm seeing this now.   So I'll apply this as-is.

Shows how many people are tracking meta-virt master :D

Bruce


>
> Bruce
>
>
>>
>> Bruce
>>
>>
>>>
>>> Mark
>>>
>>> >
>>> > You are not seeing the issue because I am guessing you are building
>>> with
>>> > meta- overc, which we restrict the ERROR_QA and thus don't include
>>> > 'license- checksum'. Add 'license-checksum' to ERROR_QA in local.conf
>>> or
>>> > meta- overc/conf/distro/overc.conf and you will see this.
>>> >
>>> > Mark
>>> >
>>> > > Bruce
>>> > >
>>> > > > Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
>>> > > > ---
>>> > > >
>>> > > >  recipes-containers/docker/docker_git.bb | 2 +-
>>> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
>>> > > >
>>> > > > diff --git a/recipes-containers/docker/docker_git.bb
>>> > > > b/recipes-containers/docker/docker_git.bb index 4f85193..4be5e47
>>> 100644
>>> > > > --- a/recipes-containers/docker/docker_git.bb
>>> > > > +++ b/recipes-containers/docker/docker_git.bb
>>> > > > @@ -28,7 +28,7 @@ SRC_URI = "\
>>> > > >
>>> > > >  # Apache-2.0 for docker
>>> > > >  LICENSE = "Apache-2.0"
>>> > > >
>>> > > > -LIC_FILES_CHKSUM =
>>> > > > "file://LICENSE;md5=cc2221abf0b96ea39dd68141b70f7937"
>>> > > > +LIC_FILES_CHKSUM =
>>> > > > "file://LICENSE;md5=aadc30f9c14d876ded7bedc0afd2d3d7"
>>> > > >
>>> > > >  S = "${WORKDIR}/git"
>>>
>>> --
>>> _______________________________________________
>>> meta-virtualization mailing list
>>> meta-virtualization@yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/meta-virtualization
>>>
>>
>>
>>
>> --
>> "Thou shalt not follow the NULL pointer, for chaos and madness await thee
>> at its end"
>>
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end"
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 6493 bytes --]

Re: [PATCH 2/2] docker: update license md5sum

[Mark Asselstine]

On August 31, 2016 17:27:34 Bruce Ashfield wrote:
> On Wed, Aug 31, 2016 at 5:17 PM, Bruce Ashfield <bruce.ashfield@gmail.com>
> 
> wrote:
> > On Wed, Aug 31, 2016 at 5:13 PM, Bruce Ashfield <bruce.ashfield@gmail.com>
> > 
> > wrote:
> >> On Wed, Aug 31, 2016 at 5:11 PM, Mark Asselstine <
> >> 
> >> mark.asselstine@windriver.com> wrote:
> >>> On August 31, 2016 17:09:45 Mark Asselstine wrote:
> >>> > On August 31, 2016 16:56:38 Bruce Ashfield wrote:
> >>> > > On 2016-08-31 2:19 PM, Mark Asselstine wrote:
> >>> > > > Seems upstream adjusted their LICENSE file. The license is still
> >>> > > > Apache version 2 so no worries about having to update the LICENSE
> >>> > > > string for the recipe.
> >>> > > 
> >>> > > Or is this using a common LIC file which changed ? My oe-core is
> >>> > > about two weeks out of date.
> >>> > 
> >>> > Has nothing to do with the SRC_URI, it is a changed md5sum on the
> >>> 
> >>> fetched
> >>> 
> >>> > content, in this case the file named LICENSE.
> >>> 
> >>> OH, I see why you tied it back to the git hash. That just means that
> >>> this
> >>> mismatch has existed since that hash was changed. Again, just masked by
> >>> the
> >>> manipulation of ERROR_QA.
> >> 
> >> Nope. Shouldn't be that.
> >> 
> >> I just did a cleanall and re-build. The checksum matches.
> > 
> > ... and I just realized that cleanall doesn't get sstate, so I'd better
> > remove that as well!
> 
> Sure enough, it was sstate that was the difference, skipped tasks on my
> recent build.
> 
> I'm seeing this now.   So I'll apply this as-is.
> 
> Shows how many people are tracking meta-virt master :D

and building docker.

Glad you were able to see it, had me scratching my head earlier today as well 
since it wasn't touched in so long and my meta-overc build was not seeing it.

Mark

> 
> Bruce
> 
> > Bruce
> > 
> >> Bruce
> >> 
> >>> Mark
> >>> 
> >>> > You are not seeing the issue because I am guessing you are building
> >>> 
> >>> with
> >>> 
> >>> > meta- overc, which we restrict the ERROR_QA and thus don't include
> >>> > 'license- checksum'. Add 'license-checksum' to ERROR_QA in local.conf
> >>> 
> >>> or
> >>> 
> >>> > meta- overc/conf/distro/overc.conf and you will see this.
> >>> > 
> >>> > Mark
> >>> > 
> >>> > > Bruce
> >>> > > 
> >>> > > > Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
> >>> > > > ---
> >>> > > > 
> >>> > > >  recipes-containers/docker/docker_git.bb | 2 +-
> >>> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >>> > > > 
> >>> > > > diff --git a/recipes-containers/docker/docker_git.bb
> >>> > > > b/recipes-containers/docker/docker_git.bb index 4f85193..4be5e47
> >>> 
> >>> 100644
> >>> 
> >>> > > > --- a/recipes-containers/docker/docker_git.bb
> >>> > > > +++ b/recipes-containers/docker/docker_git.bb
> >>> > > > @@ -28,7 +28,7 @@ SRC_URI = "\
> >>> > > > 
> >>> > > >  # Apache-2.0 for docker
> >>> > > >  LICENSE = "Apache-2.0"
> >>> > > > 
> >>> > > > -LIC_FILES_CHKSUM =
> >>> > > > "file://LICENSE;md5=cc2221abf0b96ea39dd68141b70f7937"
> >>> > > > +LIC_FILES_CHKSUM =
> >>> > > > "file://LICENSE;md5=aadc30f9c14d876ded7bedc0afd2d3d7"
> >>> > > > 
> >>> > > >  S = "${WORKDIR}/git"
> >>> 
> >>> --
> >>> _______________________________________________
> >>> meta-virtualization mailing list
> >>> meta-virtualization@yoctoproject.org
> >>> https://lists.yoctoproject.org/listinfo/meta-virtualization
> >> 
> >> --
> >> "Thou shalt not follow the NULL pointer, for chaos and madness await thee
> >> at its end"
> > 
> > --
> > "Thou shalt not follow the NULL pointer, for chaos and madness await thee
> > at its end"

Re: [PATCH 2/2] docker: update license md5sum

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 4297 bytes --]

On Wed, Aug 31, 2016 at 5:30 PM, Mark Asselstine <
mark.asselstine@windriver.com> wrote:

> On August 31, 2016 17:27:34 Bruce Ashfield wrote:
> > On Wed, Aug 31, 2016 at 5:17 PM, Bruce Ashfield <
> bruce.ashfield@gmail.com>
> >
> > wrote:
> > > On Wed, Aug 31, 2016 at 5:13 PM, Bruce Ashfield <
> bruce.ashfield@gmail.com>
> > >
> > > wrote:
> > >> On Wed, Aug 31, 2016 at 5:11 PM, Mark Asselstine <
> > >>
> > >> mark.asselstine@windriver.com> wrote:
> > >>> On August 31, 2016 17:09:45 Mark Asselstine wrote:
> > >>> > On August 31, 2016 16:56:38 Bruce Ashfield wrote:
> > >>> > > On 2016-08-31 2:19 PM, Mark Asselstine wrote:
> > >>> > > > Seems upstream adjusted their LICENSE file. The license is
> still
> > >>> > > > Apache version 2 so no worries about having to update the
> LICENSE
> > >>> > > > string for the recipe.
> > >>> > >
> > >>> > > Or is this using a common LIC file which changed ? My oe-core is
> > >>> > > about two weeks out of date.
> > >>> >
> > >>> > Has nothing to do with the SRC_URI, it is a changed md5sum on the
> > >>>
> > >>> fetched
> > >>>
> > >>> > content, in this case the file named LICENSE.
> > >>>
> > >>> OH, I see why you tied it back to the git hash. That just means that
> > >>> this
> > >>> mismatch has existed since that hash was changed. Again, just masked
> by
> > >>> the
> > >>> manipulation of ERROR_QA.
> > >>
> > >> Nope. Shouldn't be that.
> > >>
> > >> I just did a cleanall and re-build. The checksum matches.
> > >
> > > ... and I just realized that cleanall doesn't get sstate, so I'd better
> > > remove that as well!
> >
> > Sure enough, it was sstate that was the difference, skipped tasks on my
> > recent build.
> >
> > I'm seeing this now.   So I'll apply this as-is.
> >
> > Shows how many people are tracking meta-virt master :D
>
> and building docker.
>
> Glad you were able to see it, had me scratching my head earlier today as
> well
> since it wasn't touched in so long and my meta-overc build was not seeing
> it.
>

Yep. and I have an even newer docker here that was masking the error and
causing
my sstate pain.

either way. mystery solved.

Bruce


>
> Mark
>
> >
> > Bruce
> >
> > > Bruce
> > >
> > >> Bruce
> > >>
> > >>> Mark
> > >>>
> > >>> > You are not seeing the issue because I am guessing you are building
> > >>>
> > >>> with
> > >>>
> > >>> > meta- overc, which we restrict the ERROR_QA and thus don't include
> > >>> > 'license- checksum'. Add 'license-checksum' to ERROR_QA in
> local.conf
> > >>>
> > >>> or
> > >>>
> > >>> > meta- overc/conf/distro/overc.conf and you will see this.
> > >>> >
> > >>> > Mark
> > >>> >
> > >>> > > Bruce
> > >>> > >
> > >>> > > > Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
> > >>> > > > ---
> > >>> > > >
> > >>> > > >  recipes-containers/docker/docker_git.bb | 2 +-
> > >>> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>> > > >
> > >>> > > > diff --git a/recipes-containers/docker/docker_git.bb
> > >>> > > > b/recipes-containers/docker/docker_git.bb index
> 4f85193..4be5e47
> > >>>
> > >>> 100644
> > >>>
> > >>> > > > --- a/recipes-containers/docker/docker_git.bb
> > >>> > > > +++ b/recipes-containers/docker/docker_git.bb
> > >>> > > > @@ -28,7 +28,7 @@ SRC_URI = "\
> > >>> > > >
> > >>> > > >  # Apache-2.0 for docker
> > >>> > > >  LICENSE = "Apache-2.0"
> > >>> > > >
> > >>> > > > -LIC_FILES_CHKSUM =
> > >>> > > > "file://LICENSE;md5=cc2221abf0b96ea39dd68141b70f7937"
> > >>> > > > +LIC_FILES_CHKSUM =
> > >>> > > > "file://LICENSE;md5=aadc30f9c14d876ded7bedc0afd2d3d7"
> > >>> > > >
> > >>> > > >  S = "${WORKDIR}/git"
> > >>>
> > >>> --
> > >>> _______________________________________________
> > >>> meta-virtualization mailing list
> > >>> meta-virtualization@yoctoproject.org
> > >>> https://lists.yoctoproject.org/listinfo/meta-virtualization
> > >>
> > >> --
> > >> "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee
> > >> at its end"
> > >
> > > --
> > > "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee
> > > at its end"
>
>


-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 7494 bytes --]

Re: [PATCH 2/2] docker: update license md5sum

[Jason Wessel]

[-- Attachment #1: Type: text/plain, Size: 2044 bytes --]

On 08/31/2016 04:27 PM, Bruce Ashfield wrote:
>
>
> On Wed, Aug 31, 2016 at 5:17 PM, Bruce Ashfield <bruce.ashfield@gmail.com <mailto:bruce.ashfield@gmail.com>> wrote:
>
>
>
>     On Wed, Aug 31, 2016 at 5:13 PM, Bruce Ashfield <bruce.ashfield@gmail.com <mailto:bruce.ashfield@gmail.com>> wrote:
>
>
>
>         On Wed, Aug 31, 2016 at 5:11 PM, Mark Asselstine <mark.asselstine@windriver.com <mailto:mark.asselstine@windriver.com>> wrote:
>
>             On August 31, 2016 17:09:45 Mark Asselstine wrote:
>             > On August 31, 2016 16:56:38 Bruce Ashfield wrote:
>             > > On 2016-08-31 2:19 PM, Mark Asselstine wrote:
>             > > > Seems upstream adjusted their LICENSE file. The license is still
>             > > > Apache version 2 so no worries about having to update the LICENSE
>             > > > string for the recipe.
>             > >
>             > > Or is this using a common LIC file which changed ? My oe-core is
>             > > about two weeks out of date.
>             >
>             > Has nothing to do with the SRC_URI, it is a changed md5sum on the fetched
>             > content, in this case the file named LICENSE.
>
>             OH, I see why you tied it back to the git hash. That just means that this
>             mismatch has existed since that hash was changed. Again, just masked by the
>             manipulation of ERROR_QA.
>
>
>         Nope. Shouldn't be that.
>
>         I just did a cleanall and re-build. The checksum matches.
>
>
>     ... and I just realized that cleanall doesn't get sstate, so I'd better remove that as well!
>
>
> Sure enough, it was sstate that was the difference, skipped tasks on my recent build.
>
> I'm seeing this now.   So I'll apply this as-is.
>
> Shows how many people are tracking meta-virt master :D
>



I hit the problem earlier but then the sstate made it go away, so something screwy is going on there.  A cleanall is supposed to clear the download + the sstate.

Kind of odd.

Jason.

[-- Attachment #2: Type: text/html, Size: 5854 bytes --]

Re: [PATCH 2/2] docker: update license md5sum

[Paul Eggleton]

On Wed, 31 Aug 2016 17:17:00 Bruce Ashfield wrote:
> On Wed, Aug 31, 2016 at 5:13 PM, Bruce Ashfield <bruce.ashfield@gmail.com>
> wrote:
> > I just did a cleanall and re-build. The checksum matches.
> 
> ... and I just realized that cleanall doesn't get sstate, so I'd better
> remove that as well!

Just to clear up any confusion, -c cleanall *will* delete sstate artifacts in 
your local sstate-cache, since the do_cleanall task depends on do_cleansstate. 
However, if you are using SSTATE_MIRRORS pointing to a mirror server and that 
contains matching artifacts there's no way for those to be removed from the 
bitbake side - though if you need to you can alter the signatures by using 
-c <task> -f / -C <task> (or just making a trivial change to the metadata) and 
then those artifacts won't be used.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH 2/2] docker: update license md5sum

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]

On Wed, Aug 31, 2016 at 6:28 PM, Paul Eggleton <
paul.eggleton@linux.intel.com> wrote:

> On Wed, 31 Aug 2016 17:17:00 Bruce Ashfield wrote:
> > On Wed, Aug 31, 2016 at 5:13 PM, Bruce Ashfield <
> bruce.ashfield@gmail.com>
> > wrote:
> > > I just did a cleanall and re-build. The checksum matches.
> >
> > ... and I just realized that cleanall doesn't get sstate, so I'd better
> > remove that as well!
>
> Just to clear up any confusion, -c cleanall *will* delete sstate artifacts
> in
> your local sstate-cache, since the do_cleanall task depends on
> do_cleansstate.
> However, if you are using SSTATE_MIRRORS pointing to a mirror server and
> that
> contains matching artifacts there's no way for those to be removed from the
> bitbake side - though if you need to you can alter the signatures by using
> -c <task> -f / -C <task> (or just making a trivial change to the metadata)
> and
> then those artifacts won't be used.
>

Right. I was getting them pulled from a mirror, which I disabled. Thanks
for
clarification, otherwise someone would search this up later and blame me
for leading them wrong :D

Bruce


>
> Cheers,
> Paul
>
> --
>
> Paul Eggleton
> Intel Open Source Technology Centre
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 2170 bytes --]