From: Stefan Weil <sw@weilnetz.de>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Redundant redeclaration of 'gmtime_r' with mingw64
Date: Mon, 08 Jun 2015 17:52:46 +0200 [thread overview]
Message-ID: <5575BA4E.1070908@weilnetz.de> (raw)
In-Reply-To: <20150608092117.GD30104@stefanha-thinkpad.redhat.com>
Am 08.06.2015 um 11:21 schrieb Stefan Hajnoczi:
> On Fri, Jun 05, 2015 at 07:18:53PM +0200, Stefan Weil wrote:
>>
>> The version provided by Debian Jessie (mingw-w64 3.2.0)
>> still uses macros to implement those functions - that's why
>> I don't see that compiler warnings.
>>
>> I'd prefer a solution which conditionally includes the QEMU
>> declaration (include/sysemu/os-win32.h) and the implementation
>> (util/oslib-win32.c), either depending on the mingw-w64 version
>> or on the result of a configuration check done while running
>> configure.
> Does that mean you want:
>
> 1. gmtime() is a macro - use QEMU implementation
> 2. gmtime() is a function - use mingw function
= declared via time.h and implemented in a standard library.
> 3. gmtime() is undefined - use QEMU implementation
>
> ?
Yes, exactly.
next prev parent reply other threads:[~2015-06-08 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 14:38 [Qemu-devel] Redundant redeclaration of 'gmtime_r' with mingw64 Stefan Hajnoczi
2015-06-05 17:18 ` Stefan Weil
2015-06-08 9:21 ` Stefan Hajnoczi
2015-06-08 15:52 ` Stefan Weil [this message]
2015-09-22 13:11 ` Michael S. Tsirkin
2015-09-22 13:19 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5575BA4E.1070908@weilnetz.de \
--to=sw@weilnetz.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.