From: Bhuvanchandra DV <bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
To: Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
moorray3-5tc4TXWwyLM@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
stefan-XLVq0VzYD2Y@public.gmane.org,
bhuvanchandra.dv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
jslaby-AlSwsSmVLrQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl
Date: Tue, 9 Jun 2015 09:42:28 +0530 [thread overview]
Message-ID: <557667AC.3030506@toradex.com> (raw)
In-Reply-To: <20150608091244.GS7557-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
On 06/08/2015 02:42 PM, Russell King - ARM Linux wrote:
> On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote:
>> + /*
>> + * CTS/RTS can _only_ be handled
>> + * automatically by the hardware.
>> + */
>
> That's really not acceptable. You need to do something here so that you
> can _force_ RTS to be deasserted when the kernel buffers fill up - be
> that by stopping reading characters and letting the FIFO fill up or
> something of that ilk.
Agreed, will fix this.
>
> Ignoring the rest of the flow control system in the kernel is not really
> acceptable.
>
Best regards,
Bhuvan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: bhuvanchandra.dv@toradex.com (Bhuvanchandra DV)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl
Date: Tue, 9 Jun 2015 09:42:28 +0530 [thread overview]
Message-ID: <557667AC.3030506@toradex.com> (raw)
In-Reply-To: <20150608091244.GS7557@n2100.arm.linux.org.uk>
On 06/08/2015 02:42 PM, Russell King - ARM Linux wrote:
> On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote:
>> + /*
>> + * CTS/RTS can _only_ be handled
>> + * automatically by the hardware.
>> + */
>
> That's really not acceptable. You need to do something here so that you
> can _force_ RTS to be deasserted when the kernel buffers fill up - be
> that by stopping reading characters and letting the FIFO fill up or
> something of that ilk.
Agreed, will fix this.
>
> Ignoring the rest of the flow control system in the kernel is not really
> acceptable.
>
Best regards,
Bhuvan
WARNING: multiple messages have this Message-ID (diff)
From: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: <gregkh@linuxfoundation.org>, <devicetree@vger.kernel.org>,
<linux-serial@vger.kernel.org>, <moorray3@wp.pl>,
<linux-kernel@vger.kernel.org>, <stefan@agner.ch>,
<bhuvanchandra.dv@gmail.com>, <kernel@pengutronix.de>,
<shawn.guo@linaro.org>, <jslaby@suse.cz>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl
Date: Tue, 9 Jun 2015 09:42:28 +0530 [thread overview]
Message-ID: <557667AC.3030506@toradex.com> (raw)
In-Reply-To: <20150608091244.GS7557@n2100.arm.linux.org.uk>
On 06/08/2015 02:42 PM, Russell King - ARM Linux wrote:
> On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote:
>> + /*
>> + * CTS/RTS can _only_ be handled
>> + * automatically by the hardware.
>> + */
>
> That's really not acceptable. You need to do something here so that you
> can _force_ RTS to be deasserted when the kernel buffers fill up - be
> that by stopping reading characters and letting the FIFO fill up or
> something of that ilk.
Agreed, will fix this.
>
> Ignoring the rest of the flow control system in the kernel is not really
> acceptable.
>
Best regards,
Bhuvan
next prev parent reply other threads:[~2015-06-09 4:12 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 5:21 [PATCH V2 0/3] Add RS-485 support and fix RTS/CTS implementation Bhuvanchandra DV
2015-06-01 5:21 ` Bhuvanchandra DV
2015-06-01 5:21 ` Bhuvanchandra DV
2015-06-01 5:21 ` [PATCH V2 3/3] tty: serial: fsl_lpuart: Add support for RS-485 Bhuvanchandra DV
2015-06-01 5:21 ` Bhuvanchandra DV
2015-06-01 5:21 ` Bhuvanchandra DV
[not found] ` <1433136067-20644-1-git-send-email-bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
2015-06-01 5:21 ` [PATCH V2 1/3] ARM: dts: colibri-vf: Add pinmux for UART_0 aka UART_A RTS/CTS pins Bhuvanchandra DV
2015-06-01 5:21 ` Bhuvanchandra DV
2015-06-01 5:21 ` Bhuvanchandra DV
2015-06-01 5:21 ` [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl Bhuvanchandra DV
2015-06-01 5:21 ` Bhuvanchandra DV
2015-06-01 5:21 ` Bhuvanchandra DV
[not found] ` <1433136067-20644-3-git-send-email-bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
2015-06-08 6:41 ` Uwe Kleine-König
2015-06-08 6:41 ` Uwe Kleine-König
2015-06-08 6:41 ` Uwe Kleine-König
2015-06-08 7:25 ` Bhuvanchandra DV
2015-06-08 7:25 ` Bhuvanchandra DV
2015-06-08 7:25 ` Bhuvanchandra DV
[not found] ` <20150608064113.GX18985-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-06-08 9:14 ` Russell King - ARM Linux
2015-06-08 9:14 ` Russell King - ARM Linux
2015-06-08 9:14 ` Russell King - ARM Linux
2015-06-08 9:19 ` Russell King - ARM Linux
2015-06-08 9:19 ` Russell King - ARM Linux
2015-06-08 9:19 ` Russell King - ARM Linux
2015-06-08 9:12 ` Russell King - ARM Linux
2015-06-08 9:12 ` Russell King - ARM Linux
[not found] ` <20150608091244.GS7557-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-06-09 4:12 ` Bhuvanchandra DV [this message]
2015-06-09 4:12 ` Bhuvanchandra DV
2015-06-09 4:12 ` Bhuvanchandra DV
2015-06-08 5:58 ` [PATCH V2 0/3] Add RS-485 support and fix RTS/CTS implementation Bhuvanchandra DV
2015-06-08 5:58 ` Bhuvanchandra DV
2015-06-08 5:58 ` Bhuvanchandra DV
[not found] ` <55752EF5.1040103-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
2015-06-13 0:35 ` Greg KH
2015-06-13 0:35 ` Greg KH
2015-06-13 0:35 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557667AC.3030506@toradex.com \
--to=bhuvanchandra.dv-2kbjvhiyjgbbdgjk7y7tuq@public.gmane.org \
--cc=bhuvanchandra.dv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=jslaby-AlSwsSmVLrQ@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=moorray3-5tc4TXWwyLM@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=stefan-XLVq0VzYD2Y@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.