From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Cyrille Pitchen
<cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org
Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v6 5/6] i2c: at91: print hardware version
Date: Tue, 09 Jun 2015 22:46:20 +0300 [thread overview]
Message-ID: <5577428C.3090206@cogentembedded.com> (raw)
In-Reply-To: <d1fbf4bce3b470409ef3198f551cfc3f8f22ac78.1433866582.git.cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Hello.
On 06/09/2015 07:22 PM, Cyrille Pitchen wrote:
> The probe() function now prints the hardware version of the I2C
> controller.
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-at91.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> index 817ae69..6e88b30 100644
> --- a/drivers/i2c/busses/i2c-at91.c
> +++ b/drivers/i2c/busses/i2c-at91.c
[...]
> @@ -908,7 +910,8 @@ static int at91_twi_probe(struct platform_device *pdev)
> return rc;
> }
>
> - dev_info(dev->dev, "AT91 i2c bus driver.\n");
> + dev_info(dev->dev, "AT91 i2c bus driver (version: %#x).\n",
It looks as if you rather print the driver's version. :-)
> + at91_twi_read(dev, AT91_TWI_VER));
> return 0;
> }
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 5/6] i2c: at91: print hardware version
Date: Tue, 09 Jun 2015 22:46:20 +0300 [thread overview]
Message-ID: <5577428C.3090206@cogentembedded.com> (raw)
In-Reply-To: <d1fbf4bce3b470409ef3198f551cfc3f8f22ac78.1433866582.git.cyrille.pitchen@atmel.com>
Hello.
On 06/09/2015 07:22 PM, Cyrille Pitchen wrote:
> The probe() function now prints the hardware version of the I2C
> controller.
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> ---
> drivers/i2c/busses/i2c-at91.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> index 817ae69..6e88b30 100644
> --- a/drivers/i2c/busses/i2c-at91.c
> +++ b/drivers/i2c/busses/i2c-at91.c
[...]
> @@ -908,7 +910,8 @@ static int at91_twi_probe(struct platform_device *pdev)
> return rc;
> }
>
> - dev_info(dev->dev, "AT91 i2c bus driver.\n");
> + dev_info(dev->dev, "AT91 i2c bus driver (version: %#x).\n",
It looks as if you rather print the driver's version. :-)
> + at91_twi_read(dev, AT91_TWI_VER));
> return 0;
> }
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Cyrille Pitchen <cyrille.pitchen@atmel.com>,
ludovic.desroches@atmel.com, nicolas.ferre@atmel.com,
linux-i2c@vger.kernel.org, wsa@the-dreams.de
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
galak@codeaurora.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 5/6] i2c: at91: print hardware version
Date: Tue, 09 Jun 2015 22:46:20 +0300 [thread overview]
Message-ID: <5577428C.3090206@cogentembedded.com> (raw)
In-Reply-To: <d1fbf4bce3b470409ef3198f551cfc3f8f22ac78.1433866582.git.cyrille.pitchen@atmel.com>
Hello.
On 06/09/2015 07:22 PM, Cyrille Pitchen wrote:
> The probe() function now prints the hardware version of the I2C
> controller.
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> ---
> drivers/i2c/busses/i2c-at91.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> index 817ae69..6e88b30 100644
> --- a/drivers/i2c/busses/i2c-at91.c
> +++ b/drivers/i2c/busses/i2c-at91.c
[...]
> @@ -908,7 +910,8 @@ static int at91_twi_probe(struct platform_device *pdev)
> return rc;
> }
>
> - dev_info(dev->dev, "AT91 i2c bus driver.\n");
> + dev_info(dev->dev, "AT91 i2c bus driver (version: %#x).\n",
It looks as if you rather print the driver's version. :-)
> + at91_twi_read(dev, AT91_TWI_VER));
> return 0;
> }
WBR, Sergei
next prev parent reply other threads:[~2015-06-09 19:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 16:22 [PATCH v6 0/6] i2c: at91: add support to FIFOs and alternative command Cyrille Pitchen
2015-06-09 16:22 ` Cyrille Pitchen
2015-06-09 16:22 ` Cyrille Pitchen
2015-06-09 16:22 ` [PATCH v6 3/6] i2c: at91: update documentation for DT bindings Cyrille Pitchen
2015-06-09 16:22 ` Cyrille Pitchen
2015-06-09 16:22 ` Cyrille Pitchen
[not found] ` <cover.1433866582.git.cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-06-09 16:22 ` [PATCH v6 1/6] i2c: at91: fix a race condition when using the DMA controller Cyrille Pitchen
2015-06-09 16:22 ` Cyrille Pitchen
2015-06-09 16:22 ` Cyrille Pitchen
2015-06-09 16:22 ` [PATCH v6 2/6] i2c: at91: use BIT() macro to define register bits Cyrille Pitchen
2015-06-09 16:22 ` Cyrille Pitchen
2015-06-09 16:22 ` Cyrille Pitchen
2015-06-09 16:22 ` [PATCH v6 4/6] i2c: at91: add support for new alternative command mode Cyrille Pitchen
2015-06-09 16:22 ` Cyrille Pitchen
2015-06-09 16:22 ` Cyrille Pitchen
2015-06-09 16:22 ` [PATCH v6 5/6] i2c: at91: print hardware version Cyrille Pitchen
2015-06-09 16:22 ` Cyrille Pitchen
2015-06-09 16:22 ` Cyrille Pitchen
[not found] ` <d1fbf4bce3b470409ef3198f551cfc3f8f22ac78.1433866582.git.cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-06-09 19:46 ` Sergei Shtylyov [this message]
2015-06-09 19:46 ` Sergei Shtylyov
2015-06-09 19:46 ` Sergei Shtylyov
[not found] ` <5577428C.3090206-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2015-06-10 8:05 ` Ludovic Desroches
2015-06-10 8:05 ` Ludovic Desroches
2015-06-10 8:05 ` Ludovic Desroches
2015-06-10 12:10 ` Sergei Shtylyov
2015-06-10 12:10 ` Sergei Shtylyov
2015-06-10 12:15 ` Wolfram Sang
2015-06-10 12:15 ` Wolfram Sang
2015-06-09 16:22 ` [PATCH v6 6/6] i2c: at91: add support to FIFOs Cyrille Pitchen
2015-06-09 16:22 ` Cyrille Pitchen
2015-06-09 16:22 ` Cyrille Pitchen
2015-06-10 12:57 ` [PATCH v6 0/6] i2c: at91: add support to FIFOs and alternative command Wolfram Sang
2015-06-10 12:57 ` Wolfram Sang
2015-06-10 13:09 ` Wolfram Sang
2015-06-10 13:09 ` Wolfram Sang
2015-06-10 13:09 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5577428C.3090206@cogentembedded.com \
--to=sergei.shtylyov-m4dtvfq/zs1mrggop+s0pdbpr1lh4cv8@public.gmane.org \
--cc=cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.