All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <clm@fb.com>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: <adam900710@gmail.com>, linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [GIT PULL] Qgroup rework with other Fujitsu fix.
Date: Wed, 10 Jun 2015 16:45:46 -0400	[thread overview]
Message-ID: <5578A1FA.70400@fb.com> (raw)
In-Reply-To: <557506BC.701@cn.fujitsu.com>

On 06/07/2015 11:06 PM, Qu Wenruo wrote:
> Hi Chris,
> 
> Please pull the 19 patchset from my branch for_chris_4.2.
> We have tested it in a week.
> 
> Although it is originally based on 4.1-rc5, not the integration branch.
> Quick tests shows no new bugs, although we will rerun the full test,
> I'll send the patchset first for your reviewing:
> 
> https://github.com/adam900710/linux.git for_chris_4.2
> 
> This contains the following patches.
> 
> 1. Qgroup rework (first 18 commits)
> These commits rework the qgroup framework.
> Now, quota won't need to do per-delayed-ref accounting.
> But only need to record dirty delayed-ref, and account quota at
> transaction time.
> 
> The good thing is, at transaction time, we have no other interruption or
> concurrency, account can be quite accurate and only need to account once
> for every dirty extent.(especially faster for shared extents)
> 
> And clearer codes and logic. Codes changes from 1K to 0.5K, even a lot
> of comments are added.
> 

Thanks for preparing all of this! I especially love the comments added.

> With the patchset, btrfs can pass all qgroup test in fstests.
> No longer minus number now.

And the passing xfstests ;)

While I review and test these, I have them at the top of the
integration-4.2 branch.  integration-4.2 may get rebased if I have to
take these out, but I'm trying to use the extra time (Linus plans on an
rc8) to test them as much as possible.

-chris


      parent reply	other threads:[~2015-06-10 20:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-08  3:06 [GIT PULL] Qgroup rework with other Fujitsu fix Qu Wenruo
2015-06-09  6:03 ` Wang Shilong
2015-06-09  7:09   ` Qu Wenruo
2015-06-24  6:54   ` Qu Wenruo
2015-06-09 14:10 ` Josef Bacik
     [not found]   ` <CAFy8SQW58c7DUUod7FaiNtY2MaoY6ZYt3jacG-RQHJZx+4so7A@mail.gmail.com>
2015-06-09 14:54     ` Josef Bacik
2015-06-10  0:33       ` Qu Wenruo
2015-06-10  0:33       ` Qu Wenruo
2015-06-10 20:45 ` Chris Mason [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5578A1FA.70400@fb.com \
    --to=clm@fb.com \
    --cc=adam900710@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.