From: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
To: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Bill Richardson
<wfrichar-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Simon Glass <sjg-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Gwendal Grignou <gwendal-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Stephen Barber <smbarber-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Filipe Brandenburger
<filbranden-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Todd Broch <tbroch-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Alexandru M Stan <amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v7 0/8] mfd: cros_ec: Add multi EC and proto v3 support
Date: Thu, 11 Jun 2015 14:05:09 +0200 [thread overview]
Message-ID: <55797975.4010108@collabora.co.uk> (raw)
In-Reply-To: <24727363.WKhvMDQ6EE@diego>
Hello Heiko,
On 06/11/2015 01:50 PM, Heiko Stübner wrote:
> Am Dienstag, 9. Juni 2015, 13:04:41 schrieb Javier Martinez Canillas:
>> Hello,
>>
>> This is a v7 of a series that adds support for multiple EC in a system
>> and also for the protocol version 3 that is used on newer ECs.
>>
>> Most patches were taken from the downstream ChromiumOS v3.14 tree with
>> fixes squashed, split to minimise the cross subsystem churn and changes
>> for mainline inclusion but were not modified functionality wise.
>>
>> This version addresses issues pointed out by Lee Jones on the v6 posted
>> before [0] and also adds the Acked-by tags of all the needed maintainers.
>>
>> The patches are based on top of "[PATCH 0/2] mfd: cros_ec: Small cleanups"
>> [1] that were posted before and already picked by Lee Jones.
>>
>> Testing was done on some Chromebooks that have a single EC and support
>> protocol v2 such as the Exynos5250 Snow, Exynos5420 Peach Pit and Exynos5800
>> Peach Pi to be sure that no regressions were introduced for these machines.
>>
>> The series were tested using a modified ectool [2] that supports the new
>> cros_ec IOCTL API. They were also tested on a x86 Pixel Chromebook 2 (Samus)
>> that uses the new protocol v3 and has 2 EC (cros_ec and cros_pd). But for
>> testing on Samus, also the posted "[PATCH 0/3] platform/chrome: Changes for
>> cros_ec_lpc and cros_ec_dev" series [3] are needed.
>
> everything still works as expected on a rk3288-veyron-jerry
>
> Tested-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> [tags are already present in the patches]
>
>
Thanks a lot for testing again the patches.
> As the series now has Olof's Ack, can this still make it in time for 4.2 - as
> there is still a bit more than a week left till the merge window?
>
I hope so, the patch series have been in the lists for months now and been
tested and reviewed in extensively. I also made sure that it doesn't cause
any regressions on older Chromebook so it should be safe to pick for 4.2
>
> Heiko
>
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Lee Jones <lee.jones@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Olof Johansson <olof@lixom.net>,
Doug Anderson <dianders@chromium.org>,
Bill Richardson <wfrichar@chromium.org>,
Simon Glass <sjg@google.com>,
Gwendal Grignou <gwendal@google.com>,
Stephen Barber <smbarber@chromium.org>,
Filipe Brandenburger <filbranden@google.com>,
Todd Broch <tbroch@chromium.org>,
Alexandru M Stan <amstan@chromium.org>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v7 0/8] mfd: cros_ec: Add multi EC and proto v3 support
Date: Thu, 11 Jun 2015 14:05:09 +0200 [thread overview]
Message-ID: <55797975.4010108@collabora.co.uk> (raw)
In-Reply-To: <24727363.WKhvMDQ6EE@diego>
Hello Heiko,
On 06/11/2015 01:50 PM, Heiko Stübner wrote:
> Am Dienstag, 9. Juni 2015, 13:04:41 schrieb Javier Martinez Canillas:
>> Hello,
>>
>> This is a v7 of a series that adds support for multiple EC in a system
>> and also for the protocol version 3 that is used on newer ECs.
>>
>> Most patches were taken from the downstream ChromiumOS v3.14 tree with
>> fixes squashed, split to minimise the cross subsystem churn and changes
>> for mainline inclusion but were not modified functionality wise.
>>
>> This version addresses issues pointed out by Lee Jones on the v6 posted
>> before [0] and also adds the Acked-by tags of all the needed maintainers.
>>
>> The patches are based on top of "[PATCH 0/2] mfd: cros_ec: Small cleanups"
>> [1] that were posted before and already picked by Lee Jones.
>>
>> Testing was done on some Chromebooks that have a single EC and support
>> protocol v2 such as the Exynos5250 Snow, Exynos5420 Peach Pit and Exynos5800
>> Peach Pi to be sure that no regressions were introduced for these machines.
>>
>> The series were tested using a modified ectool [2] that supports the new
>> cros_ec IOCTL API. They were also tested on a x86 Pixel Chromebook 2 (Samus)
>> that uses the new protocol v3 and has 2 EC (cros_ec and cros_pd). But for
>> testing on Samus, also the posted "[PATCH 0/3] platform/chrome: Changes for
>> cros_ec_lpc and cros_ec_dev" series [3] are needed.
>
> everything still works as expected on a rk3288-veyron-jerry
>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
> [tags are already present in the patches]
>
>
Thanks a lot for testing again the patches.
> As the series now has Olof's Ack, can this still make it in time for 4.2 - as
> there is still a bit more than a week left till the merge window?
>
I hope so, the patch series have been in the lists for months now and been
tested and reviewed in extensively. I also made sure that it doesn't cause
any regressions on older Chromebook so it should be safe to pick for 4.2
>
> Heiko
>
Best regards,
Javier
next prev parent reply other threads:[~2015-06-11 12:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 11:04 [PATCH v7 0/8] mfd: cros_ec: Add multi EC and proto v3 support Javier Martinez Canillas
2015-06-09 11:04 ` Javier Martinez Canillas
2015-06-09 11:04 ` [PATCH v7 2/8] mfd: cros_ec: rev cros_ec_commands.h Javier Martinez Canillas
2015-06-15 12:23 ` Lee Jones
2015-06-09 11:04 ` [PATCH v7 3/8] mfd: cros_ec: Move protocol helpers out of the MFD driver Javier Martinez Canillas
2015-06-15 12:23 ` Lee Jones
2015-06-09 11:04 ` [PATCH v7 4/8] mfd: cros_ec: add proto v3 skeleton Javier Martinez Canillas
2015-06-15 12:23 ` Lee Jones
2015-06-09 11:04 ` [PATCH v7 5/8] mfd: cros_ec: add bus-specific proto v3 code Javier Martinez Canillas
2015-06-15 12:24 ` Lee Jones
2015-06-09 11:04 ` [PATCH v7 6/8] mfd: cros_ec: Support multiple EC in a system Javier Martinez Canillas
2015-06-15 12:24 ` Lee Jones
[not found] ` <1433847889-7220-1-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2015-06-09 11:04 ` [PATCH v7 1/8] mfd: cros_ec: Use a zero-length array for command data Javier Martinez Canillas
2015-06-09 11:04 ` Javier Martinez Canillas
[not found] ` <1433847889-7220-2-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2015-06-15 12:22 ` Lee Jones
2015-06-15 12:22 ` Lee Jones
2015-06-09 11:04 ` [PATCH v7 7/8] mfd: cros_ec: spi: Add a DT property to delay asserting the CS Javier Martinez Canillas
2015-06-09 11:04 ` Javier Martinez Canillas
2015-06-15 12:25 ` Lee Jones
2015-06-09 11:04 ` [PATCH v7 8/8] mfd: cros_ec: spi: Add delay for asserting CS Javier Martinez Canillas
2015-06-09 11:04 ` Javier Martinez Canillas
2015-06-15 12:25 ` Lee Jones
2015-06-11 11:50 ` [PATCH v7 0/8] mfd: cros_ec: Add multi EC and proto v3 support Heiko Stübner
2015-06-11 12:05 ` Javier Martinez Canillas [this message]
2015-06-11 12:05 ` Javier Martinez Canillas
2015-06-15 12:29 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55797975.4010108@collabora.co.uk \
--to=javier.martinez-zgy8ohtn/8ppycu2f3hruq@public.gmane.org \
--cc=amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=filbranden-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=gwendal-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=sjg-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=smbarber-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=tbroch-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=wfrichar-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.