From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] clocksource: bcm2835: Migrate to new 'set-state' interface
Date: Thu, 11 Jun 2015 18:13:59 +0200 [thread overview]
Message-ID: <5579B3C7.5030305@linaro.org> (raw)
In-Reply-To: <20150611160048.GC4386@linux>
On 06/11/2015 06:00 PM, Viresh Kumar wrote:
> On 11-06-15, 17:25, Daniel Lezcano wrote:
>> Please mention in the log you removed the RESUME because it does
>> nothing and the core code will just ignore it.
>
> Okay.
>
>> The patch is ok but there is an inconsistency on how are handled the
>> different callbacks. tick_resume can be omitted but not
>> state_shutdown and state_oneshot forcing the drivers to define empty
>> functions.
>
> It was done because they are thought to be compulsory, but even I
> am not sure if we should make all callbacks as optional.
Yes, I think it would make sense to ignore NULL callback in
__clockevents_set_state, otherwise we will end up to fill the different
drivers with duplicated noop functions.
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>
Subject: Re: [PATCH 3/6] clocksource: bcm2835: Migrate to new 'set-state' interface
Date: Thu, 11 Jun 2015 18:13:59 +0200 [thread overview]
Message-ID: <5579B3C7.5030305@linaro.org> (raw)
In-Reply-To: <20150611160048.GC4386@linux>
On 06/11/2015 06:00 PM, Viresh Kumar wrote:
> On 11-06-15, 17:25, Daniel Lezcano wrote:
>> Please mention in the log you removed the RESUME because it does
>> nothing and the core code will just ignore it.
>
> Okay.
>
>> The patch is ok but there is an inconsistency on how are handled the
>> different callbacks. tick_resume can be omitted but not
>> state_shutdown and state_oneshot forcing the drivers to define empty
>> functions.
>
> It was done because they are thought to be compulsory, but even I
> am not sure if we should make all callbacks as optional.
Yes, I think it would make sense to ignore NULL callback in
__clockevents_set_state, otherwise we will end up to fill the different
drivers with duplicated noop functions.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2015-06-11 16:13 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 13:40 [PATCH 0/6] clockevent: Migrate to new 'set-state' interface Viresh Kumar
2015-06-08 13:40 ` Viresh Kumar
2015-06-08 13:40 ` [PATCH 1/6] clocksource: arm_arch_timer: " Viresh Kumar
2015-06-08 13:40 ` Viresh Kumar
2015-06-11 12:23 ` Daniel Lezcano
2015-06-11 12:23 ` Daniel Lezcano
2015-06-11 12:57 ` Viresh Kumar
2015-06-11 12:57 ` Viresh Kumar
2015-06-08 13:40 ` [PATCH 2/6] clocksource: arm_global_timer: " Viresh Kumar
2015-06-08 13:40 ` Viresh Kumar
2015-06-11 14:49 ` Daniel Lezcano
2015-06-11 14:49 ` Daniel Lezcano
2015-06-11 14:56 ` Viresh Kumar
2015-06-11 14:56 ` Viresh Kumar
2015-06-11 14:58 ` Daniel Lezcano
2015-06-11 14:58 ` Daniel Lezcano
2015-06-12 8:39 ` Srinivas Kandagatla
2015-06-12 8:39 ` Srinivas Kandagatla
2015-06-12 8:51 ` Viresh Kumar
2015-06-12 8:51 ` Viresh Kumar
2015-06-08 13:40 ` [PATCH 3/6] clocksource: bcm2835: " Viresh Kumar
2015-06-08 13:40 ` Viresh Kumar
2015-06-11 15:25 ` Daniel Lezcano
2015-06-11 15:25 ` Daniel Lezcano
2015-06-11 16:00 ` Viresh Kumar
2015-06-11 16:00 ` Viresh Kumar
2015-06-11 16:13 ` Daniel Lezcano [this message]
2015-06-11 16:13 ` Daniel Lezcano
2015-06-11 16:27 ` Viresh Kumar
2015-06-11 16:27 ` Viresh Kumar
2015-06-08 13:40 ` [PATCH 4/6] clocksource: bcm_kona: " Viresh Kumar
2015-06-08 13:40 ` Viresh Kumar
2015-06-08 16:09 ` Ray Jui
2015-06-08 16:09 ` Ray Jui
2015-06-08 16:22 ` Viresh Kumar
2015-06-08 16:22 ` Viresh Kumar
2015-06-08 16:30 ` Ray Jui
2015-06-08 16:30 ` Ray Jui
2015-06-08 17:10 ` Ray Jui
2015-06-08 17:10 ` Ray Jui
2015-06-08 13:40 ` [PATCH 5/6] clocksource: cs5535: " Viresh Kumar
2015-06-08 13:40 ` Viresh Kumar
2015-06-11 15:50 ` Daniel Lezcano
2015-06-11 15:50 ` Daniel Lezcano
2015-06-08 13:40 ` [PATCH 6/6] clocksource: em_sti: " Viresh Kumar
2015-06-08 13:40 ` Viresh Kumar
2015-06-11 15:53 ` Daniel Lezcano
2015-06-11 15:53 ` Daniel Lezcano
2015-06-11 12:08 ` [PATCH 0/6] clockevent: " Daniel Lezcano
2015-06-11 12:08 ` Daniel Lezcano
2015-06-11 13:00 ` Viresh Kumar
2015-06-11 13:00 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5579B3C7.5030305@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.