From: Chris Mason <clm@fb.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Shaohua Li <shli@fb.com>,
netdev@vger.kernel.org, davem@davemloft.net, Kernel-team@fb.com,
Eric Dumazet <edumazet@google.com>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org
Subject: Re: [RFC] net: use atomic allocation for order-3 page allocation
Date: Thu, 11 Jun 2015 18:18:49 -0400 [thread overview]
Message-ID: <557A0949.3020705@fb.com> (raw)
In-Reply-To: <1434057733.27504.52.camel@edumazet-glaptop2.roam.corp.google.com>
On 06/11/2015 05:22 PM, Eric Dumazet wrote:
> On Thu, 2015-06-11 at 17:16 -0400, Chris Mason wrote:
>> On 06/11/2015 04:48 PM, Eric Dumazet wrote:
>>
>> networking is asking for 32KB, and the MM layer is doing what it can to
>> provide it. Are the gains from getting 32KB contig bigger than the cost
>> of moving pages around if the MM has to actually go into compaction?
>> Should we start disk IO to give back 32KB contig?
>>
>> I think we want to tell the MM to compact in the background and give
>> networking 32KB if it happens to have it available. If not, fall back
>> to smaller allocations without doing anything expensive.
>
> Exactly my point. (And I mentioned this about 4 months ago)
Sorry, reading this again I wasn't very clear. I agree with Shaohua's
patch because it is telling the allocator that we don't want to wait for
reclaim or compaction to find contiguous pages.
But, is there any fallback to a single page allocation somewhere else?
If this is the only way to get memory, we might want to add a single
alloc_page path that won't trigger compaction but is at least able to
wait for kswapd to make progress.
-chris
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Chris Mason <clm@fb.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Shaohua Li <shli@fb.com>, <netdev@vger.kernel.org>,
<davem@davemloft.net>, <Kernel-team@fb.com>,
Eric Dumazet <edumazet@google.com>,
David Rientjes <rientjes@google.com>, <linux-mm@kvack.org>
Subject: Re: [RFC] net: use atomic allocation for order-3 page allocation
Date: Thu, 11 Jun 2015 18:18:49 -0400 [thread overview]
Message-ID: <557A0949.3020705@fb.com> (raw)
In-Reply-To: <1434057733.27504.52.camel@edumazet-glaptop2.roam.corp.google.com>
On 06/11/2015 05:22 PM, Eric Dumazet wrote:
> On Thu, 2015-06-11 at 17:16 -0400, Chris Mason wrote:
>> On 06/11/2015 04:48 PM, Eric Dumazet wrote:
>>
>> networking is asking for 32KB, and the MM layer is doing what it can to
>> provide it. Are the gains from getting 32KB contig bigger than the cost
>> of moving pages around if the MM has to actually go into compaction?
>> Should we start disk IO to give back 32KB contig?
>>
>> I think we want to tell the MM to compact in the background and give
>> networking 32KB if it happens to have it available. If not, fall back
>> to smaller allocations without doing anything expensive.
>
> Exactly my point. (And I mentioned this about 4 months ago)
Sorry, reading this again I wasn't very clear. I agree with Shaohua's
patch because it is telling the allocator that we don't want to wait for
reclaim or compaction to find contiguous pages.
But, is there any fallback to a single page allocation somewhere else?
If this is the only way to get memory, we might want to add a single
alloc_page path that won't trigger compaction but is at least able to
wait for kswapd to make progress.
-chris
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-06-11 22:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 20:24 [RFC] net: use atomic allocation for order-3 page allocation Shaohua Li
2015-06-11 22:27 ` [RFC v2] " Shaohua Li
2015-06-11 20:48 ` [RFC] " Eric Dumazet
2015-06-11 20:48 ` Eric Dumazet
2015-06-11 21:16 ` Chris Mason
2015-06-11 21:16 ` Chris Mason
2015-06-11 21:22 ` Eric Dumazet
2015-06-11 21:45 ` Shaohua Li
2015-06-11 21:45 ` Shaohua Li
2015-06-11 21:56 ` Eric Dumazet
2015-06-11 22:01 ` Shaohua Li
2015-06-11 22:01 ` Shaohua Li
2015-06-11 22:18 ` Chris Mason [this message]
2015-06-11 22:18 ` Chris Mason
2015-06-11 22:55 ` Eric Dumazet
2015-06-11 21:35 ` Debabrata Banerjee
2015-06-11 22:18 ` David Miller
2015-06-12 9:25 ` Vlastimil Babka
2015-06-11 21:25 ` Debabrata Banerjee
2015-06-11 21:28 ` Debabrata Banerjee
2015-06-12 9:34 ` Vlastimil Babka
2015-06-11 22:53 ` [RFC v2] " Eric Dumazet
2015-06-11 23:32 ` Shaohua Li
2015-06-11 23:32 ` Shaohua Li
2015-06-11 23:38 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557A0949.3020705@fb.com \
--to=clm@fb.com \
--cc=Kernel-team@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=rientjes@google.com \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.