Re: [v3][PATCH 04/16] xen/passthrough: extend hypercall to support rdm reservation policy

["Chen, Tiejun" <tiejun.chen@intel.com>]

On 2015/6/12 17:20, Chen, Tiejun wrote:
> On 2015/6/12 16:45, Jan Beulich wrote:
>>>>> On 12.06.15 at 08:31, <tiejun.chen@intel.com> wrote:
>>> On 2015/6/11 17:28, Tian, Kevin wrote:
>>>>> From: Chen, Tiejun
>>>>> Sent: Thursday, June 11, 2015 9:15 AM
>>>>> @@ -1940,7 +1942,8 @@ static int intel_iommu_remove_device(u8
>>>>> devfn, struct pci_dev
>>>>> *pdev)
>>>>>                 PCI_DEVFN2(bdf) != devfn )
>>>>>                continue;
>>>>>
>>>>> -        rmrr_identity_mapping(pdev->domain, 0, rmrr);
>>>>> +        rmrr_identity_mapping(pdev->domain, 0, rmrr,
>>>>> +                              XEN_DOMCTL_DEV_RDM_RELAXED);
>>>>
>>>> ditto
>>>
>>> It doesn't matter when we're trying to remove a device since we don't
>>> care this flag.
>>
>> In such a case it helps to add a brief comment saying that the precise
>> value passed is irrelevant. Or maybe this could be expressed by
>
> Okay.

Just let me go this simple way now.

Thanks
Tiejun