All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@openwrt.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [RFC] ath9k: allow to receive probe request when offchannel
Date: Mon, 15 Jun 2015 13:46:55 +0200	[thread overview]
Message-ID: <557EBB2F.8000503@openwrt.org> (raw)
In-Reply-To: <1433912583-15918-1-git-send-email-janusz.dziedzic@tieto.com>

On 2015-06-10 07:03, Janusz Dziedzic wrote:
> This fix problem that p2p group negotiation didn't work
> correctly when chanctx used, because we didn't receive
> probe requests when offchannel and use_chanctx=1
> 
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
> ---
> @Felix, Sujith could you review? I am not sure I put this in correct place.
> 
>  drivers/net/wireless/ath/ath9k/channel.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/channel.c b/drivers/net/wireless/ath/ath9k/channel.c
> index 2066650..6301d44 100644
> --- a/drivers/net/wireless/ath/ath9k/channel.c
> +++ b/drivers/net/wireless/ath/ath9k/channel.c
> @@ -1157,6 +1157,7 @@ static bool ath_chanctx_defer_switch(struct ath_softc *sc)
>  static void ath_offchannel_channel_change(struct ath_softc *sc)
>  {
>  	struct ath_common *common = ath9k_hw_common(sc->sc_ah);
> +	u32 rfilt;
>  
>  	ath_dbg(common, CHAN_CTX, "%s: offchannel state: %s\n",
>  		__func__, offchannel_state_string(sc->offchannel.state));
> @@ -1179,6 +1180,11 @@ static void ath_offchannel_channel_change(struct ath_softc *sc)
>  		ath_scan_complete(sc, false);
>  		break;
>  	case ATH_OFFCHANNEL_ROC_START:
> +		/* Allow to receive probe requests */
> +		rfilt = ath_calcrxfilter(sc);
> +		rfilt |= ATH9K_RX_FILTER_PROBEREQ;
I think ath_calcrxfilter should set this, otherwise it might be
overwritten, e.g. on BB watchdog reset.

- Felix

WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@openwrt.org>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>,
	linux-wireless@vger.kernel.org
Cc: ath9k-devel@venema.h4ckr.net, c_manoha@qca.qualcomm.com
Subject: Re: [RFC] ath9k: allow to receive probe request when offchannel
Date: Mon, 15 Jun 2015 13:46:55 +0200	[thread overview]
Message-ID: <557EBB2F.8000503@openwrt.org> (raw)
In-Reply-To: <1433912583-15918-1-git-send-email-janusz.dziedzic@tieto.com>

On 2015-06-10 07:03, Janusz Dziedzic wrote:
> This fix problem that p2p group negotiation didn't work
> correctly when chanctx used, because we didn't receive
> probe requests when offchannel and use_chanctx=1
> 
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
> ---
> @Felix, Sujith could you review? I am not sure I put this in correct place.
> 
>  drivers/net/wireless/ath/ath9k/channel.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/channel.c b/drivers/net/wireless/ath/ath9k/channel.c
> index 2066650..6301d44 100644
> --- a/drivers/net/wireless/ath/ath9k/channel.c
> +++ b/drivers/net/wireless/ath/ath9k/channel.c
> @@ -1157,6 +1157,7 @@ static bool ath_chanctx_defer_switch(struct ath_softc *sc)
>  static void ath_offchannel_channel_change(struct ath_softc *sc)
>  {
>  	struct ath_common *common = ath9k_hw_common(sc->sc_ah);
> +	u32 rfilt;
>  
>  	ath_dbg(common, CHAN_CTX, "%s: offchannel state: %s\n",
>  		__func__, offchannel_state_string(sc->offchannel.state));
> @@ -1179,6 +1180,11 @@ static void ath_offchannel_channel_change(struct ath_softc *sc)
>  		ath_scan_complete(sc, false);
>  		break;
>  	case ATH_OFFCHANNEL_ROC_START:
> +		/* Allow to receive probe requests */
> +		rfilt = ath_calcrxfilter(sc);
> +		rfilt |= ATH9K_RX_FILTER_PROBEREQ;
I think ath_calcrxfilter should set this, otherwise it might be
overwritten, e.g. on BB watchdog reset.

- Felix

  parent reply	other threads:[~2015-06-15 11:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10  5:03 [ath9k-devel] [RFC] ath9k: allow to receive probe request when offchannel Janusz Dziedzic
2015-06-10  5:03 ` Janusz Dziedzic
2015-06-15 11:39 ` [ath9k-devel] " Janusz Dziedzic
2015-06-15 11:39   ` Janusz Dziedzic
2015-06-15 12:25   ` [ath9k-devel] " Sujith Manoharan
2015-06-15 12:25     ` Sujith Manoharan
2015-06-15 11:46 ` Felix Fietkau [this message]
2015-06-15 11:46   ` Felix Fietkau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557EBB2F.8000503@openwrt.org \
    --to=nbd@openwrt.org \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.