From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>
Subject: Re: [PATCH v2 2/6] gnttab: limit mapcount() looping
Date: Mon, 15 Jun 2015 14:20:14 +0100 [thread overview]
Message-ID: <557ED10E.7040805@citrix.com> (raw)
In-Reply-To: <557EE0810200007800084CB8@mail.emea.novell.com>
On 15/06/15 13:26, Jan Beulich wrote:
> The function doesn't need to return counts in the first place; all its
> callers are after is whether at least one entry of a certain kind
> exists. With that there's no point for that loop to continue once the
> looked for condition was found to be met by one entry. Rename the
> function to match the changed behavior.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
next prev parent reply other threads:[~2015-06-15 13:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 12:14 [PATCH v2 0/6] gnttab: XSA-134 follow-up Jan Beulich
2015-06-15 12:24 ` [PATCH v2 1/6] gnttab: eliminate several explicit version checks Jan Beulich
2015-06-15 13:13 ` Andrew Cooper
2015-06-16 8:43 ` Ian Campbell
2015-06-15 12:26 ` [PATCH v2 2/6] gnttab: limit mapcount() looping Jan Beulich
2015-06-15 13:20 ` Andrew Cooper [this message]
2015-06-16 8:44 ` Ian Campbell
2015-06-15 12:26 ` [PATCH v2 3/6] gnttab: simplify shared entry v1 vs v2 handling Jan Beulich
2015-06-15 13:30 ` Andrew Cooper
2015-06-16 8:46 ` Ian Campbell
2015-06-15 12:27 ` [PATCH v2 4/6] gnttab: simplify page copying/clearing Jan Beulich
2015-06-15 13:34 ` Andrew Cooper
2015-06-16 8:49 ` Ian Campbell
2015-06-15 12:28 ` [PATCH v2 5/6] gnttab: fix/adjust gnttab_transfer() Jan Beulich
2015-06-15 13:37 ` Andrew Cooper
2015-06-16 8:52 ` Ian Campbell
2015-06-15 12:29 ` [PATCH v2 6/6] gnttab: make struct grant_mapping private Jan Beulich
2015-06-15 13:39 ` Andrew Cooper
2015-06-16 8:52 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557ED10E.7040805@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.