From: Ian Campbell <ian.campbell@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Keir Fraser <keir@xen.org>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>
Subject: Re: [PATCH v2 5/6] gnttab: fix/adjust gnttab_transfer()
Date: Tue, 16 Jun 2015 09:52:14 +0100 [thread overview]
Message-ID: <1434444734.13744.54.camel@citrix.com> (raw)
In-Reply-To: <557EE0F50200007800084CE1@mail.emea.novell.com>
On Mon, 2015-06-15 at 13:28 +0100, Jan Beulich wrote:
> - don't update shared entry's frame number for translated domains (as
> MFNs shouldn't be exposed to such guests)
> - for v1 grant table format, force copying of the page also when the
> intended MFN doesn't fit in 32 bits (and the domain isn't translated)
> - fix an apparent off-by-one error (it's unclear to me why commit
> 5cc77f9098 ("32-on-64: Fix domain address-size clamping, implement")
> uses BITS_PER_LONG-1 here, while using BITS_PER_LONG in the two other
> invocations of domain_clamp_alloc_bitsize())
> - adjust comments accompanying the shared entry's frame field
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2015-06-16 8:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 12:14 [PATCH v2 0/6] gnttab: XSA-134 follow-up Jan Beulich
2015-06-15 12:24 ` [PATCH v2 1/6] gnttab: eliminate several explicit version checks Jan Beulich
2015-06-15 13:13 ` Andrew Cooper
2015-06-16 8:43 ` Ian Campbell
2015-06-15 12:26 ` [PATCH v2 2/6] gnttab: limit mapcount() looping Jan Beulich
2015-06-15 13:20 ` Andrew Cooper
2015-06-16 8:44 ` Ian Campbell
2015-06-15 12:26 ` [PATCH v2 3/6] gnttab: simplify shared entry v1 vs v2 handling Jan Beulich
2015-06-15 13:30 ` Andrew Cooper
2015-06-16 8:46 ` Ian Campbell
2015-06-15 12:27 ` [PATCH v2 4/6] gnttab: simplify page copying/clearing Jan Beulich
2015-06-15 13:34 ` Andrew Cooper
2015-06-16 8:49 ` Ian Campbell
2015-06-15 12:28 ` [PATCH v2 5/6] gnttab: fix/adjust gnttab_transfer() Jan Beulich
2015-06-15 13:37 ` Andrew Cooper
2015-06-16 8:52 ` Ian Campbell [this message]
2015-06-15 12:29 ` [PATCH v2 6/6] gnttab: make struct grant_mapping private Jan Beulich
2015-06-15 13:39 ` Andrew Cooper
2015-06-16 8:52 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434444734.13744.54.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.