From: Guenter Roeck <linux@roeck-us.net>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Frederic Danis <frederic.danis@linux.intel.com>,
BlueZ development <linux-bluetooth@vger.kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup'
Date: Mon, 15 Jun 2015 07:25:09 -0700 [thread overview]
Message-ID: <557EE045.2090503@roeck-us.net> (raw)
In-Reply-To: <7CF3D545-DAE4-4510-9726-5D40740DDC5D@holtmann.org>
On 06/15/2015 06:58 AM, Marcel Holtmann wrote:
> Hi Guenter,
>
>> alpha:allmodconfig fails to build in -next with
>>
>> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
>> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared
>>
>> BOTHER is not defined for all architectures and otherwise only
>> used with '#ifdef BOTHER'.
>
> thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures.
>
So far it has been fixed with #ifdef, and this is the first code which
uses it outside drivers/tty. So my first tendency would be to fix it
on the user side.
However, looking into it, I think only alpha and avr32 are affected.
Let me submit patches against those and see where it goes.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
To: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Frederic Danis
<frederic.danis-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
BlueZ development
<linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup'
Date: Mon, 15 Jun 2015 07:25:09 -0700 [thread overview]
Message-ID: <557EE045.2090503@roeck-us.net> (raw)
In-Reply-To: <7CF3D545-DAE4-4510-9726-5D40740DDC5D-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
On 06/15/2015 06:58 AM, Marcel Holtmann wrote:
> Hi Guenter,
>
>> alpha:allmodconfig fails to build in -next with
>>
>> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
>> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared
>>
>> BOTHER is not defined for all architectures and otherwise only
>> used with '#ifdef BOTHER'.
>
> thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures.
>
So far it has been fixed with #ifdef, and this is the first code which
uses it outside drivers/tty. So my first tendency would be to fix it
on the user side.
However, looking into it, I think only alpha and avr32 are affected.
Let me submit patches against those and see where it goes.
Guenter
next prev parent reply other threads:[~2015-06-15 14:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 13:50 Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup' Guenter Roeck
2015-06-15 13:58 ` Marcel Holtmann
2015-06-15 13:58 ` Marcel Holtmann
2015-06-15 14:25 ` Guenter Roeck [this message]
2015-06-15 14:25 ` Guenter Roeck
2015-06-15 14:38 ` Ilya Faenson
2015-06-15 14:38 ` Ilya Faenson
2015-06-15 14:38 ` Ilya Faenson
2015-06-15 14:43 ` Marcel Holtmann
2015-06-15 16:51 ` Ilya Faenson
2015-06-15 16:51 ` Ilya Faenson
2015-06-15 16:51 ` Ilya Faenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557EE045.2090503@roeck-us.net \
--to=linux@roeck-us.net \
--cc=frederic.danis@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.