All of lore.kernel.org
 help / color / mirror / Atom feed
From: Georgi Djakov <georgi.djakov@linaro.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: sboyd@codeaurora.org, agross@codeaurora.org,
	mturquette@linaro.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 4/5] clk: qcom: Add A53 clock driver
Date: Mon, 15 Jun 2015 18:36:11 +0300	[thread overview]
Message-ID: <557EF0EB.9040403@linaro.org> (raw)
In-Reply-To: <1434376712.2069.5.camel@x220>

On 06/15/2015 04:58 PM, Paul Bolle wrote:
> On Fri, 2015-06-12 at 11:41 +0300, Georgi Djakov wrote:
>> --- /dev/null
>> +++ b/drivers/clk/qcom/clk-a53.c
> 
>> +static int __init qcom_a53_init(void)
>> +{
>> +	return platform_driver_register(&qcom_a53_driver);
>> +}
>> +arch_initcall(qcom_a53_init);
> 
> There's no function that's, well, called by module_exit() that undoes
> the above. So one can build this as a module, load that module, but not
> unload it. That's by design?
> 
> 

In general, it is not expected to unload it as this is for the
main CPU clock, but i will add a module_exit() call to make it
correct. Thanks for the comment!

BR,
Georgi

  reply	other threads:[~2015-06-15 15:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12  8:41 [PATCH 0/5] Add support for A53 CPU clock Georgi Djakov
2015-06-12  8:41 ` [PATCH 1/5] clk: qcom: Add support for SR2 PLLs Georgi Djakov
2015-07-06 22:15   ` Stephen Boyd
2015-06-12  8:41 ` [PATCH 2/5] clk: Add safe switch hook Georgi Djakov
2015-06-12  8:41 ` [PATCH 3/5] clk: qcom: Add support for regmap mux-div clocks Georgi Djakov
2015-06-12  8:41 ` [PATCH 4/5] clk: qcom: Add A53 clock driver Georgi Djakov
2015-06-15 13:58   ` Paul Bolle
2015-06-15 15:36     ` Georgi Djakov [this message]
2015-06-16  7:14       ` Paul Bolle
2015-06-12  8:41 ` [PATCH 5/5] arm64: dts: qcom: msm8916: Add A53 DT node Georgi Djakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557EF0EB.9040403@linaro.org \
    --to=georgi.djakov@linaro.org \
    --cc=agross@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=pebolle@tiscali.nl \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.