[PATCH] sched/deadline: remove needless parameter in dl_runtime_exceeded()

[PATCH] sched/deadline: remove needless parameter in dl_runtime_exceeded()

[Zhiqiang Zhang]

Sine commit 269ad80(sched/deadline: Avoid double-accounting in
case of missed deadlines), parameter rq is no longer used, so
remove it.

Signed-off-by: Zhiqiang Zhang <zhangzhiqiang.zhang@huawei.com>
---
 kernel/sched/deadline.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 5e95145..437ecdc 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -640,7 +640,7 @@ void init_dl_task_timer(struct sched_dl_entity *dl_se)
 }
 
 static
-int dl_runtime_exceeded(struct rq *rq, struct sched_dl_entity *dl_se)
+int dl_runtime_exceeded(struct sched_dl_entity *dl_se)
 {
 	return (dl_se->runtime <= 0);
 }
@@ -684,7 +684,7 @@ static void update_curr_dl(struct rq *rq)
 	sched_rt_avg_update(rq, delta_exec);
 
 	dl_se->runtime -= dl_se->dl_yielded ? 0 : delta_exec;
-	if (dl_runtime_exceeded(rq, dl_se)) {
+	if (dl_runtime_exceeded(dl_se)) {
 		dl_se->dl_throttled = 1;
 		__dequeue_task_dl(rq, curr, 0);
 		if (unlikely(!start_dl_timer(dl_se, curr->dl.dl_boosted)))
-- 
1.9.0

Re: [PATCH] sched/deadline: remove needless parameter in dl_runtime_exceeded()

[Luca Abeni]

Hello,

On 06/15/2015 05:15 AM, Zhiqiang Zhang wrote:
> Sine commit 269ad80(sched/deadline: Avoid double-accounting in
> case of missed deadlines), parameter rq is no longer used, so
> remove it.
I do not know if other people have plans to use this "rq" parameter,
but the patch looks ok to me.


			Thanks,
				Luca


>
> Signed-off-by: Zhiqiang Zhang <zhangzhiqiang.zhang@huawei.com>
> ---
>   kernel/sched/deadline.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 5e95145..437ecdc 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -640,7 +640,7 @@ void init_dl_task_timer(struct sched_dl_entity *dl_se)
>   }
>
>   static
> -int dl_runtime_exceeded(struct rq *rq, struct sched_dl_entity *dl_se)
> +int dl_runtime_exceeded(struct sched_dl_entity *dl_se)
>   {
>   	return (dl_se->runtime <= 0);
>   }
> @@ -684,7 +684,7 @@ static void update_curr_dl(struct rq *rq)
>   	sched_rt_avg_update(rq, delta_exec);
>
>   	dl_se->runtime -= dl_se->dl_yielded ? 0 : delta_exec;
> -	if (dl_runtime_exceeded(rq, dl_se)) {
> +	if (dl_runtime_exceeded(dl_se)) {
>   		dl_se->dl_throttled = 1;
>   		__dequeue_task_dl(rq, curr, 0);
>   		if (unlikely(!start_dl_timer(dl_se, curr->dl.dl_boosted)))
>

[tip:sched/core] sched/deadline: Remove needless parameter in dl_runtime_exceeded()

[tip-bot for Zhiqiang Zhang]

Commit-ID:  6fab54101923044712baee429ff573f03b99fc47
Gitweb:     http://git.kernel.org/tip/6fab54101923044712baee429ff573f03b99fc47
Author:     Zhiqiang Zhang <zhangzhiqiang.zhang@huawei.com>
AuthorDate: Mon, 15 Jun 2015 11:15:20 +0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 19 Jun 2015 10:06:48 +0200

sched/deadline: Remove needless parameter in dl_runtime_exceeded()

Sine commit 269ad8015a6b ("sched/deadline: Avoid double-accounting in
case of missed deadlines), parameter 'rq' is no longer used, so
remove it.

Signed-off-by: Zhiqiang Zhang <zhangzhiqiang.zhang@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: <juri.lelli@gmail.com>
Cc: <luca.abeni@unitn.it>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1434338120-43773-1-git-send-email-zhangzhiqiang.zhang@huawei.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/deadline.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 98f7871..392e8fb 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -640,7 +640,7 @@ void init_dl_task_timer(struct sched_dl_entity *dl_se)
 }
 
 static
-int dl_runtime_exceeded(struct rq *rq, struct sched_dl_entity *dl_se)
+int dl_runtime_exceeded(struct sched_dl_entity *dl_se)
 {
 	return (dl_se->runtime <= 0);
 }
@@ -684,7 +684,7 @@ static void update_curr_dl(struct rq *rq)
 	sched_rt_avg_update(rq, delta_exec);
 
 	dl_se->runtime -= dl_se->dl_yielded ? 0 : delta_exec;
-	if (dl_runtime_exceeded(rq, dl_se)) {
+	if (dl_runtime_exceeded(dl_se)) {
 		dl_se->dl_throttled = 1;
 		__dequeue_task_dl(rq, curr, 0);
 		if (unlikely(!start_dl_timer(dl_se, curr->dl.dl_boosted)))
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/