From: Antonio Quartulli <antonio@meshcoding.com>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Cc: Marek Lindner <mareklindner@neomailbox.ch>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: protect tt_local_entry from concurrent delete events
Date: Wed, 17 Jun 2015 14:36:21 +0200 [thread overview]
Message-ID: <558169C5.7050700@meshcoding.com> (raw)
In-Reply-To: <1434542995-22376-1-git-send-email-mareklindner@neomailbox.ch>
[-- Attachment #1: Type: text/plain, Size: 610 bytes --]
On 17/06/15 14:09, Marek Lindner wrote:
> The tt_local_entry deletion performed batadv_tt_local_remove() was neither
> protecting against simultaneous deletes nor checking whether the element
> was still part of the list before calling hlist_del_rcu().
>
> Replacing the hlist_del_rcu() with batadv_hash_remove() provides adequate
> protection via hash spinlocks as well as a is-element-still-in-hash check.
>
> Reported-by: alfonsname@web.de
> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Acked-by: Antonio Quartulli <antonio@meshcoding.com>
Thanks!
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-06-17 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 12:09 [B.A.T.M.A.N.] [PATCH] batman-adv: protect tt_local_entry from concurrent delete events Marek Lindner
2015-06-17 12:36 ` Antonio Quartulli [this message]
2015-06-17 15:24 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558169C5.7050700@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.