From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Bryan Wu <cooloney@gmail.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Richard Purdie <rpurdie@rpsys.net>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [next:master 11893/11947] drivers/leds/leds-aat1290.c:397:21: sparse: symbol 'aat1290_intensity_to_brightness' was not declared. Should it be static?
Date: Wed, 17 Jun 2015 17:21:58 +0200 [thread overview]
Message-ID: <55819096.1020208@samsung.com> (raw)
In-Reply-To: <201506171403.akc8Fj4R%fengguang.wu@intel.com>
On 06/17/2015 08:56 AM, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: ca3cfaa9e7db530b14e4a2d98a9310130152fdb8
> commit: 1da60a5e7198c716990ac6fa508e45e27e7067c0 [11893/11947] Merge remote-tracking branch 'leds/for-next'
> reproduce:
> # apt-get install sparse
> git checkout 1da60a5e7198c716990ac6fa508e45e27e7067c0
> make ARCH=x86_64 allmodconfig
> make C=1 CF=-D__CHECK_ENDIAN__
>
>
> sparse warnings: (new ones prefixed by >>)
>
> drivers/leds/leds-aat1290.c:334:5: sparse: symbol 'init_mm_current_scale' was not declared. Should it be static?
>>> drivers/leds/leds-aat1290.c:397:21: sparse: symbol 'aat1290_intensity_to_brightness' was not declared. Should it be static?
>>> drivers/leds/leds-aat1290.c:412:5: sparse: symbol 'aat1290_brightness_to_intensity' was not declared. Should it be static?
>
> Please review and possibly fold the followup patch.
These should be statics. I'll send fixed patches tomorrow.
--
Best Regards,
Jacek Anaszewski
prev parent reply other threads:[~2015-06-17 15:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 6:56 [next:master 11893/11947] drivers/leds/leds-aat1290.c:397:21: sparse: symbol 'aat1290_intensity_to_brightness' was not declared. Should it be static? kbuild test robot
2015-06-17 6:56 ` [PATCH next] Merge remote-tracking branch 'leds/for-next':: aat1290_intensity_to_brightness() can be static kbuild test robot
2015-06-17 15:21 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55819096.1020208@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=cooloney@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.