All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net/macb: add config for Atmel sama5d2 SoCs
Date: Thu, 18 Jun 2015 16:22:44 +0200	[thread overview]
Message-ID: <5582D434.7030906@atmel.com> (raw)
In-Reply-To: <20150618133022.GD27492@piout.net>

Le 18/06/2015 15:30, Alexandre Belloni a ?crit :
> On 18/06/2015 at 12:18:19 +0200, Nicolas Ferre wrote :
>> From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>>
>> Add the compatible string for Atmel sama5d2 SoC family as the configuration
>> options differ from other instances of the GEM.
>>
>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>> ---
>>  drivers/net/ethernet/cadence/macb.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
>> index 740d04fd2223..caeb39561567 100644
>> --- a/drivers/net/ethernet/cadence/macb.c
>> +++ b/drivers/net/ethernet/cadence/macb.c
>> @@ -2713,6 +2713,13 @@ static const struct macb_config pc302gem_config = {
>>  	.init = macb_init,
>>  };
>>  
>> +static const struct macb_config sama5d2_config = {
>> +	.caps = 0,
>> +	.dma_burst_length = 16,
>> +	.clk_init = macb_clk_init,
>> +	.init = macb_init,
>> +};
>> +
>>  static const struct macb_config sama5d3_config = {
>>  	.caps = MACB_CAPS_SG_DISABLED | MACB_CAPS_GIGABIT_MODE_AVAILABLE,
>>  	.dma_burst_length = 16,
>> @@ -2756,6 +2763,7 @@ static const struct of_device_id macb_dt_ids[] = {
>>  	{ .compatible = "cdns,macb" },
>>  	{ .compatible = "cdns,pc302-gem", .data = &pc302gem_config },
>>  	{ .compatible = "cdns,gem", .data = &pc302gem_config },
>> +	{ .compatible = "atmel,sama5d2-gem", .data = &sama5d2_config },
> 
> This compatible has to be documented

Sure, I re-send a series right now (and add some documentation fixes).

Thanks, bye,

> 
>>  	{ .compatible = "atmel,sama5d3-gem", .data = &sama5d3_config },
>>  	{ .compatible = "atmel,sama5d4-gem", .data = &sama5d4_config },
>>  	{ .compatible = "cdns,at91rm9200-emac", .data = &emac_config },
>> -- 
>> 2.1.3
>>
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Boris BREZILLON <boris.brezillon@free-electrons.com>,
	Cyrille Pitchen <cyrille.pitchen@atmel.com>
Subject: Re: [PATCH] net/macb: add config for Atmel sama5d2 SoCs
Date: Thu, 18 Jun 2015 16:22:44 +0200	[thread overview]
Message-ID: <5582D434.7030906@atmel.com> (raw)
In-Reply-To: <20150618133022.GD27492@piout.net>

Le 18/06/2015 15:30, Alexandre Belloni a écrit :
> On 18/06/2015 at 12:18:19 +0200, Nicolas Ferre wrote :
>> From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>>
>> Add the compatible string for Atmel sama5d2 SoC family as the configuration
>> options differ from other instances of the GEM.
>>
>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>> ---
>>  drivers/net/ethernet/cadence/macb.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
>> index 740d04fd2223..caeb39561567 100644
>> --- a/drivers/net/ethernet/cadence/macb.c
>> +++ b/drivers/net/ethernet/cadence/macb.c
>> @@ -2713,6 +2713,13 @@ static const struct macb_config pc302gem_config = {
>>  	.init = macb_init,
>>  };
>>  
>> +static const struct macb_config sama5d2_config = {
>> +	.caps = 0,
>> +	.dma_burst_length = 16,
>> +	.clk_init = macb_clk_init,
>> +	.init = macb_init,
>> +};
>> +
>>  static const struct macb_config sama5d3_config = {
>>  	.caps = MACB_CAPS_SG_DISABLED | MACB_CAPS_GIGABIT_MODE_AVAILABLE,
>>  	.dma_burst_length = 16,
>> @@ -2756,6 +2763,7 @@ static const struct of_device_id macb_dt_ids[] = {
>>  	{ .compatible = "cdns,macb" },
>>  	{ .compatible = "cdns,pc302-gem", .data = &pc302gem_config },
>>  	{ .compatible = "cdns,gem", .data = &pc302gem_config },
>> +	{ .compatible = "atmel,sama5d2-gem", .data = &sama5d2_config },
> 
> This compatible has to be documented

Sure, I re-send a series right now (and add some documentation fixes).

Thanks, bye,

> 
>>  	{ .compatible = "atmel,sama5d3-gem", .data = &sama5d3_config },
>>  	{ .compatible = "atmel,sama5d4-gem", .data = &sama5d4_config },
>>  	{ .compatible = "cdns,at91rm9200-emac", .data = &emac_config },
>> -- 
>> 2.1.3
>>
> 


-- 
Nicolas Ferre

  reply	other threads:[~2015-06-18 14:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18 10:18 [PATCH] net/macb: add config for Atmel sama5d2 SoCs Nicolas Ferre
2015-06-18 10:18 ` Nicolas Ferre
2015-06-18 13:30 ` Alexandre Belloni
2015-06-18 13:30   ` Alexandre Belloni
2015-06-18 14:22   ` Nicolas Ferre [this message]
2015-06-18 14:22     ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5582D434.7030906@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.