* [PATCH] NVMe: Remove the redundant sg_mar_end()
@ 2015-06-18 11:22 Yijing Wang
2015-06-18 15:04 ` Keith Busch
0 siblings, 1 reply; 3+ messages in thread
From: Yijing Wang @ 2015-06-18 11:22 UTC (permalink / raw)
sg_init_table() already called sg_mark_end(),
remove the redundant one.
Signed-off-by: Yijing Wang <wangyijing at huawei.com>
---
drivers/block/nvme-core.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index 683dff2..f099275 100644
--- a/drivers/block/nvme-core.c
+++ b/drivers/block/nvme-core.c
@@ -1708,7 +1708,6 @@ struct nvme_iod *nvme_map_user_pages(struct nvme_dev *dev, int write,
length -= (PAGE_SIZE - offset);
offset = 0;
}
- sg_mark_end(&sg[i - 1]);
iod->nents = count;
nents = dma_map_sg(&dev->pci_dev->dev, sg, count,
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] NVMe: Remove the redundant sg_mar_end()
2015-06-18 11:22 [PATCH] NVMe: Remove the redundant sg_mar_end() Yijing Wang
@ 2015-06-18 15:04 ` Keith Busch
2015-06-19 1:19 ` Yijing Wang
0 siblings, 1 reply; 3+ messages in thread
From: Keith Busch @ 2015-06-18 15:04 UTC (permalink / raw)
On Thu, 18 Jun 2015, Yijing Wang wrote:
> sg_init_table() already called sg_mark_end(),
> remove the redundant one.
Your repository must be pointing to an older branch. This function doesn't
exist in the most current driver staged in the linux-block/for-next tree.
> @@ -1708,7 +1708,6 @@ struct nvme_iod *nvme_map_user_pages(struct nvme_dev *dev, int write,
> length -= (PAGE_SIZE - offset);
> offset = 0;
> }
> - sg_mark_end(&sg[i - 1]);
> iod->nents = count;
>
> nents = dma_map_sg(&dev->pci_dev->dev, sg, count,
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] NVMe: Remove the redundant sg_mar_end()
2015-06-18 15:04 ` Keith Busch
@ 2015-06-19 1:19 ` Yijing Wang
0 siblings, 0 replies; 3+ messages in thread
From: Yijing Wang @ 2015-06-19 1:19 UTC (permalink / raw)
On 2015/6/18 23:04, Keith Busch wrote:
> On Thu, 18 Jun 2015, Yijing Wang wrote:
>> sg_init_table() already called sg_mark_end(),
>> remove the redundant one.
>
> Your repository must be pointing to an older branch. This function doesn't
> exist in the most current driver staged in the linux-block/for-next tree.
Sorry, my repository is linus's master branch, this code has been removed in latest nvme-core.c, please drop this patch.
Thanks!
Yijing.
>
>> @@ -1708,7 +1708,6 @@ struct nvme_iod *nvme_map_user_pages(struct nvme_dev *dev, int write,
>> length -= (PAGE_SIZE - offset);
>> offset = 0;
>> }
>> - sg_mark_end(&sg[i - 1]);
>> iod->nents = count;
>>
>> nents = dma_map_sg(&dev->pci_dev->dev, sg, count,
>
>
--
Thanks!
Yijing
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-19 1:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-18 11:22 [PATCH] NVMe: Remove the redundant sg_mar_end() Yijing Wang
2015-06-18 15:04 ` Keith Busch
2015-06-19 1:19 ` Yijing Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.