[Intel-wired-lan] [PATCH] fm10k: Report MAC address on driver load

[Intel-wired-lan] [PATCH] fm10k: Report MAC address on driver load

[Alexander Duyck]

This change adds the MAC address to the list of values recorded on driver
load.  The MAC address represents the serial number of the unit and allows
us to track the value should a card be replaced in a system.

Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
---
 drivers/net/ethernet/intel/fm10k/fm10k_pci.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
index df9fda38bdd1..5db41ab3b762 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
@@ -1837,7 +1837,7 @@ static int fm10k_probe(struct pci_dev *pdev,
 	fm10k_ptp_register(interface);
 
 	/* print bus type/speed/width info */
-	dev_info(&pdev->dev, "(PCI Express:%s Width: %s Payload: %s)\n",
+	dev_info(&pdev->dev, "(PCI Express:%s Width: %s Payload: %s) %pM\n",
 		 (hw->bus.speed == fm10k_bus_speed_8000 ? "8.0GT/s" :
 		  hw->bus.speed == fm10k_bus_speed_5000 ? "5.0GT/s" :
 		  hw->bus.speed == fm10k_bus_speed_2500 ? "2.5GT/s" :
@@ -1849,7 +1849,7 @@ static int fm10k_probe(struct pci_dev *pdev,
 		 (hw->bus.payload == fm10k_bus_payload_128 ? "128B" :
 		  hw->bus.payload == fm10k_bus_payload_256 ? "256B" :
 		  hw->bus.payload == fm10k_bus_payload_512 ? "512B" :
-		  "Unknown"));
+		  "Unknown"), netdev->dev_addr);
 
 	/* print warning for non-optimal configurations */
 	fm10k_slot_warn(interface);

[PATCH] fm10k: Report MAC address on driver load

[Alexander Duyck]

This change adds the MAC address to the list of values recorded on driver
load.  The MAC address represents the serial number of the unit and allows
us to track the value should a card be replaced in a system.

Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
---
 drivers/net/ethernet/intel/fm10k/fm10k_pci.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
index df9fda38bdd1..5db41ab3b762 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
@@ -1837,7 +1837,7 @@ static int fm10k_probe(struct pci_dev *pdev,
 	fm10k_ptp_register(interface);
 
 	/* print bus type/speed/width info */
-	dev_info(&pdev->dev, "(PCI Express:%s Width: %s Payload: %s)\n",
+	dev_info(&pdev->dev, "(PCI Express:%s Width: %s Payload: %s) %pM\n",
 		 (hw->bus.speed == fm10k_bus_speed_8000 ? "8.0GT/s" :
 		  hw->bus.speed == fm10k_bus_speed_5000 ? "5.0GT/s" :
 		  hw->bus.speed == fm10k_bus_speed_2500 ? "2.5GT/s" :
@@ -1849,7 +1849,7 @@ static int fm10k_probe(struct pci_dev *pdev,
 		 (hw->bus.payload == fm10k_bus_payload_128 ? "128B" :
 		  hw->bus.payload == fm10k_bus_payload_256 ? "256B" :
 		  hw->bus.payload == fm10k_bus_payload_512 ? "512B" :
-		  "Unknown"));
+		  "Unknown"), netdev->dev_addr);
 
 	/* print warning for non-optimal configurations */
 	fm10k_slot_warn(interface);

[Intel-wired-lan] [PATCH] fm10k: Report MAC address on driver load

[Jeff Kirsher]

On Wed, 2015-06-17 at 20:12 -0700, Alexander Duyck wrote:
> This change adds the MAC address to the list of values recorded on
> driver
> load.  The MAC address represents the serial number of the unit and
> allows
> us to track the value should a card be replaced in a system.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
> ---
>  drivers/net/ethernet/intel/fm10k/fm10k_pci.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks Alex, I will get this added to my queue.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20150618/33f34292/attachment.asc>

Re: [PATCH] fm10k: Report MAC address on driver load

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

On Wed, 2015-06-17 at 20:12 -0700, Alexander Duyck wrote:
> This change adds the MAC address to the list of values recorded on
> driver
> load.  The MAC address represents the serial number of the unit and
> allows
> us to track the value should a card be replaced in a system.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
> ---
>  drivers/net/ethernet/intel/fm10k/fm10k_pci.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks Alex, I will get this added to my queue.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[Intel-wired-lan] [PATCH] fm10k: Report MAC address on driver load

[Jeff Kirsher]

On Wed, 2015-06-17 at 20:12 -0700, Alexander Duyck wrote:
> This change adds the MAC address to the list of values recorded on
> driver
> load.  The MAC address represents the serial number of the unit and
> allows
> us to track the value should a card be replaced in a system.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
> ---
>  drivers/net/ethernet/intel/fm10k/fm10k_pci.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

With the recent fm10k patches that Jake submitted, this patch no longer
applies cleanly.  If you could re-spin your patch against my next-queue
tree (dev-queue branch) that would be much appreciated.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20150618/b6dd496c/attachment.asc>

Re: [PATCH] fm10k: Report MAC address on driver load

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

On Wed, 2015-06-17 at 20:12 -0700, Alexander Duyck wrote:
> This change adds the MAC address to the list of values recorded on
> driver
> load.  The MAC address represents the serial number of the unit and
> allows
> us to track the value should a card be replaced in a system.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
> ---
>  drivers/net/ethernet/intel/fm10k/fm10k_pci.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

With the recent fm10k patches that Jake submitted, this patch no longer
applies cleanly.  If you could re-spin your patch against my next-queue
tree (dev-queue branch) that would be much appreciated.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[Intel-wired-lan] [PATCH] fm10k: Report MAC address on driver load

[Alexander Duyck]

On 06/18/2015 04:49 PM, Jeff Kirsher wrote:
> On Wed, 2015-06-17 at 20:12 -0700, Alexander Duyck wrote:
>> This change adds the MAC address to the list of values recorded on
>> driver
>> load.  The MAC address represents the serial number of the unit and
>> allows
>> us to track the value should a card be replaced in a system.
>>
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
>> ---
>>   drivers/net/ethernet/intel/fm10k/fm10k_pci.c |    4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
> With the recent fm10k patches that Jake submitted, this patch no longer
> applies cleanly.  If you could re-spin your patch against my next-queue
> tree (dev-queue branch) that would be much appreciated.

I should have a new patch for you in 20 minutes or so.  Just waiting on 
the build to finish and then I'll give it a quick test.

- Alex

Re: [Intel-wired-lan] [PATCH] fm10k: Report MAC address on driver load

[Alexander Duyck]

On 06/18/2015 04:49 PM, Jeff Kirsher wrote:
> On Wed, 2015-06-17 at 20:12 -0700, Alexander Duyck wrote:
>> This change adds the MAC address to the list of values recorded on
>> driver
>> load.  The MAC address represents the serial number of the unit and
>> allows
>> us to track the value should a card be replaced in a system.
>>
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
>> ---
>>   drivers/net/ethernet/intel/fm10k/fm10k_pci.c |    4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
> With the recent fm10k patches that Jake submitted, this patch no longer
> applies cleanly.  If you could re-spin your patch against my next-queue
> tree (dev-queue branch) that would be much appreciated.

I should have a new patch for you in 20 minutes or so.  Just waiting on 
the build to finish and then I'll give it a quick test.

- Alex