From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
Andreas Faerber <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules
Date: Fri, 19 Jun 2015 09:55:03 +0200 [thread overview]
Message-ID: <5583CAD7.8010503@redhat.com> (raw)
In-Reply-To: <20150619095359.1bda48e4@thh440s>
On 19/06/2015 09:53, Thomas Huth wrote:
> > - WARN("line over 80 characters\n" . $herecurr);
> > + if ($length > 90) {
> > + ERROR("line over 90 characters\n" . $herecurr);
> > + } if ($length > 80) {
>
> Did you mean to use "elsif" here instead (because you've put the if on
> the same line as the "}")?
Yes, and this patch was really meant as little more than RFC.
Paolo
next prev parent reply other threads:[~2015-06-19 7:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 7:29 [Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules Paolo Bonzini
2015-06-19 7:53 ` Thomas Huth
2015-06-19 7:55 ` Paolo Bonzini [this message]
2015-06-19 8:09 ` Andreas Färber
2015-06-19 8:38 ` Paolo Bonzini
2015-08-25 18:20 ` Markus Armbruster
2015-08-25 19:22 ` John Snow
2015-08-26 8:27 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5583CAD7.8010503@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.