Re: [Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules

[Paolo Bonzini <pbonzini@redhat.com>]

On 19/06/2015 10:09, Andreas Färber wrote:
>> > -Lines are 80 characters; not longer.
>> > +Lines should be 80 characters; try not to make them longer.
>> > +
>> > +Sometimes it is hard to do, especially when dealing with QEMU subsystems
>> > +that use long function or symbol names.  Even in that case, do not make
>> > +lines _much_ longer than 80 characters.
> Anthony had always allowed sensible exceptions to that rule, so +1 for
> reformulating it here.
> 
> However, I would suggest that in that case we should lower the
> recommendation/warning to 78 chars, with the rationale of not only the
> actual code but also two-way diffs (79 chars plus ±/space) and
> three-way diffs (78 chars plus 2x ±/space) fitting into standard 80x24
> windows.

Good idea.

> Either way, can you please decouple the two changes?

Sure, didn't want to spam people with a series on what is mostly an RFC.

Paolo