Re: [review-request] adamian/20150603_remove_managed

[Michael Wood <michael.g.wood@intel.com>]

On 17/06/15 17:37, Damian, Alexandru wrote:
> Hi,
>
> This is the first review request for merging of "managed" and 
> "analysis" modes.
>
> The branch is here:
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/20150603_remove_managed
>
Not that familiar with this part of toaster, but noticed a few things:

Do you know why the migration generated is so large?

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/diff/bitbake/lib/toaster/orm/migrations/0023_auto__del_field_build_warnings_no__del_field_build_errors_no__del_fiel.py?h=adamian/20150603_remove_managed&id=4d25bdde275293cbecfe7d27ac249ac976210bef

Strangely appears to have unmodified tables in there.


You have also pushed these commits so I can't currently test the branch.

commit 3339d75d6bc1bcfdff50969bc49110b632f28f4a
Author: Alexandru DAMIAN <alexandru.damian@intel.com>
Date:   Mon Jun 8 11:10:03 2015 +0100

     debug versions of js libraries

commit b23670f47fc97f7660d6a51f6d6881b94f84d62d
Author: Alexandru DAMIAN <alexandru.damian@intel.com>
Date:   Tue Jun 9 13:42:09 2015 +0100

     enable sentry on icarus.local for debugging

     Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>


Thanks,

Michael

> The major changes are:
>
> - the code paths in templates for "MANAGED" and non-"MANAGED" mode 
> have been merged, with the MANAGED considered always True
> - the interface no longer manipulates BuildRequest objects, only Build 
> objects; this simplifies the searching, displaying and manipulating 
> builds.
> - the toaster logger has improved error logging, as we can now attach 
> correct errors to Builds
> - in the interactive-command-line mode, all builds go by default to 
> the Project with id 0.
>
> What remains to be done is:
>
> - Bring the UI up to the design, including the capability to create 
> analysis-only Projects; and the ability to configure the project ID 
> for interactive command-line builds.
>
> -- 
> Alex Damian
> Yocto Project
> SSG / OTC
>
>