From: Daniel Wagner <daniel.wagner@bmw-carit.de>
To: Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@plumgrid.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Ingo Molnar <mingo@kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH v2] bpf: BPF based latency tracing
Date: Mon, 22 Jun 2015 09:34:18 +0200 [thread overview]
Message-ID: <5587BA7A.6050208@bmw-carit.de> (raw)
In-Reply-To: <558520DB.6000904@iogearbox.net>
On 06/20/2015 10:14 AM, Daniel Borkmann wrote:
> I think it would be useful to perhaps have two options:
>
> 1) User specifies a specific CPU and gets one such an output above.
Good point. Will do.
> 2) Summary view, i.e. to have the samples of each CPU for comparison
> next to each other in columns and maybe the histogram view a bit
> more compressed (perhaps summary of all CPUs).
I agree, the current view is not really optimal. I'll look into this as
well.
Alexei indicated that he is working on per-cpu variables support. I
think that would be extremely useful to drop the hard coded limit of
CPUs and turning this sample code into some more generic code.
> Anyway, it's sample code people can go with and modify individually.
I am interested to turn this code into a more useful tool. Though I
think I miss some background information why this code is kept as
samples. Obviously, there is the API and ARCH dependency. As long as an
API change can reliable be detected I don't see a real show stopper.
Maybe I am too naive. Furthermore I expected that trace_preempt_[on|off]
wont change that often.
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
To: Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@plumgrid.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Ingo Molnar <mingo@kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH v2] bpf: BPF based latency tracing
Date: Mon, 22 Jun 2015 09:34:18 +0200 [thread overview]
Message-ID: <5587BA7A.6050208@bmw-carit.de> (raw)
In-Reply-To: <558520DB.6000904@iogearbox.net>
On 06/20/2015 10:14 AM, Daniel Borkmann wrote:
> I think it would be useful to perhaps have two options:
>
> 1) User specifies a specific CPU and gets one such an output above.
Good point. Will do.
> 2) Summary view, i.e. to have the samples of each CPU for comparison
> next to each other in columns and maybe the histogram view a bit
> more compressed (perhaps summary of all CPUs).
I agree, the current view is not really optimal. I'll look into this as
well.
Alexei indicated that he is working on per-cpu variables support. I
think that would be extremely useful to drop the hard coded limit of
CPUs and turning this sample code into some more generic code.
> Anyway, it's sample code people can go with and modify individually.
I am interested to turn this code into a more useful tool. Though I
think I miss some background information why this code is kept as
samples. Obviously, there is the API and ARCH dependency. As long as an
API change can reliable be detected I don't see a real show stopper.
Maybe I am too naive. Furthermore I expected that trace_preempt_[on|off]
wont change that often.
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Thanks,
Daniel
next prev parent reply other threads:[~2015-06-22 7:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 14:00 [PATCH v2] bpf: BPF based latency tracing Daniel Wagner
2015-06-19 14:00 ` Daniel Wagner
2015-06-20 0:53 ` Alexei Starovoitov
2015-06-20 0:53 ` Alexei Starovoitov
2015-06-23 13:10 ` David Miller
2015-06-20 8:14 ` Daniel Borkmann
2015-06-20 8:14 ` Daniel Borkmann
2015-06-22 7:34 ` Daniel Wagner [this message]
2015-06-22 7:34 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5587BA7A.6050208@bmw-carit.de \
--to=daniel.wagner@bmw-carit.de \
--cc=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.