All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tetsuya Mukawa <mukawa@igel.co.jp>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: jasowang@redhat.com, n.nikolaev@virtualopensystems.com,
	qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/5] vhost-user: Shutdown vhost-user connection when wrong messages are passed
Date: Tue, 23 Jun 2015 17:33:57 +0900	[thread overview]
Message-ID: <558919F5.1090906@igel.co.jp> (raw)
In-Reply-To: <20150622095122-mutt-send-email-mst@redhat.com>

On 2015/06/22 16:54, Michael S. Tsirkin wrote:
> On Mon, Jun 22, 2015 at 12:50:46PM +0900, Tetsuya Mukawa wrote:
>> When wrong vhost-user message are passed, the connection should be shutdown.
>>
>> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> This silently changes the protocol semantics: previously
> unknown messages were ignored. We can't do this.
> See email titled "vhost-user: protocol extensions" which relies on this
> to detect protocol version.
>

Hi Michael,

Thanks for commenting.
Instead of disconnecting the backend, I will add warning message and
leave link status down.

Regards,
Tetsuya

  reply	other threads:[~2015-06-23  8:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-22  3:50 [Qemu-devel] [PATCH v2 0/5] Add feature to start QEMU without vhost-user backend Tetsuya Mukawa
2015-06-22  3:50 ` [Qemu-devel] [PATCH v2 1/5] vhost-user: Add ability to know vhost-user backend disconnection Tetsuya Mukawa
2015-06-22  3:50 ` [Qemu-devel] [PATCH v2 2/5] qemu-char: Add qemu_chr_disconnect to close a fd accepted by listen fd Tetsuya Mukawa
2015-06-22  3:50 ` [Qemu-devel] [PATCH v2 3/5] vhost-user: Shutdown vhost-user connection when wrong messages are passed Tetsuya Mukawa
2015-06-22  7:54   ` Michael S. Tsirkin
2015-06-23  8:33     ` Tetsuya Mukawa [this message]
2015-08-06 17:29   ` Marc-André Lureau
2015-06-22  3:50 ` [Qemu-devel] [PATCH v2 4/5] vhost-user: Enable 'nowait' and 'reconnect' option Tetsuya Mukawa
2015-08-06 17:41   ` Marc-André Lureau
2015-06-22  3:50 ` [Qemu-devel] [PATCH v2 5/5] vhost-user: Add new option to specify vhost-user backend supports Tetsuya Mukawa
2015-08-06 19:11   ` Marc-André Lureau
2015-06-22  8:14 ` [Qemu-devel] [PATCH v2 0/5] Add feature to start QEMU without vhost-user backend Michael S. Tsirkin
2015-06-23  8:31   ` Tetsuya Mukawa
2015-06-23  9:41     ` Michael S. Tsirkin
2015-06-24  5:46       ` Tetsuya Mukawa
2015-06-24  5:57         ` Michael S. Tsirkin
2015-06-24  7:13           ` Tetsuya Mukawa
2015-07-19 12:48           ` Michael S. Tsirkin
2015-07-22  2:44             ` Tetsuya Mukawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558919F5.1090906@igel.co.jp \
    --to=mukawa@igel.co.jp \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=n.nikolaev@virtualopensystems.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.