From: Paolo Bonzini <pbonzini@redhat.com>
To: Andre Przywara <andre.przywara@arm.com>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: Will Deacon <Will.Deacon@arm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
"svaidy@linux.vnet.ibm.com" <svaidy@linux.vnet.ibm.com>,
"matt@ozlabs.org" <matt@ozlabs.org>
Subject: Re: [PATCH 1/2] powerpc: Define the hcall opcodes & return values we need
Date: Tue, 23 Jun 2015 10:33:52 +0000 [thread overview]
Message-ID: <55893610.7050309@redhat.com> (raw)
In-Reply-To: <5589358F.1080606@arm.com>
On 23/06/2015 12:31, Andre Przywara wrote:
>> >
>> > Because it's not part of the kernel API, never was, still isn't.
> Technically it may not - if I get this correctly it is more a platform
> API defined by the architecture, like ACPI or PSCI on ARM.
> But if I get this correctly Linux re-uses those definitions in the KVM
> API, by piggy-backing on the existing hypercalls. Please correct me if I
> am wrong here, I am looking at arch/powerpc/kvm/book3s_hv.c, where it
> seems to trap those hypercalls.
>
> So I think that - though not originally invented or defined by Linux -
> it should export those definitions that KVM (re-)uses.
> QEMU also has a header file duplicating those definitions, so I support
> the idea of an uapi header.
Right, the same is true for other headers: include/scsi/scsi.h and
include/uapi/linux/virtio_*.h come to mind.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Andre Przywara <andre.przywara@arm.com>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: Will Deacon <Will.Deacon@arm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
"svaidy@linux.vnet.ibm.com" <svaidy@linux.vnet.ibm.com>,
"matt@ozlabs.org" <matt@ozlabs.org>
Subject: Re: [PATCH 1/2] powerpc: Define the hcall opcodes & return values we need
Date: Tue, 23 Jun 2015 12:33:52 +0200 [thread overview]
Message-ID: <55893610.7050309@redhat.com> (raw)
In-Reply-To: <5589358F.1080606@arm.com>
On 23/06/2015 12:31, Andre Przywara wrote:
>> >
>> > Because it's not part of the kernel API, never was, still isn't.
> Technically it may not - if I get this correctly it is more a platform
> API defined by the architecture, like ACPI or PSCI on ARM.
> But if I get this correctly Linux re-uses those definitions in the KVM
> API, by piggy-backing on the existing hypercalls. Please correct me if I
> am wrong here, I am looking at arch/powerpc/kvm/book3s_hv.c, where it
> seems to trap those hypercalls.
>
> So I think that - though not originally invented or defined by Linux -
> it should export those definitions that KVM (re-)uses.
> QEMU also has a header file duplicating those definitions, so I support
> the idea of an uapi header.
Right, the same is true for other headers: include/scsi/scsi.h and
include/uapi/linux/virtio_*.h come to mind.
Paolo
next prev parent reply other threads:[~2015-06-23 10:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 7:21 [PATCH 1/2] powerpc: Define the hcall opcodes & return values we need Michael Ellerman
2015-06-19 7:21 ` Michael Ellerman
2015-06-19 7:21 ` [PATCH 2/2] powerpc: Enable 32-bit build Michael Ellerman
2015-06-19 7:21 ` Michael Ellerman
2015-06-19 7:40 ` [PATCH 1/2] powerpc: Define the hcall opcodes & return values we need Michael Ellerman
2015-06-19 7:40 ` Michael Ellerman
2015-06-19 10:35 ` Will Deacon
2015-06-19 10:35 ` Will Deacon
2015-06-23 9:33 ` Paolo Bonzini
2015-06-23 9:33 ` Paolo Bonzini
2015-06-23 10:05 ` Michael Ellerman
2015-06-23 10:05 ` Michael Ellerman
2015-06-23 10:31 ` Andre Przywara
2015-06-23 10:31 ` Andre Przywara
2015-06-23 10:33 ` Paolo Bonzini [this message]
2015-06-23 10:33 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55893610.7050309@redhat.com \
--to=pbonzini@redhat.com \
--cc=Will.Deacon@arm.com \
--cc=andre.przywara@arm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=matt@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=svaidy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.