All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Wolfgang Bumiller <w.bumiller@proxmox.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [PULL 00/21] Trivial patches for 2015-06-22
Date: Tue, 23 Jun 2015 20:08:33 +0300	[thread overview]
Message-ID: <55899291.306@msgid.tls.msk.ru> (raw)
In-Reply-To: <CAFEAcA9ru4tyzXNUW0USsN13wEP4v5hGOREbPZWVOkrLDS41=Q@mail.gmail.com>

22.06.2015 19:02, Peter Maydell wrote:

> Fails to build on Windows:
> 
> util/qemu-sockets.c: In function ‘inet_parse_connect_opts’:
> util/qemu-sockets.c:338: error: ‘AI_V4MAPPED’ undeclared (first use in this function)

Hmm.  Does WIN really have no AI_V4MAPPED?  Does it have getaddrinfo
in the first place?  If yes, it should have AI_V4MAPPED too.

I added a conditional #define AI_V4MAPPED to 0 at the top of this
file, the same way AI_ADDRCONFIG is handled.

> (Also I had to resolve a conflict in configure, so if you rebase
> on current master you'll save me having to do it twice...)

Immediately before sending the pull request, I did a rebase and rebuild.
Apparently you pulled some other change before trying to pull this.
I usually rebase right before sending the request.  Just did the
rebase again, and fixed he conflict with guest-agent-msi change.

Will resend the pull request.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Wolfgang Bumiller <w.bumiller@proxmox.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 00/21] Trivial patches for 2015-06-22
Date: Tue, 23 Jun 2015 20:08:33 +0300	[thread overview]
Message-ID: <55899291.306@msgid.tls.msk.ru> (raw)
In-Reply-To: <CAFEAcA9ru4tyzXNUW0USsN13wEP4v5hGOREbPZWVOkrLDS41=Q@mail.gmail.com>

22.06.2015 19:02, Peter Maydell wrote:

> Fails to build on Windows:
> 
> util/qemu-sockets.c: In function ‘inet_parse_connect_opts’:
> util/qemu-sockets.c:338: error: ‘AI_V4MAPPED’ undeclared (first use in this function)

Hmm.  Does WIN really have no AI_V4MAPPED?  Does it have getaddrinfo
in the first place?  If yes, it should have AI_V4MAPPED too.

I added a conditional #define AI_V4MAPPED to 0 at the top of this
file, the same way AI_ADDRCONFIG is handled.

> (Also I had to resolve a conflict in configure, so if you rebase
> on current master you'll save me having to do it twice...)

Immediately before sending the pull request, I did a rebase and rebuild.
Apparently you pulled some other change before trying to pull this.
I usually rebase right before sending the request.  Just did the
rebase again, and fixed he conflict with guest-agent-msi change.

Will resend the pull request.

Thanks,

/mjt

  parent reply	other threads:[~2015-06-23 17:08 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-22 11:16 [Qemu-trivial] [PULL 00/21] Trivial patches for 2015-06-22 Michael Tokarev
2015-06-22 11:16 ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 01/21] configure: append --extra-ldflags to LDFLAGS Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 02/21] remove libdecnumber/dpd/decimal128Local.h Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 03/21] Grammar: 'as to'->'as for' Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 04/21] Print error when failing to load PCI config data Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 05/21] pci-assign: QOMify Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 06/21] piix: piix3 QOMify Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 07/21] piix4: QOMify Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 08/21] wdt_i6300esb: QOMify Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 09/21] xen_pt: QOMify Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 10/21] vt82c686: QOMify Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 11/21] libcacard: pkgconfig: tidy dependent libs Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 12/21] configure: rearrange --help and consolidate enable/disable together Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 13/21] hw/display/qxl-logger.c: Constify some variable Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 14/21] throttle: Fix typo in the documentation of block_set_io_throttle Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 15/21] qemu-options: Improve -global documentation Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 16/21] qemu-options: Use @itemx where appropriate Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 17/21] Makefile: Fix "make cscope TAGS" Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 18/21] Makefile: Add "make ctags" Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 19/21] hw/display/cg3.c: Fix memory leak Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 20/21] hw/display/tcx.c: " Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 11:16 ` [Qemu-trivial] [PULL 21/21] util/qemu-sockets: improve ai_flag hints for ipv6 hosts Michael Tokarev
2015-06-22 11:16   ` [Qemu-devel] " Michael Tokarev
2015-06-22 16:02 ` [Qemu-trivial] [Qemu-devel] [PULL 00/21] Trivial patches for 2015-06-22 Peter Maydell
2015-06-22 16:02   ` Peter Maydell
2015-06-23  7:52   ` [Qemu-trivial] " Wolfgang Bumiller
2015-06-23  7:52     ` [Qemu-devel] [Qemu-trivial] " Wolfgang Bumiller
2015-06-23 17:08   ` Michael Tokarev [this message]
2015-06-23 17:08     ` [Qemu-devel] " Michael Tokarev
2015-06-23 17:15     ` [Qemu-trivial] " Peter Maydell
2015-06-23 17:15       ` [Qemu-devel] " Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55899291.306@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.