From: maxime.coquelin@st.com (Maxime Coquelin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] [media] use CONFIG_PM_SLEEP for suspend/resume
Date: Wed, 24 Jun 2015 13:02:25 +0200 [thread overview]
Message-ID: <558A8E41.1060104@st.com> (raw)
In-Reply-To: <565e229d31527f166090d0368a3c348755838899.1435142906.git.mchehab@osg.samsung.com>
On 06/24/2015 12:49 PM, Mauro Carvalho Chehab wrote:
> Using CONFIG_PM_SLEEP suppress the warnings when the driver is
> compiled without PM sleep functions:
>
> drivers/media/rc/st_rc.c:338:12: warning: ?st_rc_suspend? defined but not used [-Wunused-function]
> drivers/media/rc/st_rc.c:359:12: warning: ?st_rc_resume? defined but not used [-Wunused-function]
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
>
> diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c
> index 979b40561b3a..37d040158dff 100644
> --- a/drivers/media/rc/st_rc.c
> +++ b/drivers/media/rc/st_rc.c
> @@ -334,7 +334,7 @@ err:
> return ret;
> }
>
> -#ifdef CONFIG_PM
> +#ifdef CONFIG_PM_SLEEP
> static int st_rc_suspend(struct device *dev)
> {
> struct st_rc_device *rc_dev = dev_get_drvdata(dev);
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
Thanks!
Maxime
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Coquelin <maxime.coquelin@st.com>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
Patrice Chotard <patrice.chotard@st.com>,
<linux-arm-kernel@lists.infradead.org>, <kernel@stlinux.com>
Subject: Re: [PATCH 3/7] [media] use CONFIG_PM_SLEEP for suspend/resume
Date: Wed, 24 Jun 2015 13:02:25 +0200 [thread overview]
Message-ID: <558A8E41.1060104@st.com> (raw)
In-Reply-To: <565e229d31527f166090d0368a3c348755838899.1435142906.git.mchehab@osg.samsung.com>
On 06/24/2015 12:49 PM, Mauro Carvalho Chehab wrote:
> Using CONFIG_PM_SLEEP suppress the warnings when the driver is
> compiled without PM sleep functions:
>
> drivers/media/rc/st_rc.c:338:12: warning: ‘st_rc_suspend’ defined but not used [-Wunused-function]
> drivers/media/rc/st_rc.c:359:12: warning: ‘st_rc_resume’ defined but not used [-Wunused-function]
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
>
> diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c
> index 979b40561b3a..37d040158dff 100644
> --- a/drivers/media/rc/st_rc.c
> +++ b/drivers/media/rc/st_rc.c
> @@ -334,7 +334,7 @@ err:
> return ret;
> }
>
> -#ifdef CONFIG_PM
> +#ifdef CONFIG_PM_SLEEP
> static int st_rc_suspend(struct device *dev)
> {
> struct st_rc_device *rc_dev = dev_get_drvdata(dev);
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
Thanks!
Maxime
next prev parent reply other threads:[~2015-06-24 11:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 10:49 [PATCH 1/7] [media] si470x: cleanup define namespace Mauro Carvalho Chehab
2015-06-24 10:49 ` [PATCH 2/7] [media] tuner-i2c: be consistent with I2C declaration Mauro Carvalho Chehab
2015-06-24 10:49 ` [PATCH 3/7] [media] use CONFIG_PM_SLEEP for suspend/resume Mauro Carvalho Chehab
2015-06-24 10:49 ` Mauro Carvalho Chehab
2015-06-24 11:02 ` Maxime Coquelin [this message]
2015-06-24 11:02 ` Maxime Coquelin
2015-06-24 10:49 ` [PATCH 4/7] [media] saa7134: fix page size on some archs Mauro Carvalho Chehab
2015-06-24 10:49 ` [PATCH 5/7] [media] omap3isp: remove unused var Mauro Carvalho Chehab
2015-06-25 21:52 ` Laurent Pinchart
2015-06-24 10:49 ` [PATCH 6/7] [media] lmedm04: use u32 instead of u64 for relative stats Mauro Carvalho Chehab
2015-06-24 10:49 ` [PATCH 7/7] [media] lmedm04: fix the range for relative measurements Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558A8E41.1060104@st.com \
--to=maxime.coquelin@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.