From: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: Vaishali Thakkar
<vthakkar1994-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2] IB/srpt: Convert use of __constant_cpu_to_beXX to cpu_to_beXX
Date: Wed, 24 Jun 2015 10:18:44 -0700 [thread overview]
Message-ID: <558AE674.3080805@sandisk.com> (raw)
In-Reply-To: <20150624044213.GA4998@vaishali-Ideapad-Z570>
On 06/23/2015 09:42 PM, Vaishali Thakkar wrote:
> In little endian cases, the macro cpu_to_be{16,32,64} unfolds to
> __swab{16,32,64} which provides special case for constants. In
> big endian cases, __constant_cpu_to_be{16,32,64} and
> cpu_to_be{16,32,64} expand directly to the same expression. So,
> replace __constant_cpu_to_be{16,32,64} with cpu_to_be{16,32,64}
> with the goal of getting rid of the definitions of
> __constant_cpu_to_be{16,32,64} completely.
Reviewed-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Vaishali Thakkar <vthakkar1994@gmail.com>,
Doug Ledford <dledford@redhat.com>
Cc: Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] IB/srpt: Convert use of __constant_cpu_to_beXX to cpu_to_beXX
Date: Wed, 24 Jun 2015 10:18:44 -0700 [thread overview]
Message-ID: <558AE674.3080805@sandisk.com> (raw)
In-Reply-To: <20150624044213.GA4998@vaishali-Ideapad-Z570>
On 06/23/2015 09:42 PM, Vaishali Thakkar wrote:
> In little endian cases, the macro cpu_to_be{16,32,64} unfolds to
> __swab{16,32,64} which provides special case for constants. In
> big endian cases, __constant_cpu_to_be{16,32,64} and
> cpu_to_be{16,32,64} expand directly to the same expression. So,
> replace __constant_cpu_to_be{16,32,64} with cpu_to_be{16,32,64}
> with the goal of getting rid of the definitions of
> __constant_cpu_to_be{16,32,64} completely.
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
next prev parent reply other threads:[~2015-06-24 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 4:42 [PATCH v2] IB/srpt: Convert use of __constant_cpu_to_beXX to cpu_to_beXX Vaishali Thakkar
2015-06-24 4:42 ` Vaishali Thakkar
2015-06-24 17:18 ` Bart Van Assche [this message]
2015-06-24 17:18 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558AE674.3080805@sandisk.com \
--to=bart.vanassche-xdaiopvojttbdgjk7y7tuq@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=vthakkar1994-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.