From: Alex Elder <elder@ieee.org>
To: "Benoît Canet" <benoit.canet@nodalink.com>, ceph-devel@vger.kernel.org
Cc: idryomov@gmail.com
Subject: Re: [PATCH] libceph: Remove spurious kunmap() of the zero page
Date: Wed, 24 Jun 2015 19:35:05 -0500 [thread overview]
Message-ID: <558B4CB9.3000907@ieee.org> (raw)
In-Reply-To: <1435180719-12000-2-git-send-email-benoit.canet@nodalink.com>
On 06/24/2015 04:18 PM, Benoît Canet wrote:
> ceph_tcp_sendpage already does the work of mapping/unmapping
> the zero page if needed.
>
> Signed-off-by: Benoît Canet <benoit.canet@nodalink.com>
This looks good.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> net/ceph/messenger.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
> index 967080a..38f06a4 100644
> --- a/net/ceph/messenger.c
> +++ b/net/ceph/messenger.c
> @@ -278,7 +278,6 @@ static void _ceph_msgr_exit(void)
> ceph_msgr_slab_exit();
>
> BUG_ON(zero_page == NULL);
> - kunmap(zero_page);
> page_cache_release(zero_page);
> zero_page = NULL;
> }
>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-06-25 0:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 21:18 [PATCH] remove unbalanced kunmap Benoît Canet
2015-06-24 21:18 ` [PATCH] libceph: Remove spurious kunmap() of the zero page Benoît Canet
2015-06-25 0:35 ` Alex Elder [this message]
2015-06-25 9:12 ` Ilya Dryomov
2015-06-25 0:35 ` [PATCH] remove unbalanced kunmap Alex Elder
2015-06-25 0:38 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558B4CB9.3000907@ieee.org \
--to=elder@ieee.org \
--cc=benoit.canet@nodalink.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.